From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Seth Forshee <seth.forshee@canonical.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: Seth Forshee <seth.forshee@canonical.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: powerpc: Always initialize input array when calling epapr_hypercall()
Date: Sun, 8 Oct 2017 19:43:36 +1100 (AEDT) [thread overview]
Message-ID: <3y8xjh6CPKz9t5C@ozlabs.org> (raw)
In-Reply-To: <20170928133340.19312-1-seth.forshee@canonical.com>
On Thu, 2017-09-28 at 13:33:39 UTC, Seth Forshee wrote:
> Several callers to epapr_hypercall() pass an uninitialized stack
> allocated array for the input arguments, presumably because they
> have no input arguments. However this can produce errors like
> this one
>
> arch/powerpc/include/asm/epapr_hcalls.h:470:42: error: 'in' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> unsigned long register r3 asm("r3") = in[0];
> ~~^~~
>
> Fix callers to this function to always zero-initialize the input
> arguments array to prevent this.
>
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/186b8f1587c79c2fa04bfa392fdf08
cheers
prev parent reply other threads:[~2017-10-08 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 13:33 [PATCH] " Seth Forshee
2017-10-08 8:43 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3y8xjh6CPKz9t5C@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®