mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julian Braha <julianbraha@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: thierry.reding@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/panel/tianma-tl057fvxp01: add panel for Motorola Moto G6
Date: Mon, 18 Oct 2021 18:49:50 -0400	[thread overview]
Message-ID: <4000775.iezT5iszD9@ubuntu-mate-laptop> (raw)
In-Reply-To: <YWxeUd6PALatP7z/@ravnborg.org>

On Sunday, October 17, 2021 1:33:05 PM EDT Sam Ravnborg wrote:
> Hi Julian,
> 
> On Sun, Aug 08, 2021 at 04:08:54PM -0400, Julian Braha wrote:
> > This is a 5.7" 2160x1080 panel found on the Motorola Moto G6.
> > There may be other smartphones using it, as well.
> > 
> > Signed-off-by: Julian Braha <julianbraha@gmail.com>
> 
> Sorry for coming back so late. Driver looks good and is almost
> ready to apply. One detail you need to fix, see below.
> 
> 	Sam
> 
> > ---
> > +
> > +static const struct of_device_id tianma_tl057fvxp01_of_match[] = {
> > +	{ .compatible = "tianma,tl057fvxp01" },
> > +	{ /* sentinel */ }
> > +};
> The compatible needs to be documented before I can include the driver in
> the kernel. Please add a patch that document the compatible - maybe as a
> new binding file but preferably as part of one of the existing binding
> files.
> 
> 	Sam
> 

Hi Sam,

Thanks for your feedback! I've submitted a second patch for the bindings.

- Julian Braha



      parent reply	other threads:[~2021-10-18 22:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-08 20:08 Julian Braha
     [not found] ` <YWxeUd6PALatP7z/@ravnborg.org>
2021-10-18 22:49   ` Julian Braha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4000775.iezT5iszD9@ubuntu-mate-laptop \
    --to=julianbraha@gmail.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®