From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752608AbdDKOcJ (ORCPT ); Tue, 11 Apr 2017 10:32:09 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:37440 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752911AbdDKObm (ORCPT ); Tue, 11 Apr 2017 10:31:42 -0400 Subject: Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files To: Greg Kroah-Hartman References: <1491902071-17935-1-git-send-email-thierry.escande@collabora.com> <1491902071-17935-2-git-send-email-thierry.escande@collabora.com> <20170411141012.GD4388@kroah.com> <20170411141107.GE4388@kroah.com> Cc: linux-kernel@vger.kernel.org From: Thierry Escande Message-ID: <4000d6f8-904b-9507-36e5-d3eae8189ef0@collabora.com> Date: Tue, 11 Apr 2017 16:31:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170411141107.GE4388@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/2017 16:11, Greg Kroah-Hartman wrote: > On Tue, Apr 11, 2017 at 04:10:12PM +0200, Greg Kroah-Hartman wrote: >> On Tue, Apr 11, 2017 at 11:14:30AM +0200, Thierry Escande wrote: ... >>> + } >>> + >>> + return VPD_OK; >>> +} >>> +EXPORT_SYMBOL(decode_vpd_string); >> >> Normally put the prefix for the driver you are exporting from: >> vpd_string_decode()? >> >> And EXPORT_SYMBOL_GPL() perhaps? > > Wait, why is this even exported? You build this into the module that > needs it... > Right. Will fix that as well. Regards, Thierry