From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9734A28368A for ; Fri, 5 Sep 2025 09:19:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757063968; cv=none; b=aRH8CoqQSXJDbzY3QxrmhOR6v6KUBSU2PPRYwm+2W0Qqi2idne+CdmIJQxk1bNRaoGBcSkCceiR97s2i0t1H5Y003YUMe4Vax3VeOdtQGlSjKGEOQKw85ua4Kw8RJvGNEXJYYqPHmNlyorokclq4cTh+dN8qOU8yYwDzMQtkBTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757063968; c=relaxed/simple; bh=KIj4LNw/kvQGZYEBaGiUgR6MDjNc8MxHxSzTe1N9i3Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t7R8tnPa4azI8xkR8YXhHtge/ihVxo7BWPA8PatBerg+/dCXrbhrBCwY+yJ5OFVJTsaxXGN7Gl6/9kaUKfBO8Z07A6FuVTbmbeDBx085fZMpOI8qyw+p2wE1b1+MBlQf9rTQNYlCwZi910zsR14jAddg6w5gSHgJbFtXy8KQQ5Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m7aPbkrB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m7aPbkrB" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5856Om5c013660 for ; Fri, 5 Sep 2025 09:19:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5mheuVheNi86mdpcqpjAPrD0yOrcM0zmpE+Wh+IoKbM=; b=m7aPbkrBXZwIq3aD hOlXKrq0gqd9wvMNwbiJ//VYC+sWooDqXsbnyiYT443kmT533F4SAMcAB0ay5ah4 NADhLw8Q0F53Oquj4L9a0RLEGMQJ/ZB9C3+fcb9MQRuC6ldkyUl5eJgBKt9yiDJ8 NxR5sqv6b4XpjCF52O7XIIkek2/ZqCBrysp/z463BV+HrGs24xPsOETTNt5tV/ux TIUsIMBlmvxuW30HleGCIW1fqF5VPRosqFlj9JMZbvwbD4EUcooPIArBMSFCThHg rdQ49sx7S4MIwkgoPV6v3gWkCslUZfELzjo51s9ROF7XwDqDz4/Wn5Bw3kP7rvT5 KWdP3Q== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48w8wyehgr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 05 Sep 2025 09:19:25 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4b10991e9c3so3362391cf.0 for ; Fri, 05 Sep 2025 02:19:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757063965; x=1757668765; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5mheuVheNi86mdpcqpjAPrD0yOrcM0zmpE+Wh+IoKbM=; b=w/+EHz0eIKKLFCGj5e5zMurG5Kwv0UpwUIzNFsH7u8khwiIuaUa8nE3plSEGh3LzRU 6EZtsaH/lg6VLyVZiojSjtAQvdeYaFjlog4QUIK55vFWGSPsJRzNfGCkbVfUBv5xp5QJ PSDn4FUGFU5E2DLx9rT4FJEL9afCZsqXEMjiLKJ2i4XrshniWRfa1XekZ0CsGk2kPhDw vc0I/5xMCd06SObVKjpGO8esXh/nlmsPelmqWQpxYoOFtpB+mtNe9OMXZ18kuGsoZHs3 gjGLEn29+QMGKqVr737rN9Zrb4JTXo/vIm5jtXGoolVZ8IVDhFk+MYJk5gKuXsAYMsKz lShQ== X-Forwarded-Encrypted: i=1; AJvYcCW6l2DBPjX0IM5z7gb0oG8hXdtrZ7c3tX3EfM0LcvPUy5fC2qEj6j/yELLUss47U++euPF396dywwQHbZU=@vger.kernel.org X-Gm-Message-State: AOJu0YzFO8AS2SOgUKJQRm4Pwf4Q8hcglaeyL+6U+sMMtuhSeiop5Y9j ApHItisFG2Zg5FFkwC37oLAc33JiXWiZBElmIPyIY1khzb3RB3LMpFVfg2mUqlNG1f3fOM32PmB o9Q8arm58Jiyf0b4gNf8ilXwqC6TbGL428bYMzL820dI3t7ulvQS7vShWmRKFIZ5uUGk= X-Gm-Gg: ASbGncszFufv7qrK3lxfejW9es0eYhqEVFqjawWiW7UhNJCt17kVG14mm/BrMG4xP/5 SLS60FEnslStCquzkyXJSr/tunFmzasOmo0qcaVHZ8y8KA2WHKY9bfmDZ837+ogEcLMims8CcK/ T+Xo8Lyc0qM+/dBfG8dfKQXwLXaSv1BnX0gS0JPENQ5cmEQJp7cWy3w2k/EWSZU/fPhiAUQMdZ/ 2r1ln18Kzp2gJPMoqe9TTjYBv3Bv0oyHZ4PoukAkSQbGj1h5a/qys+3PDR3driiBxAR6Dp16LSD KQp0mCCWBnLhYa7MbRUv5DzNiTcC7BHAEQq5QZH8oPN/Je2SH8paQN5vGuM/lfhzxrk3OD9km3h U1CEmLmdyHelKFlbMuWZlnQ== X-Received: by 2002:ac8:5ac3:0:b0:4b5:e391:e3e0 with SMTP id d75a77b69052e-4b5e391eb76mr29836341cf.0.1757063964570; Fri, 05 Sep 2025 02:19:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3F9vSGXSxcO4h54j2pqoF+PplowVt51lj9Vy7KzWudaCZVbxujLAhE+/saQeA+isoTjlbXg== X-Received: by 2002:ac8:5ac3:0:b0:4b5:e391:e3e0 with SMTP id d75a77b69052e-4b5e391eb76mr29836081cf.0.1757063963994; Fri, 05 Sep 2025 02:19:23 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-61cfc22b594sm16732909a12.21.2025.09.05.02.19.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Sep 2025 02:19:23 -0700 (PDT) Message-ID: <4007710b-9e0c-499e-bbf7-246133ca9f21@oss.qualcomm.com> Date: Fri, 5 Sep 2025 11:19:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] watchdog: Add driver for Gunyah Watchdog To: Pavan Kondeti , hrishabh.rajput@oss.qualcomm.com Cc: Bjorn Andersson , Konrad Dybcio , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250903-gunyah_watchdog-v1-0-3ae690530e4b@oss.qualcomm.com> <20250903-gunyah_watchdog-v1-2-3ae690530e4b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Ycq95xRf c=1 sm=1 tr=0 ts=68baab1d cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=v9T48ajA7Nf6lPuJmEUA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: bu6-LF0KGML2C6yHLyq8e2LfheYCSEnD X-Proofpoint-ORIG-GUID: bu6-LF0KGML2C6yHLyq8e2LfheYCSEnD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTAxMDEwMSBTYWx0ZWRfX5QWsGQtsPkdO wjpkfvuHm13RTEgivm2G+NKoSKBuwpvyUyUcN3lTMeJAemAPEbjHTpeJmKAllayk+o5P6auZPDh OIlsKZQbYT6TzP0waX/d/WthkuCMGe9IlJ+6YLyqUD1wBQs22vVBKI3AsNoCv9moexV/Iet7Zc3 rP7G10PBkmgv5ALuSVPK+sZIH/avG6Qidhk5qRU4GaXBmaubiFyKUP2phzjg9slQGXUxE3mRZqU ka8Zr800U3wLV9Buh19a9sQhd62nX3MiZ6Oxzj7pIaAMq7wlTHBvUiNOsnYjViODxl4wDyt/b7o KXeneP9gVXIZ30dRq6OklqOYorJB0I8KZ73somuwvqUt3Jt8uQbVkMdQU1v3k3ZJUztn2rvkQqY rSwYlF0W X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-05_02,2025-09-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509010101 On 9/4/25 7:11 PM, Pavan Kondeti wrote: > On Wed, Sep 03, 2025 at 07:34:00PM +0000, Hrishabh Rajput via B4 Relay wrote: >> +static int gunyah_wdt_call(unsigned long func_id, unsigned long arg1, >> + unsigned long arg2, struct arm_smccc_res *res) >> +{ >> + arm_smccc_1_1_smc(func_id, arg1, arg2, res); >> + return gunyah_error_remap(res->a0); >> +} >> + >> +static int gunyah_wdt_start(struct watchdog_device *wdd) >> +{ >> + struct arm_smccc_res res; >> + unsigned int timeout_ms; >> + unsigned int pretimeout_ms; >> + int ret; >> + >> + ret = gunyah_wdt_call(GUNYAH_WDT_CONTROL, WDT_CTRL_DISABLE, 0, &res); >> + if (ret) >> + return ret; > > When I ran a simple echo test, it failed here on SM8650 with -EINVAL. May be Gunyah > does not allow disabling watchdog when it is not enabled in the first > place. May be something you can check if this is a difference between > 8750 vs 8650. Hm, makes one wonder if the opposite (won't enable when already enabled) is true.. Konrad