From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E85A0CA0ECE for ; Tue, 12 Sep 2023 06:30:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbjILGaI (ORCPT ); Tue, 12 Sep 2023 02:30:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbjILGaG (ORCPT ); Tue, 12 Sep 2023 02:30:06 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36BD9AF; Mon, 11 Sep 2023 23:30:01 -0700 (PDT) X-UUID: c92cfc32513511eea33bb35ae8d461a2-20230912 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date:Message-ID; bh=Ps11xcFJ0x4uz6iyg7AMvaIUrjPAirlB6aY9czV4xDE=; b=vCkFOL1vcaSohcJahl1Chi2ISjiaykoWU5d84NbbOnqzB9hG7rrF+73ra5roR4RSE5d/y1J2lptWWa/RoFqv0TxagT0/cNrUBhh0IwAQkslnvmjwA4wQsueoG+5hvYh2olWuIqDXmoD/BamXsAMPa/vDR28dASL9YTP9paI+59U=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.31,REQID:b201575f-c15e-4463-b57a-2f8980cd7f95,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:0ad78a4,CLOUDID:af8cecc2-1e57-4345-9d31-31ad9818b39f,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULS X-UUID: c92cfc32513511eea33bb35ae8d461a2-20230912 Received: from mtkmbs14n1.mediatek.inc [(172.21.101.75)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1460391974; Tue, 12 Sep 2023 14:29:54 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.194) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Tue, 12 Sep 2023 14:29:53 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Tue, 12 Sep 2023 14:29:52 +0800 Message-ID: <4010955c-9df7-da30-aef9-477ae8483e89@mediatek.com> Date: Tue, 12 Sep 2023 14:29:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] dt-bindings: arm64: dts: mediatek: add description for mt8365-evk board Content-Language: en-US To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , =?UTF-8?Q?Bernhard_Rosenkr=c3=a4nzer?= , , , , CC: Bear Wang , Pablo Sun , Macpaul Lin References: <20230911081126.18463-1-macpaul.lin@mediatek.com> <53cd72f7-5a8d-ee9e-4d8a-f5159cafb3e7@linaro.org> From: Macpaul Lin In-Reply-To: <53cd72f7-5a8d-ee9e-4d8a-f5159cafb3e7@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/11/23 17:49, Krzysztof Kozlowski wrote: > > > External email : Please do not click links or open attachments until you > have verified the sender or the content. > > On 11/09/2023 10:11, Macpaul Lin wrote: >> Fix the missing description for MediaTek mt8365-evk board. >> >> Fixes: 4f5fc078ac6f ("dt-bindings: arm64: dts: mediatek: Add mt8365-evk board") > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > > Thank you. In the previous modifications, I overlooked this suggestion. It will be corrected in the next version. >> Signed-off-by: Macpaul Lin >> --- >> Documentation/devicetree/bindings/arm/mediatek.yaml | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> change for v2: >> - rebase this patch to follow the v5 patch set of mt8395. >> - depends on https://lore.kernel.org/lkml/20230909132819.21626-2-macpaul.lin@mediatek.com/T/ >> - Fix description as a single board. >> >> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml >> index 2e8ad49c3479..b163995e32d5 100644 >> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml >> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml >> @@ -244,7 +244,8 @@ properties: >> - enum: >> - mediatek,mt8183-pumpkin >> - const: mediatek,mt8183 >> - - items: >> + - description: MediaTek Genio 350 Board (Genio 350 EVK) > > Drop, no need, redundant (copies the compatible) and your other entries > do not have it. The primary objective of this patch is to incorporate a description that will prevent users from confusing this platform with others. Additionally, it aids in identifying this as a "Genio EVK" for marketing purposes. > >> + items: >> - enum: > > This is still confusing. Why do you have enum here with such description. > In order to accommodate the current market situation for a single reference board, will replace this with a 'const'. > Best regards, > Krzysztof > Thanks Macpaul Lin