From: Bryan Whitehead <driver@jpl.nasa.gov>
To: Bryan Whitehead <driver@megahappy.net>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, akpm@osdl.org, nathans@sgi.com,
owner-xfs@oss.sgi.com
Subject: Re: [PATCH 2.6.2-rc1-mm2] fs/xfs/xfs_log_recover.c
Date: Sat, 24 Jan 2004 17:10:16 -0800 [thread overview]
Message-ID: <40131778.80008@jpl.nasa.gov> (raw)
In-Reply-To: <Pine.LNX.4.58.0401241655010.32008@mrhankey.homeip.net>
If I'm off base on this then sorry for the trouble. Just thought I'd
take a hit at getting rid of some compiler warnings..
Bryan Whitehead wrote:
> Oh, one more thing. After removed the superflurous switch statement flags
> will have a value which fixes the warning.
>
> If you look at the flow of code it is impossible for flags to not have a
> value when it gets to the if statement as the previous switch statement
> would give it a value. But since that switch statement only catches that
> one case anyway, it's better to merge the 2 switch statemnets.
>
> On Sat, 24 Jan 2004, Christoph Hellwig wrote:
>
>
>>On Fri, Jan 23, 2004 at 11:31:11PM -0800, Bryan Whitehead wrote:
>>
>>>This fixes a warning on compile of the xfs fs module.
>>
>>This patch looks very strange. What error do you get without it?
>>
>
>
--
Bryan Whitehead
Email:driver@megahappy.net
WorkE:driver@jpl.nasa.gov
prev parent reply other threads:[~2004-01-25 1:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-24 7:31 Bryan Whitehead
2004-01-24 8:26 ` Christoph Hellwig
2004-01-25 0:38 ` Bryan Whitehead
2004-01-25 0:57 ` Bryan Whitehead
2004-01-25 1:10 ` Bryan Whitehead [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40131778.80008@jpl.nasa.gov \
--to=driver@jpl.nasa.gov \
--cc=akpm@osdl.org \
--cc=driver@megahappy.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathans@sgi.com \
--cc=owner-xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®