From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42FB3C41604 for ; Wed, 7 Oct 2020 14:59:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD64321531 for ; Wed, 7 Oct 2020 14:59:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CzBtHOJo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728763AbgJGO7n (ORCPT ); Wed, 7 Oct 2020 10:59:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25726 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728694AbgJGO7n (ORCPT ); Wed, 7 Oct 2020 10:59:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602082782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7N51+8sQh2H8W9MnGonUz2RHvBYt0K/Eby2kep8UCRc=; b=CzBtHOJoPIqbn6/G7RsUJFBNrI5+uMV8r8+YaZo9yY7J6sW6ZS2A/wML3Q3OhHqx3vQylr IFYqMvrw92N7T8GNqGjSxhpA77ILeD3FL1BYw3YNf4y2jYk8aSvKmE/4mmjjNSMDtAPx9Q Pxmz9l3WGquI/kRBAsx/S0Mt0fqzhcw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-5-B_T5IR5CNSmQWc6bIYMBCw-1; Wed, 07 Oct 2020 10:59:38 -0400 X-MC-Unique: B_T5IR5CNSmQWc6bIYMBCw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 652AE191E2A0; Wed, 7 Oct 2020 14:59:37 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-116-196.rdu2.redhat.com [10.10.116.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C0B96EF42; Wed, 7 Oct 2020 14:59:36 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <160207693283.3934207.6150787285715868358.stgit@warthog.procyon.org.uk> References: <160207693283.3934207.6150787285715868358.stgit@warthog.procyon.org.uk> To: torvalds@linux-foundation.org Cc: dhowells@redhat.com, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] afs: Fix deadlock between writeback and truncate MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4013287.1602082775.1@warthog.procyon.org.uk> Date: Wed, 07 Oct 2020 15:59:35 +0100 Message-ID: <4013288.1602082775@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Howells wrote: > (1) Use the vnode validate_lock to mediate access between afs_setattr() > and afs_writepages(): Hmmm... I wonder if the problem can occur between afs_setattr() and afs_writepage() too. David