From: Jens Axboe <axboe@kernel.dk>
To: Eduardo Valentin <eduval@amazon.com>
Cc: "jianchao.wang" <jianchao.w.wang@oracle.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Anchal Agarwal <anchalag@amazon.com>,
Frank van der Linden <fllinden@amazon.com>
Subject: Re: [PATCH] blk-wbt: get back the missed wakeup from __wbt_done
Date: Fri, 24 Aug 2018 11:17:13 -0600 [thread overview]
Message-ID: <40137009-76ed-d48b-758e-d09283305fb7@kernel.dk> (raw)
In-Reply-To: <20180824171439.GA12587@u40b0340c692b58f6553c.ant.amazon.com>
On 8/24/18 11:14 AM, Eduardo Valentin wrote:
>> + if (lock) {
>> + spin_unlock_irq(lock);
>> + io_schedule();
>> + spin_lock_irq(lock);
>> + } else
>> + io_schedule();
>
> Nitpick but, shouldn't this look like:
>
> + if (lock) {
> + spin_unlock_irq(lock);
> + io_schedule();
> + spin_lock_irq(lock);
> + } else {
> + io_schedule();
> + }
Depends on who you ask... I prefer the former.
> And another random though, it would be good to have some sort of
> tracing of this.
wbt does have tracing, but we've never had tracing on the sleep/wakeup
parts. But that's pretty much completely orthogonal to the issue, that
should be done as a separate patch, if useful.
BTW, I've now tested this and it seems to work fine for me.
--
Jens Axboe
prev parent reply other threads:[~2018-08-24 17:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 13:08 Jianchao Wang
2018-08-23 15:37 ` Jens Axboe
2018-08-23 16:24 ` van der Linden, Frank
[not found] ` <20180823210144.GB5624@kaos-source-ops-60001.pdx1.amazon.com>
2018-08-23 23:03 ` Jens Axboe
2018-08-23 23:14 ` Jens Axboe
2018-08-24 5:55 ` jianchao.wang
2018-08-24 16:40 ` van der Linden, Frank
2018-08-24 16:44 ` Jens Axboe
[not found] ` <20180824181223.GA9049@kaos-source-ops-60001.pdx1.amazon.com>
2018-08-24 18:50 ` Jens Axboe
[not found] ` <20180824203305.GA4690@kaos-source-ops-60001.pdx1.amazon.com>
2018-08-24 20:41 ` Jens Axboe
2018-08-25 15:41 ` Jens Axboe
2018-08-27 3:52 ` jianchao.wang
2018-08-27 6:15 ` jianchao.wang
2018-08-27 14:51 ` Jens Axboe
2018-08-28 2:52 ` jianchao.wang
2018-08-27 15:37 ` Jens Axboe
2018-08-23 15:42 ` Jens Axboe
2018-08-24 2:06 ` jianchao.wang
2018-08-24 14:40 ` Jens Axboe
2018-08-24 14:58 ` Jens Axboe
2018-08-24 17:14 ` Eduardo Valentin
2018-08-24 17:17 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40137009-76ed-d48b-758e-d09283305fb7@kernel.dk \
--to=axboe@kernel.dk \
--cc=anchalag@amazon.com \
--cc=eduval@amazon.com \
--cc=fllinden@amazon.com \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome