From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, kees@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] iio: ssp_sensors: ssp_spi: use guard() to release mutexes
Date: Sat, 28 Mar 2026 12:24:11 +0530 [thread overview]
Message-ID: <4017E54C-B25B-41AC-B4E1-F28576C2D64C@gmail.com> (raw)
In-Reply-To: <acT6vokgYuUTsWcj@ashevche-desk.local>
On 26 March 2026 2:52:06 pm IST, Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
>On Thu, Mar 26, 2026 at 01:48:14PM +0530, Sanjay Chitroda wrote:
>
>> Replace explicit mutex_lock() and mutex_unlock() with the guard() macro
>> for cleaner and safer mutex handling.
>
>NAK. Please, be very careful when do such changes.
>
>...
>
>> msg->done = done;
>>
>> - mutex_lock(&data->comm_lock);
>> + guard(mutex)(&data->comm_lock);
>>
>> status = ssp_check_lines(data, false);
>> - if (status < 0)
>> - goto _error_locked;
>> + if (status < 0) {
>> + data->timeout_cnt++;
>> + return status;
>> + }
>>
>> status = spi_write(data->spi, msg->buffer, SSP_HEADER_SIZE);
>> if (status < 0) {
>> gpiod_set_value_cansleep(data->ap_mcu_gpiod, 1);
>> dev_err(SSP_DEV, "%s spi_write fail\n", __func__);
>> - goto _error_locked;
>> + data->timeout_cnt++;
>> + return status;
>> }
>>
>> if (!use_no_irq) {
>> - mutex_lock(&data->pending_lock);
>> + guard(mutex)(&data->pending_lock);
>> list_add_tail(&msg->list, &data->pending_list);
>> - mutex_unlock(&data->pending_lock);
>> }
>>
>> status = ssp_check_lines(data, true);
>> if (status < 0) {
>> if (!use_no_irq) {
>> - mutex_lock(&data->pending_lock);
>> + guard(mutex)(&data->pending_lock);
>> list_del(&msg->list);
>> - mutex_unlock(&data->pending_lock);
>> }
>> - goto _error_locked;
>> + data->timeout_cnt++;
>> + return status;
>> }
>
>> - mutex_unlock(&data->comm_lock);
>> -
>
>Pzzz! See what you are doing here...
>
>> if (!use_no_irq && done)
>> if (wait_for_completion_timeout(done,
>> msecs_to_jiffies(timeout)) ==
>> 0) {
>> - mutex_lock(&data->pending_lock);
>> + guard(mutex)(&data->pending_lock);
>> list_del(&msg->list);
>> - mutex_unlock(&data->pending_lock);
>>
>> data->timeout_cnt++;
>> return -ETIMEDOUT;
>> }
>>
>> return 0;
>> -
>> -_error_locked:
>> - mutex_unlock(&data->comm_lock);
>> - data->timeout_cnt++;
>> - return status;
>> }
>
Thank Andy for pointing this out — you’re right, using "guard(mutex)" here unintentionally extends the lifetime of "comm_lock" and can hold it across the completion wait, which is not safe.
I’ve reworked the change to keep the original locking semantics intact:
- "comm_lock" is still explicitly unlocked before "wait_for_completion_timeout()"
- No sleeping paths are executed while holding "comm_lock"
- Introduced small helpers to simplify the flow:
- "ssp_send_and_enqueue()" for SPI write + pending list add
- "ssp_dequeue_msg()" for safe removal from the pending list
Updated flow looks like this:
mutex_lock(&data->comm_lock);
status = ssp_check_lines(data, false);
if (status < 0)
goto err;
status = ssp_send_and_enqueue(data, msg, use_no_irq);
if (status < 0)
goto err;
status = ssp_check_lines(data, true);
if (status < 0) {
if (!use_no_irq)
ssp_dequeue_msg(data, msg);
goto err;
}
mutex_unlock(&data->comm_lock);
/* wait outside lock */
if (!use_no_irq && done) {
if (wait_for_completion_timeout(done,
msecs_to_jiffies(timeout)) == 0) {
ssp_dequeue_msg(data, msg);
data->timeout_cnt++;
return -ETIMEDOUT;
}
}
return 0;
err:
mutex_unlock(&data->comm_lock);
data->timeout_cnt++;
return status;
This keeps the synchronization boundary unchanged while reducing duplication around pending list handling. I’ve also limited "guard()" usage to short, local critical sections only.
Please let me know if you’d prefer keeping the list operations inline instead of helpers.
next prev parent reply other threads:[~2026-03-28 6:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 8:18 [PATCH v4 0/4] iio: ssp_sensors: improve resource cleanup with cleanup.h Sanjay Chitroda
2026-03-26 8:18 ` [PATCH v4 1/4] iio: ssp_sensors: cleanup codestyle warning Sanjay Chitroda
2026-03-26 8:18 ` [PATCH v4 2/4] iio: ssp_sensors: cleanup codestyle check Sanjay Chitroda
2026-03-26 8:18 ` [PATCH v4 3/4] iio: ssp_sensors: ssp_spi: use guard() to release mutexes Sanjay Chitroda
2026-03-26 9:22 ` Andy Shevchenko
2026-03-28 6:54 ` Sanjay Chitroda [this message]
2026-03-29 11:44 ` Andy Shevchenko
2026-03-30 16:17 ` Sanjay Chitroda
2026-04-01 3:19 ` Sanjay Chitroda
2026-03-26 8:18 ` [PATCH v4 4/4] iio: ssp_sensors: reuse preallocated RX buffer for SPI transfers Sanjay Chitroda
2026-03-26 9:25 ` Andy Shevchenko
2026-03-28 5:02 ` Sanjay Chitroda
2026-03-28 8:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4017E54C-B25B-41AC-B4E1-F28576C2D64C@gmail.com \
--to=sanjayembeddedse@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kees@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®