From: Bryan Whitehead <driver@jpl.nasa.gov>
To: Bryan Whitehead <driver@megahappy.net>
Cc: ctindel@users.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.2] drivers/net/bonding/bond_alb.c
Date: Wed, 04 Feb 2004 22:55:13 -0800 [thread overview]
Message-ID: <4021E8D1.80006@jpl.nasa.gov> (raw)
In-Reply-To: <20040205065051.0EF40FA5F1@mrhankey.megahappy.net>
oops, sorry for duplicate email, thought I didn't send in the patch
already...
Bryan Whitehead wrote:
> __constant_htons is used on a variable that is only a byte. This results
> in an if statement always returning true in function bond_alb_xmit.
>
> This is the compiler warning on gcc 3.3.2 a gentoo linux system:
> CC [M] drivers/net/bonding/bond_alb.o
> drivers/net/bonding/bond_alb.c: In function `bond_alb_xmit':
> drivers/net/bonding/bond_alb.c:1340: warning: comparison is always true due to limited range of data type
>
> Here is the patch:
> --- linux-2.6.2/drivers/net/bonding/bond_alb.c.orig 2004-02-04 15:08:04.228336168 -0800
> +++ linux-2.6.2/drivers/net/bonding/bond_alb.c 2004-02-04 15:26:03.769221008 -0800
> @@ -1336,8 +1336,7 @@ bond_alb_xmit(struct sk_buff *skb, struc
> break;
> }
>
> - if (ipx_hdr(skb)->ipx_type !=
> - __constant_htons(IPX_TYPE_NCP)) {
> + if (ipx_hdr(skb)->ipx_type != IPX_TYPE_NCP) {
> /* The only protocol worth balancing in
> * this family since it has an "ARP" like
> * mechanism
>
>
> --
> Bryan Whitehead
> driver@megahappy.net
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Bryan Whitehead
Email:driver@megahappy.net
WorkE:driver@jpl.nasa.gov
next prev parent reply other threads:[~2004-02-05 7:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-05 6:50 Bryan Whitehead
2004-02-05 6:55 ` Bryan Whitehead [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-02-04 23:33 Bryan Whitehead
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4021E8D1.80006@jpl.nasa.gov \
--to=driver@jpl.nasa.gov \
--cc=ctindel@users.sourceforge.net \
--cc=driver@megahappy.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®