From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E562136B for ; Wed, 24 Apr 2024 00:01:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713916879; cv=none; b=mAsVRWTQsY8a0LPB8Y0V3CCO4P7fMvm036cCwJlwr4R/6p5WzBOimLzyLFNvbJxm4ab7K+Tzpf/KSBgmkyzrqsXbcUv/c/CZxubx/rgXhWmOVuWU6BU79CUNvVWWm1/fvncq7UGITUFyO/pXOqN4MxnH0OUYuF+pc7s0PIuN5Zc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713916879; c=relaxed/simple; bh=FlGCPz9SGenILdhF8xtuorosJuisz2ItVng/S0g5r6E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ASSfRToK8DO8hxl+A2xL6/g9zAmmt6i2jc4oSkSJKfo8jZNNmUCsm37CG6BhJaAAxXlmA9Qt92NKV2eIaeoqcCtbkva41X6xhcY/vLqHGfttK35YCGUo0+mPNyGW0dFILqZaF1d7as5iwGcU3H2QTIqoJ3tKJHUgHS23e79x64M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JbuNX78n; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JbuNX78n" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4155819f710so52544845e9.2 for ; Tue, 23 Apr 2024 17:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713916876; x=1714521676; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zsaJN6SDatJpYxGO39STEsAbfE+Fwe8phzl0Lbv9X/w=; b=JbuNX78nqH0mAfNc9nLQragiII5hZiROcV/E4YP8bqSBEnHiD9yXMxZ3ytXORm+96E ursuaGKu+aRrFBx5ByVKn2U5ExrGycoKB6X2Y6GuUZUcAhuTwdb7mcXEl6Y4Owb0RybQ LL3hSmUk/hLNFHPqcEZ/pFNqkA7CqPSJtoO0R5hWYCPu4GVPWsyfhFFQ6r8c3GW2SraU btj+sEWk703LwN97dgqfhhCjqd9nLBVFnmvqdEdN868ITlo5ZAK8XLHrGoPhyFtMDDnj r3dAfPTJZO2pn/KZ/y99JUUtMqmWCL+0JMvR5sE1Xll/RIaifyzHWZXkCSsJ80Xo66g9 9qFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713916876; x=1714521676; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zsaJN6SDatJpYxGO39STEsAbfE+Fwe8phzl0Lbv9X/w=; b=D1XbJcGdSMJzw7NWc6+2XfGplzVDTArrs2hi5gaOSW+/EqusCEX1Bev0Is/APZE4l+ 0+WKaO/EugUpYv659s60Yfzy+TRfmH364Kvr3SI9hlmFP8VKqJLVpspU020lR1XwVdps vDtuDAO6LbpUwoAyRDaIhZeyJOlE8NMRfX0TTng12I2ki5y2fdS6nx+OOueayTPKQI8o M989YhZFwG0xeFxn2Iy15D/jFvDowCAB+5j27KnoWPQs1yEWnQ3hGTjuG9Z0xtudzRbv NBeUihFoL8JrC5CIrqt36zJ8ZIm+O1hfyYJNb7iq95/T9+aK1RxJnLe1Qyxcofwq/FaJ 6Ciw== X-Forwarded-Encrypted: i=1; AJvYcCXUwH8SRut63VaOVK9MV9CpuISaiHnXVtj1gaR7AGaxu6ge9lihVaJ6xzvjLzHL3lc2zJOMWlIHrbTJ9jpDmZwubZnj3Zbb6x4xVTJp X-Gm-Message-State: AOJu0Yy8ybYl00/A51vpHnRzy4xIbHiv2mrhrMWZq80WR2BxNaDGwCdE KwKmaHdo27wgHwy5K3VSYZcsahXEcYWtNleZddbCUjA+0GHzZo9+BJ4uzdOZoL8= X-Google-Smtp-Source: AGHT+IELghywWCMPx0pelmAeEjjnEwDnuikrcmKL/8eSocRVR4XO2UIGCfF62Wk+H62jE6je6spPjg== X-Received: by 2002:a05:600c:4fd0:b0:418:d68d:f1fb with SMTP id o16-20020a05600c4fd000b00418d68df1fbmr674433wmq.31.1713916876258; Tue, 23 Apr 2024 17:01:16 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id l16-20020a05600c4f1000b0041a1fee2854sm11231876wmq.17.2024.04.23.17.01.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Apr 2024 17:01:15 -0700 (PDT) Message-ID: <4028de21-33ea-4172-904f-e6809ef9a878@linaro.org> Date: Wed, 24 Apr 2024 01:01:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/4] MSM8976 MDSS/GPU/WCNSS support To: Adam Skladowski Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240413170317.34553-1-a39.skl@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240413170317.34553-1-a39.skl@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/04/2024 18:03, Adam Skladowski wrote: > This patch series provide support for display subsystem, gpu > and also adds wireless connectivity subsystem support. > > Changes since v2 > ================ > 1. Disabled mdss_dsi nodes by default > 2. Changed reg size of mdss_dsi0 to be equal on both > 3. Added operating points to second mdss_dsi > 4. Brought back required opp-supported-hw on adreno > 5. Moved status under operating points on adreno > > Changes since v1 > ================ > 1. Addressed feedback > 2. Dropped already applied dt-bindings patches > 3. Dropped sdc patch as it was submitted as part of other series > 4. Dropped dt-bindings patch for Adreno, also separate now > > Adam Skladowski (4): > arm64: dts: qcom: msm8976: Add IOMMU nodes > arm64: dts: qcom: msm8976: Add MDSS nodes > arm64: dts: qcom: msm8976: Add Adreno GPU > arm64: dts: qcom: msm8976: Add WCNSS node > > arch/arm64/boot/dts/qcom/msm8976.dtsi | 536 +++++++++++++++++++++++++- > 1 file changed, 532 insertions(+), 4 deletions(-) > I remembered you pinged me in IRC about my previous review feedback. Would appreciate if you could add a response email to your cover letter explaining why that's not done. I'm sure you're probably right but, good practice is to state in your log what was and wasn't done and why. --- bod