From: Reinette Chatre <reinette.chatre@intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-kselftest@vger.kernel.org, "Shuah Khan" <shuah@kernel.org>,
"Maciej Wieczór-Retman" <maciej.wieczor-retman@intel.com>,
"Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>
Cc: <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH v4 1/7] selftests/resctrl: Fix uninitialized .sa_flags
Date: Mon, 2 Oct 2023 08:40:02 -0700 [thread overview]
Message-ID: <402ba5fd-c773-f352-5f57-2dc8703a7b72@intel.com> (raw)
In-Reply-To: <20231002094813.6633-2-ilpo.jarvinen@linux.intel.com>
Hi Ilpo,
On 10/2/2023 2:48 AM, Ilpo Järvinen wrote:
> signal_handler_unregister() calls sigaction() with uninitializing
> sa_flags in the struct sigaction.
>
> Make sure sa_flags is always initialized in signal_handler_unregister()
> by initializing the struct sigaction when declaring it. Also add the
> initialization to signal_handler_register() even if there are no know
> bugs in there because correctness is then obvious from the code itself.
>
> Fixes: 73c55fa5ab55 ("selftests/resctrl: Commonize the signal handler register/unregister for all tests")
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Cc: <stable@vger.kernel.org>
Thank you.
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
next prev parent reply other threads:[~2023-10-02 15:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 9:48 [PATCH v4 0/7] selftests/resctrl: Fixes to failing tests Ilpo Järvinen
2023-10-02 9:48 ` [PATCH v4 1/7] selftests/resctrl: Fix uninitialized .sa_flags Ilpo Järvinen
2023-10-02 15:40 ` Reinette Chatre [this message]
2023-10-02 9:48 ` [PATCH v4 2/7] selftests/resctrl: Extend signal handler coverage to unmount on receiving signal Ilpo Järvinen
2023-10-02 9:48 ` [PATCH v4 3/7] selftests/resctrl: Remove duplicate feature check from CMT test Ilpo Järvinen
2023-10-02 9:48 ` [PATCH v4 4/7] selftests/resctrl: Move _GNU_SOURCE define into Makefile Ilpo Järvinen
2023-10-02 9:48 ` [PATCH v4 5/7] selftests/resctrl: Refactor feature check to use resource and feature name Ilpo Järvinen
2023-10-02 9:48 ` [PATCH v4 6/7] selftests/resctrl: Fix feature checks Ilpo Järvinen
2023-10-02 9:48 ` [PATCH v4 7/7] selftests/resctrl: Reduce failures due to outliers in MBA/MBM tests Ilpo Järvinen
2023-10-02 11:31 ` [PATCH v4 0/7] selftests/resctrl: Fixes to failing tests Ilpo Järvinen
2023-10-02 15:49 ` Reinette Chatre
2023-10-10 0:17 ` Shaopeng Tan (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=402ba5fd-c773-f352-5f57-2dc8703a7b72@intel.com \
--to=reinette.chatre@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®