From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793792142; b=qeFVlQj/YdF9FTY0N/awohQ/2ajGiGkvoUxkNHC8RDcrmDFRl+sEe1vav88oko3GORUy yHPl7HvszM9XmWFji1KlC7/TEwyZ01+xxMG4wCJ15ywuJuwLu4TNjf61soPMWA0LLd7UG usEzwR10yDAI/S7sgDCgT1p8xm725ESyk+iaGybvCK9ne9SXiwkz81Jgi3wEHtxt2uWvL hhvhDcB76JqohN7QVtcWWAJzYU8AzuIlH4DUACx8FaaFL8JhQXMSuDR6hQuGn7G3V0sas jhbHAUhtKR4JjDY532Wvk6YKDv27MN5RIpMW2ub1WtncNLEDx1J4pJxPvfVFCg7zmCA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793792142; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Authority-Analysis:X-Proofpoint-ORIG-GUID: X-Proofpoint-GUID:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-Spam-Info:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=txitwvcbrK3UUlmG/sF+VNbr8sls515kGNNrpbN6uNk=; b=O4aiiLNLI+D3u2VrxfdcQiL8QXKm4VQ+/E04Zup5YSWIDV7WVrFUxZQ6itbqHT5WFG5s AXP8FNWI6W9SP0YuBlCbTdgRhnV+UdnBAHipdONQXwkIkolrwNRTfb48BxtsVObv3M4l+ BUEmbQJU4fXcraclC5Ls7B0SOGg+Xig0mvLn+0wVoedXy11gmrZVLgjOpQOTGntuzJyVw QHfcyM/ekVDt2ICCgClqTIXjTF+GosUdlwfwYCRzzYJEDhkI0JW/aEmN7JwU8/URre8pz +2rXWoJ2la5Te4t+PS6rLosaLsLxTbu/xcDirrlR1tfxrUcmSZsSwPFdHC+Hz6wzaEQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=ck02Y+UJ; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=NDuh9B3F; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 877CF606A328 for ; Wed, 4 Nov 2026 11:35:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 877CF606A328 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=ck02Y+UJ; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=NDuh9B3F Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A4B5EOG2217099 for ; Wed, 4 Nov 2026 11:35:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= txitwvcbrK3UUlmG/sF+VNbr8sls515kGNNrpbN6uNk=; b=ck02Y+UJvwJSSmFS M55HtH/FtnsUGn9Tbee4EBYAz+jiBvjtOuOhvidebv/aZCR4K9F6bFyWTu6Tsg6q eliAVRowRn4LyU93XUJbaX2uTm6MOITccmE+N5GYNH/sp8PrnDIwCeitpIME8rKR sT6OFiTlqGJRVoamGQ0E9B3f9UVC6RklxeUyjcyRQnCnclYS9L1IXK9Y/271a4tC jwTwMQX7G+KkBv2ulIFSZmN/ql6UJ5f8THjzCGWBSrvEMD+8ksvwo2mOfr7Idd4B Vw4cytVN6dqxdtlS9Wit2Q89X45rz6VtcI5TqXAnKanyuOfAvzqPYEUmfJAaXCAZ OAIliw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hr284rede-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Nov 2026 11:35:40 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2ed08b07232so5823155ad.3 for ; Wed, 04 Nov 2026 03:35:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793792139; x=1794396939; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=txitwvcbrK3UUlmG/sF+VNbr8sls515kGNNrpbN6uNk=; b=NDuh9B3F8w0RRQbk4DOFCTn6/pF/Q/Yc63kQVlkQXByE6x0t7x2MSnPnWfoOxkGSQF dF0UiccXhotfXe/MF2aS+8uyapCV9O2oojioOQZ+UwjoQSuZoI51pVqlKPeOpsr7iu1s prslK+7+tIp6F0Tb9Oxhl6xfmUkr0VQu+Wa1gGJUcH3e5EIO6M/qmSuFcw9HrACfCW6y c8HYiPqMO3V+IGm/z4TRhT5Eahk5zVoDME+6IoaZj9+oGkTuRCGDxudetjDRcv5Mhypi ly8WY8VL5Qw8uV5XRrNPmNX/2B0trrXe16JJxenzmNeYPbHcX5G33FUuievp81LFLZa2 Ym9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793792139; x=1794396939; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=txitwvcbrK3UUlmG/sF+VNbr8sls515kGNNrpbN6uNk=; b=FwQBKJUXbu0T0ji7mXNf7jDnso8Xx0zPYfZE4U3q4dmSHcYdWgMtWKiV3lCZCx3cJw mtDT9C5N3FDuNmKiIR8dpEbXVXJ/uegCVzHkW1bVeayOnkoIa8fxzjjGh4djtu9flV7B JtRVHodizsWMDxk7AUkdCyG+DXI09aIVO8pNWYp9Qukklzxzx6kNgqBjSvfSDp+k4rgH DrVXs0L1K33qiOBdfC3oHNNqP/i4TeK3toQr0dmXlXL9ZJua0mkHUkObE8+tP5tfSyZZ xVkpHVAI6lEsx3sVCuf9VLuNmS8hY7pmxabsvMMPmlFzsG6w+6F95A0Le0QVOakBIFMR Rfwg== X-Forwarded-Encrypted: i=1; AKwUvBxcEtjwGNu5XX6WcstTn+8w5FVKX4gkyGqcTEvnEYBpu1cDBVYR9AYCVCvdmtc1wfSbCRIUN3WhGTDrNb4=@vger.kernel.org X-Gm-Message-State: APuU4Z9Ry6pTXqQiMbDjGkMW74tYehd9+hZzEQJl/1UXiG2rq0YRmIAM M5HuBHAg5h4S5sKJhLEzoJVzGOiK6iCYOz6cPeU6ML2rp6/RQe6W405SmwkChnLjVkOhOfGjxLm 0+W7hWMW1WnFbOLr9jpvcnILQoQKd/E5Dh5KDWhkpH5Z/xXJC3VicjkTKpFcCuFuC9vg= X-Gm-Gg: AYBFou3r5PDQ4gJSAESM/aLUgui4bk8FGZ1YiCs23KRVVNdONKXU/CQBGUScnOUAJTp RvDeUUA3Q6M9KBF50CPLCDSua5FPq1TtcNEFuLhsvP6Jtr4X8ifUzMLhesuJNAV23ipw+aIEEI/ 46Slz/XQKkzvm3t5ar4nGcvY1D1UynEWM8sTGmsCh6vdak5kAeCOPlHNrZxAHT/GWkfoRicCoZt J1FbMQmNeLgeAi4QNzEJI1ZIq3ctX4uXg0mVyqjKSle66Bu6sZiXJFvPdvIwqgEqzjv9TPO6RT0 h1T2vLhx9H0KYYLKpNGCvbcJC5Zo0jQgmvQJcgQ+S5hueBvsrzMxeQQQHgm8vMnjoDSlb1g4X2u pm38xweDVkphmn9HDUF2QoseUsK4dGCeNr7IJAd3WRIqmT1TITdX0N0QoAzuXW/gigpcIlN4Vj9 M= X-Received: by 2002:a17:903:388b:b0:2df:9d04:403b with SMTP id d9443c01a7336-2eb364b5c40mr142899215ad.32.1793792139045; Wed, 04 Nov 2026 03:35:39 -0800 (PST) X-Received: by 2002:a17:903:388b:b0:2df:9d04:403b with SMTP id d9443c01a7336-2eb364b5c40mr142898975ad.32.1793792138559; Wed, 04 Nov 2026 03:35:38 -0800 (PST) Received: from [10.218.30.203] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ed08bd5845sm6106805ad.2.2026.11.04.03.35.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Nov 2026 03:35:38 -0800 (PST) Message-ID: <402ecf6a-357a-4404-985c-9540f6851f8e@oss.qualcomm.com> Date: Wed, 4 Nov 2026 17:05:33 +0530 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: remoteproc: qcom,shikra-pas: Allow 3 IOMMUs for LPAICP To: Mukesh Ojha Cc: Bjorn Andersson , Konrad Dybcio , Abel Vesa , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mathieu Poirier , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org References: <20261005-shikra-el2-v3-0-618f7343695c@oss.qualcomm.com> <20261005-shikra-el2-v3-1-618f7343695c@oss.qualcomm.com> <20261005153737.opzzuflsioi6cxqo@hu-mojha-hyd.qualcomm.com> Content-Language: en-US From: Komal Bajaj In-Reply-To: <20261005153737.opzzuflsioi6cxqo@hu-mojha-hyd.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=JdQpPkKV c=1 sm=1 tr=0 ts=6aeb188c cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=49plGf3O2Pee3ShZFYoA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: EiTPG3W0IJH8nfRGFgwnm8TIOjSwO7ts X-Proofpoint-GUID: EiTPG3W0IJH8nfRGFgwnm8TIOjSwO7ts X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTA0MDA0NSBTYWx0ZWRfXz11iKWmOxwd/ F5S4FAa7kWLVhC/X1DlCaOMuiUzAEtGaw6eYhBhHZCW4AAzV497zwMUw5Myx9trP0BbfL+PNkuN KOgAlXbWHvIQfGu5VzT7tv9cce0y/3tVf06LuAH4vwBm0yHzvM3sFH/jkZ93I69Go6gio+q8+z+ Ysz6VvuYlW9r8P33hJ96/CFxIQk3sPWOko0OegL6ldGZWKorRSCfy9mtLQugWWJkaR6NEaYg7Ub wLGwGu1jJ5dKV5SFKOBn7CLLZPKN1jA9x7fUTK6NNEOksZ+uUBbRt6pXtRNOlfxUnddPQ4kEMzV FTkoEUrcFq2K1Zw+m/B01YlYc12tbl3jpfs1QCOGLgasP8s4vhXmGjbD0viInkkZpSYuuAqmgie ix86jp1I3f5jTUjWfw80ViF8+QCKE4b8qmy+K4tm9eMr9Bg6OuCY/EnMLQW4p3g5fBdy+BV7SoZ rDclEGhDe88SOL4qlPw== X-Proofpoint-Spam-Info: AW1haW4tMjYxMTA0MDA0NSBTYWx0ZWRfX1SLB4z6pMNql C5DsU81yiwMzxGZfmwz7t04oMqGmCX4cwlBEaOlAeZzdVBHCHeBrY0An7a0rP+2YXHC9fpnkT7N gH4ExIaNDT5OZTYmGLoWWeTwxEEhnk8= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-04_03,2026-11-03_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 adultscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610300000 definitions=main-2611040045 On 10/5/2026 9:07 PM, Mukesh Ojha wrote: > On Mon, Oct 05, 2026 at 04:44:45PM +0530, Komal Bajaj wrote: >> The Shikra LPAICP PAS requires three IOMMU entries. However, >> qcom,shikra-pas.yaml inherits the `iommus` schema from >> qcom,pas-common.yaml, which limits property to a single entry. >> >> As a result, the LPAICP-specific `maxItems: 3` constraint conflicts >> with the inherited `maxItems: 1` constraint, and a valid LPAICP node >> fails schema validation. >> >> Remove the pas-common schema reference and specify IOMMU entry limit >> for each Shikra PAS compatible: one entry for CDSP and MPSS, and >> three entries for LPAICP. >> >> Signed-off-by: Komal Bajaj >> --- >> .../devicetree/bindings/remoteproc/qcom,shikra-pas.yaml | 15 +++++++++++++-- >> 1 file changed, 13 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml >> index 34a2f15e9361..4196f61a8ba0 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml >> @@ -32,6 +32,9 @@ properties: >> items: >> - const: xo >> >> + interconnects: >> + maxItems: 1 >> + >> memory-region: >> minItems: 1 >> maxItems: 2 >> @@ -92,10 +95,14 @@ required: >> - compatible >> - reg >> - memory-region >> + - clocks >> + - clock-names >> + - interrupts >> + - interrupt-names >> + - qcom,smem-states >> + - qcom,smem-state-names >> >> allOf: >> - - $ref: /schemas/remoteproc/qcom,pas-common.yaml# > I think the right approach would be to remove iommu from the common binding > and let the corresponding target put the constraints. Agree, that makes more sense. I will move iommu constraints to the corresponding target-specific bindings in next revision. Thanks Komal > >> - >> - if: >> properties: >> compatible: >> @@ -112,6 +119,8 @@ allOf: >> maxItems: 1 >> firmware-name: >> maxItems: 1 >> + iommus: >> + maxItems: 1 >> power-domains: >> items: >> - description: CX power domain >> @@ -134,6 +143,8 @@ allOf: >> minItems: 2 >> firmware-name: >> minItems: 2 >> + iommus: >> + maxItems: 3 >> power-domains: false >> power-domain-names: false >> >> >> -- >> 2.34.1 >>