Peter Nelson wrote: > Dmitry Torokhov wrote: > >> Nitpick: module_param, if module is compiled in, adds a prefix to >> parameter >> >> names, so the parameters will be: >> gamecon.gc >> gamecon.gc_2 >> gamecon.gc_3 >> gamecon.gc_psx_delay >> gamecon.gc_psx_ddr >> >> At least with PSX stuff it would be nice to drop gc_ prefix. >> > Hopefully my last patch submission related to this file, here's an > updated one using module_param_named so the external name is just psx_ > (I'm leaving the internal name as gc_psx_ just for consistency with > the rest of the file). > > Thanks for the feedback, > -Peter Helps if I actually attach the patch. -Peter