From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758728AbcILNOT (ORCPT ); Mon, 12 Sep 2016 09:14:19 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:48039 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757251AbcILNOQ (ORCPT ); Mon, 12 Sep 2016 09:14:16 -0400 Authentication-Results: lists.sourceforge.net; dkim=none (message not signed) header.d=none;lists.sourceforge.net; dmarc=none action=none header.from=fb.com; Subject: Re: [PATCH 5/5] nbd: add multi-connection support To: Christoph Hellwig References: <1473369130-22986-1-git-send-email-jbacik@fb.com> <1473369130-22986-6-git-send-email-jbacik@fb.com> <20160910074340.GA24069@infradead.org> CC: , , , , From: Josef Bacik Message-ID: <40321d4b-a8f6-5dfe-1aca-230b055c0f3a@fb.com> Date: Mon, 12 Sep 2016 09:11:34 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160910074340.GA24069@infradead.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c091:180::1:c616] X-ClientProxiedBy: YQBPR01CA0069.CANPRD01.PROD.OUTLOOK.COM (10.169.139.37) To CY4PR15MB1320.namprd15.prod.outlook.com (10.172.182.8) X-MS-Office365-Filtering-Correlation-Id: 6455c632-c4c8-4311-10e7-08d3db0e5670 X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1320;2:UX+iFD3On+r0gVxBGW+hP7rfZ39vIFKgYZns032e8ChVXELVcZkpkmjcCgRvRZppoR6UkzE5MHaNn28iIp9P/3dWNILgYEiIv9LAli2HjPTwXuJYh/7Ls66nSxJhA4UBh1NpA50HFoYXWRrGZUCOf5lo+Y5H7QT9XXJQXzF5Sb5vK+CMdiYllpBWMDia+drH;3:PkiY1WwALYOXcOQJcQDDfLO8qmchS33o0DeI4K57UFnrZzaOkYm8OKG3dAlyj4X0HWNA4QDeWTlJh0pw9yig3BXbADHm6HJOdopRGP2YYLykMTGx0+Tg8keJrQ/Ab2qf X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1320; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1320;25:XwQnhrZCukl1sfh+BlZ7Zb1ErFlSbG1Uy81pKPgCtzuM7nR06TaTV9VOtzN1H+VqqanFgcWYth9Te5LLIBqskrBVsRvQQJXfgaqcUSDCK0YSy/yfO0QUrm57YD+7YbTAukXk5ZbcpHRAdlg9v7Y6bLzZxJbdDQXgVEnRKKkU6Uhki6l1GPnVvdf1k+9//M6rBvpFtTRiDXXdYrfCjmFY8hB3K9nKeWjeugz68Qm4mjA09j4Ka7ma5LxCTqhuqCiavvyVvcGRfPPvj9nWDrhq2nUf6EaO5kl5/v/Mmu3hNsfWkWetVhLT+c1sAenYOeCv6KCfNiZr3GM1RQflYtKQgBW6PhbwxTYNj7r0U0z3Zc7ru/M9Mr1PfCBCHbZMRnvjpGB4KWjt7QXk2iK9oXibHscQioBpBgZN4ZX+Tkuofl1myLYeKpGw7gDoEYoDrNUPORh+Z66DsY2qoD4pHV4EEkfN/8P7Jm4Xv4e04yLK9BjkM1SmW1d05NPVdJGB2CHoji0Kpj5xpMUUofekan7xvW5GXr+l0+e0vsyJk1+3v0a/wlREemD7viL6h/KBJnvltbPdw1IhNGz6/gqe1QMmBMVXc+ux51aUEfw/hDCAxRrWoIQqhuCs26XIj+C5CGYEAqdbg421koiW0oFstRecyZ9+fVxDChgKbqGLCIMB9qqSFvwQWzLh1o0eZmuIkD/pnJOt+mYwc73TdrQ89hJitw9IpU3aDNNo8CDhZJj5tP0= X-LD-Processed: 8ae927fe-1255-47a7-a2af-5f3a069daaa2,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1320;31:6NteHymn/negmoDRdJAMweYNTWSTdrnoGgXvwL1Y9CMNv5YXK3xEt3tDz/vDvuroIydz+/fO9hP9iP0RolLLiyVhXdlY2fnVMVRbpj4kB7B415n+xtLkg4poBWRlv+kFL+nwVXevUUyJ51gqyx64lCWkmDo2M0hTdkuEuiFKMzvJWyK3ULwAjQgvZ8RwjIA6ztDhBwQy3G7bhUOOS2PPupxv63kvoFH7NWVQ0I5g5Cc=;20:OJPHSkGHQOzIbS0mWVGBtU0YmZo5viIoI/bQR7mdt/dD/h7O8grxNfqQBrBk+R3wlVUG6bfIx8fwurfZOH8ap3CgcIKE+xBxIYm70vf/6MGmuFcAxoJfPuttt1yJlMXeHG/n+fUNXoalMHGN6uA5jzwBfIkRfC9qavUS4im6FX4=;4:ZAUZDpAXvkm3ArkKpx4ZUDTvgJOiY/JJQOOlGbilAsPJ3hKyexefH55Wm3pRXxTcb1uGwZyw84PlYEJ6G2oZlKbISOsbGzU70YR45THlAb8YRrZgsMw+nJRDVv6k4TfxUnPg/3JYUZH4Lovp3neQh9Oh6t+Fz4Qge/XE6jUUvBFR8oUxcQYb4JvxJt1efLN6zriMg8JaMCcob82v3Bg//O2edxS6LV64dMSGCigwo6zuy0ed5Y8NhHMIj10LulztozMVF+PTjZ6z9cCOcvetmRkyWvklpODQq4JDHg5VSOQ1b8XjM9c59nC8oDcYJVkN9pFzPQ6HZl/mgk1To3zEUoAdP4qNE3G6kNVazgCtUPJb5/uGbA9+2Z7icCBMW6pioqUwn5caZDPLYhm/3w4plw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY4PR15MB1320;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1320; X-Forefront-PRVS: 006339698F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6069001)(6009001)(7916002)(24454002)(377454003)(4001350100001)(65806001)(65956001)(2906002)(6116002)(65826007)(33646002)(5660300001)(4001520100001)(7846002)(83506001)(50986999)(77096005)(110136002)(76176999)(54356999)(189998001)(47776003)(92566002)(50466002)(4326007)(36756003)(87386001)(305945005)(230700001)(2950100001)(42186005)(7736002)(23746002)(8676002)(586003)(86362001)(31686004)(64126003)(81166006)(31696002)(5001760100003)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1320;H:localhost.localdomain;FPR:;SPF:None;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1320;23:iR/q6/sQ24n0MNHqQvy9MwT7lA5MleSzfPcV/?= =?Windows-1252?Q?fbfhoxr+ZaKTNuRd8mumt/9wnEi9799nsmuNA9RfZf7zsfYspojc2sEg?= =?Windows-1252?Q?pPWduB4u5zmRt9O/Kbl04rEeDd6ojEcjv+s5r9rzmzahWHfTJnOwwIE6?= =?Windows-1252?Q?FZG55auWbPonbhUct6UArTh4FUQsD/yFrHgDgRfQQXob5xNFrODJVzsP?= =?Windows-1252?Q?FG0Ou1Ia5vAsbY2zkcqLgdS6GBM241LBB/GCVRSw0NK9BgD3Ehv4AmwE?= =?Windows-1252?Q?48nJtqoZUI5Ej32y4Z6grbOjTA06YADlsowlvEidaEdIpQjnrBsYuHWL?= =?Windows-1252?Q?9VWazcQbpWftu4zgW6rKf7Z3zsGv1JMk5Ter2OOSu08Wc4xXsxUrFzCx?= =?Windows-1252?Q?Kh2XQ/bnjcm0J/3vf9ZPtEj2Ev+p/X67xN7wrvIo6CMRRfmLsSB3fnzQ?= =?Windows-1252?Q?hkkUza0ZBOEdFEoVshiuvIxw8DlyMNpARPuPKKvqqHRaszfOZd74Iw9P?= =?Windows-1252?Q?ERLnF78xenOorxTni7XD/8sjGq3vkCERoBkXcz/7MoAupoOPC1lSrlaw?= =?Windows-1252?Q?w69K5qnx4dhW9VCEdyzfKaXKZVxvQ9W62W/CAGmCzUnOEOeWUiqr5xnx?= =?Windows-1252?Q?4yvCa8JJJT0OFCXIDT0731QMGVIrt3HmhvAgjMYUB77LEiVkkICjwXxq?= =?Windows-1252?Q?Az5eY1j2auk0ugAxFqb9VwEDEFscxelZxUIhE2IIkNM4KwKToUIj+CN0?= =?Windows-1252?Q?eFJ8ObU8oXciUnDohaVAo5PW4JVvjU4dmDgThisNTtzm2k9rxDMGE4hV?= =?Windows-1252?Q?h3YIg0vavOkI3s3Xq1DwxRP8MIX3Q7JiDFGhYyc6cHSvhpWrKye+tmfP?= =?Windows-1252?Q?Qr9VuPMlnfRLNwpzNbQj597Pbtg3ggdkpKRJEV0GPyHQsJXvWeaOn0ZN?= =?Windows-1252?Q?ZXBoDUpKeRpRK//lawyhROp6zYz2h+FbZtnyqw75PuW32N4AYTEpVIhk?= =?Windows-1252?Q?QHXLQUDDEt1EhVWv7WyaM3BUfHfV+uXHLT/12ubDQuJr3R5+4h7RVN1l?= =?Windows-1252?Q?R8zy1GN5AvQbS+OLFPIHgT29xtgVAvdyN8UVbSs1D2Q3zslXXS5Yfsjh?= =?Windows-1252?Q?GE6RJfJ+UrOWEPDFDkaD4bRIi7M3oPyDwpF8iucQS0kR6qzOgM/B8MKV?= =?Windows-1252?Q?txAeB3WJCzLvd7Girg7dEQaJOkDrImQcmtFKmp1GUyRRu0O9kaF?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1320;6:/ikGxBGDZ4m042Db6RtmIYnW15PrtBDJ+tW9Xscz4ASXtniyOSohWXLxw0d8FSwBeeF8WcIYprQnmDAoFsB+kb2L3WwDi+ZpnQFBW7t0xxTiBfehnjynr4AQh74dW8RyR5+8cb3EK7mvSNUDS4L+HVAlWtYxTtjNvAPh5gLoaDk3eN+iQ6Hv8M+/P2S4bO2IjJ+2uTPrN+jWRMX9/06bMpM/3oexVQSkUx0SViPmtnkm0+yCzJlq8H+UdoyzPkxBiu6r9u76y30+BC+0ZJURncmaoMUJY6qXndgE5gsh5r8=;5:JhEDwfkc0BjfBwCHENocjjPUSz46US/VVWgBZT+pv5Oso8AJACEpqxtgN3nTDzKSUUZB0XjStVM46cbAjAbRZx/zfV40Pn90oUDrfexvu8AasiX6nE655zPBZaEi5xE0HlOlFN2WGsbtL3YyYKVvzw==;24:D+DCl47GTL4gJkXoRv2f0aygKgSKY4eD2Z4URNvxEN5VjYIUomKZi4vPwWd6dX/Ybf+x8gz1N+januakb1t63E0DOukB8Zz7n2ptCAKaI7k=;7:5wZP3EiHEQZ62LN5/Y/HB/IQkVgb5JJjqQVKPyUPhLy0+3fM8FGpKxgyxKiv+BGKKa395O45TYNAhxls7dXJywiKeshHI7/7czwFN2zJL1Ao5bf1b8zr9DQMzBSQiJGHnhZHHjdvCOn3tWx8tvmwdt1yciCr8dMLwDay5VtNZ1ZEuHXkfYsLj8gg5p4hxLVedlJtJvYk7wmgOAY4RJGHjxbOoyoLz3cxhAUeWeL8ylwKnV4czgpxlrOCjKRnVIAR SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1320;20:U45H0ch1mSgC/0aHUCMccMN2oVwEOoc7NCC/z84hKsWdpSUIQYVUzbSQSpmKjA/fHkpmZKV0p0NtSMPBqtuHyupdN3yWJe4ZGnLBfSKEQtjY45M94IS8vPD0rGXoi5zgAp7MUggPRb/n3i7/6IjSfknObNNagslcNiNuNLB2wBs= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2016 13:11:40.4232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1320 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-12_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/2016 03:43 AM, Christoph Hellwig wrote: > Hi Josef, > > I haven't read the full path as I'm a bit in a hurry, but is there > a good reason to not simply have a socket per-hw_ctx and store it in > the hw_ctx private data instead of using the index in the nbd_cmd > structure? > No good reason, just didn't know I could do that. I'll fix things up to do that instead, thanks, Josef