From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 653F02E8B9B for ; Tue, 24 Mar 2026 23:14:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774394082; cv=none; b=KZ8Xf9Ow3KSBNP761tdvVJLldXzvAXED2hz11JpbuCx8WXwqXgFI6r3pzw5efUp4hSJhpz4+YGUztUb7Xm1bEMxlPT0mhCGuNgVOljrtSOeujFqmn+Cjtz4WfkOKTtiXTQDn+N03C0OBo4ovRrFLQ3SnxUVRHq9jFFoFJARsWyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774394082; c=relaxed/simple; bh=JD5t3mOSgOvDuiV9t9MBEMZdQGMRaUALVU17sMmknG4=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=mVbeOZ98mMT5ptCfHEu48o2cIknqBxg+MzbYupKHlI2rTbREbYnSVMkyPDEt6Q4C3I5Vm6NpP+uQPRHT7YdHIu6DipRyUyUoiEJ/CQ1gOv8AaKGzfP0A+W+yidxx4OWAIlKTzYuM05gPEr/zp3sphbJ04s1qmOBe6CK7AMKLli8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WE3Og9PI; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WE3Og9PI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774394080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gH3nMO/HcX+fXVZ57m9+yOUkqLGmAk7Rvt+CMf8K4og=; b=WE3Og9PIOTjtbXVIhFoB/1cEQMWqvdAxI8KhuSywJk1b1QXGUKWgve5nWEZEbQQADzWre3 SzRp7voq6nqYBhMj5F2ZqIZHsBv7xAlGwd2+Onzx40rEIHsRuT5blPF9SRK+nzRA2xLs6H ENNDX9EScflh++PRbjafwjk9YaRp4fE= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-vQEl5TEyOzuIjEmGETIrfw-1; Tue, 24 Mar 2026 19:14:36 -0400 X-MC-Unique: vQEl5TEyOzuIjEmGETIrfw-1 X-Mimecast-MFC-AGG-ID: vQEl5TEyOzuIjEmGETIrfw_1774394075 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 291C8195608B; Tue, 24 Mar 2026 23:14:35 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.44.33.121]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7A17319560B1; Tue, 24 Mar 2026 23:14:32 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <45F69EE2-389F-4109-A94C-E07A0A4E6228@objecting.org> References: <45F69EE2-389F-4109-A94C-E07A0A4E6228@objecting.org> <20260324203453.810499-1-lk@c--e.de> <20260324203453.810499-4-lk@c--e.de> To: Josh Law Cc: dhowells@redhat.com, "Christian A. Ehrhardt" , linux-kernel@vger.kernel.org, Andrew Morton , Kees Cook , Petr Mladek , David Gow Subject: Re: [PATCH v2 3/3] lib: kunit_iov_iter: Add tests for extract_iter_to_sg Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4040555.1774394071.1@warthog.procyon.org.uk> Date: Tue, 24 Mar 2026 23:14:31 +0000 Message-ID: <4040556.1774394071@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Josh Law wrote: > if (memcmp(data->buffer, data->scratch, bufsize)) { If you do this, please do "memcmp(...) != 0". It's not a boolean function and the sense is effectively inverted. David