From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89FA53328E3 for ; Tue, 24 Mar 2026 23:19:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774394342; cv=none; b=ljjJGRieUBv20aGbCMoOkcOoGspWp36ydOmbVp7DLAjg3MRHu4FeVo0m4oFwTXRkesODcQJovqiHnmK6J4+fBrZ78pLEXi+SOQ7UDkuzCEv1C+c4qmRNOLjj+xxhSnEsT4+LTP3pIUnHQ2etzC5t1asn+vwk2VVs3jYSQ2VyNQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774394342; c=relaxed/simple; bh=iO9ZYc4+0ROVn21oMKrduSRC1O3fQKttXXwAZr7ZuOo=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=KD2AEg7ShfU/5WX+qNgJ/f3h/LKptjvxXVfNkEC09daWlUXHb66DFxntc5+705VKFtRwrbuWYtbJXdzoQLc9vUDGdniWToneuGxDc1bi1X3SDFplTT2IapOIOmNDZGsv2/Ik/XSrHXgE6GTV4tLYvzWRfO7zRJMNHeUVgggjlQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iaqVN1/H; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iaqVN1/H" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774394340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n61FKzRq9wUlf8xkkPLWduHcKMHlELN2cNLKLXCDFlA=; b=iaqVN1/HMW97p6P86vizDGsGDSIy96957JWs9HP/+MoFYH0qJDx4DnO6i3D4KhEqFyv7u8 DdPFwGVdYIjO0UTtRLgHYd1yV1E5b+evs1LeAkI76+orrjw/kHuGEr4rk78lC3aC98KrEx wsJNibSNoBgr9E6xoZdwGg3ITlB/dfA= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-322-p7VSABV0Miu9aThWEKhoqQ-1; Tue, 24 Mar 2026 19:18:55 -0400 X-MC-Unique: p7VSABV0Miu9aThWEKhoqQ-1 X-Mimecast-MFC-AGG-ID: p7VSABV0Miu9aThWEKhoqQ_1774394334 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7A72A195608E; Tue, 24 Mar 2026 23:18:53 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.44.33.121]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3F1741955D71; Tue, 24 Mar 2026 23:18:51 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20260324203453.810499-1-lk@c--e.de> <20260324203453.810499-2-lk@c--e.de> To: Josh Law Cc: dhowells@redhat.com, "Christian A. Ehrhardt" , linux-kernel@vger.kernel.org, Andrew Morton , Kees Cook , Petr Mladek , David Gow Subject: Re: [PATCH v2 1/3] lib: kunit_iov_iter: Improve error detection Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4040639.1774394329.1@warthog.procyon.org.uk> Date: Tue, 24 Mar 2026 23:18:49 +0000 Message-ID: <4040640.1774394329@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Josh Law wrote: > >+ unsigned int i; > > Nit: unsigned long is probably better here Why? > >+ for (i = 0; i < npages / 4; ++i) I would suggest putting the type here: for (int i = 0; ...) sort of thing. David