From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754532AbcBDIYq (ORCPT ); Thu, 4 Feb 2016 03:24:46 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:51938 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753131AbcBDIYp (ORCPT ); Thu, 4 Feb 2016 03:24:45 -0500 From: Arnd Bergmann To: Lubomir Rintel Cc: linux-rpi-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Chen , Olivier Blin , Stephen Warren , popcornmix Subject: Re: [PATCH 2/2] net/smscx5xx: use the device tree for mac address Date: Thu, 04 Feb 2016 09:24 +0100 Message-ID: <40411294.EnLd2i85mo@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1454571364-24708-3-git-send-email-lkundrak@v3.sk> References: <1454571364-24708-1-git-send-email-lkundrak@v3.sk> <1454571364-24708-3-git-send-email-lkundrak@v3.sk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:NKws3rGxfxT9ZrHfh1rsjqq5vHEUoSstHZOX1be0TcaXcvaOrFT 9mXZIIqMxNsLAo/wFdSA3Oh2F9n+ZU+H4/9C3q66b72BZWE135BoikNspoo4izBSbUEhf7G yTPKkJLgetyFAXW2LZ/Z/JAhuBzbzYwz36fQhNHjHKouh5TRTX90rIMYPKIYMPAMxYVNa30 L2LUragiACSuE2h+roxag== X-UI-Out-Filterresults: notjunk:1;V01:K0:/cEAq7w9YUg=:k19Cd8Ld6qGkBh2fjJ/Ky+ pCAId1Qgj7zWvivaMT9n+XEFAc20mlXj/uhc0FWQrtq4p301w1O2UnE6wz4lG3I/cS7ptvhUf vabD7V4pNGEbx0yXOy40CQ9SKfs8/RBHDIX5xxZwI8L4BMERfmgEARFUl2eBVlWeWsE9ydWXm N2LsWMAE4aQkKJOPhAV0rSEMtzWZV4JE6iGO0dNOAgFKvsD/hrGfb8t2cmpBTQqWBHBHAc6p9 4W/x47GuTFY1IenCP9N6yJnSeknaFb97caqcJmqjtaGHNojyYfhZLgk8Y41zf8Z4W8thCm4mp o4ckXYLW3xpmy+8fV36z8ymia0wSkqBn6342qn6Fu97CGoYiOXOv7eyJyhKH2fRQawKbzvk5d xqpn1GJEq2MMDcxQS9jlWxYwmeWCurahjVonhOacRZ51oDgI1MvV4vtrLcUf4lq37RVG6XLRa oLOrhewHI14dXgSuOTWUqZubTLpNQOwAxB4Muo/PJRUKtD/Ikk5FnqvL6MiW6OkVSRvQdM/aR YDalzJ+3fVFzx62T7uizo3GoUShkVi29vlxxr4c1V2nkI48xqbSJVP5td7/+BSr/oLt0azNk/ VmblVDQzF5PmdN9t1dyNGxhFVuLQAcD4duZbpiyv/7/ouXVwBri5peC21AsImEyi7uPFK0HKc SWfvL1PNE4DVZERqiGP9lE6HtNyI/NfLnNNcJ4qWEAJWZzQ9xgEPZ3uSZmQ1eSPzCnGpKaSZA jB2GOdBh3gpJ2om1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 04 February 2016 08:36:04 Lubomir Rintel wrote: > > [lkundrak@v3.sk: updated to use of_get_property() as per suggestion from Arnd, > reworded the message and comments a bit] > > Tested-by: Lubomir Rintel > Signed-off-by: Arnd Bergmann > --- > Looks good to me now. We could debate which MAC address should be used when both EEPROM and DT exist. The current version prefers the EEPROM address, and I think some other drivers do the opposite, but I don't really know which is best. Arnd