From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C68F33BC68E for ; Fri, 22 May 2026 11:15:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779448554; cv=none; b=fyhWRZM1B7Wn4IEQAIi8Z3S6qNJ/DqgnzGN2IKa24rgOXkqnXpnW+WhTxvbSQOyw6vahTWMrAa2U9B5QQYuMjXh9CF5spy/ZXPQZQTkVsMhFkCkUQylnPq7MFonZSB3TsdlrYUDfQydrU9oanwfcL6KDvPt/FMVb4GyGvx+Y9FE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779448554; c=relaxed/simple; bh=jJ2OehmY96vwBL5lAQ6i28QyH/j5cQxIMHe0BJmG520=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G042L7NCE8KE5jWbzZhn8dfcag9c7ZAjGVHDE7QV2yFdtGoa+y27YmWIJVosG4ZdJmIuRfYhSv3ie+6RAmvU1zFZ7qyu6dPQZ/I5y9lXFlbVgL9ws1kOhFWel21EmPvtenKQJ7LJqZRqrl8B4V79pTFSz+pHw57PHjsT8Mb40uk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LKW2bwIt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cFov2Xfn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LKW2bwIt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cFov2Xfn" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64MBDOZA777027 for ; Fri, 22 May 2026 11:15:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TNFqR3PagcCZH+qIwcxLNM7C+7IFAWYrIDD2ovzZPwU=; b=LKW2bwIteh/HEN5x mdRT0JBb6oItRpscKiIKRJLZEdtsNyBgh8BcbVeE1y4XxZxomTUhp1GLhX0oAKtv m0M2wzaQPpGDYLRJKmlpNM/Pu738A3D9rCQCxFMB2PFj4DJUnDXieavmfw7O7xCW UbNDz31Eca7XEeuw59kHYlAFhVtLMUKDsvHO8w7Zm1/QvMex8tKOimMbWAe67fWR vWTuarZ40MH8kjRqcN2K1mNkR1o732mOossmi6kyZudXyrd3zXdmgNnDsvR5LCJG IC1U2dxo9n2a+kx/QBMNUFHXL4be2ddxbDe2dpTtY+LPigbgrT33bVmEED5MPp3i NaxtSA== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ea94h37fs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 11:15:51 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-57747d72979so666770e0c.3 for ; Fri, 22 May 2026 04:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779448551; x=1780053351; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TNFqR3PagcCZH+qIwcxLNM7C+7IFAWYrIDD2ovzZPwU=; b=cFov2XfnxGTJoroDrRTLH0JyDnZIYJsTIlyhnnHUnUKYyBvdp+RugqkzxFH0JrmS6Y hi82KOmPKfhFkP86hRvMlgCUlWAhMDSFs9U3WUF/+LHrwRk46j+JEo2MnpjdisbH95tV NEoZ0A66o2XSDTTnQzrGn+Pf9+tB34IOTpPhY8pyYD8Ei5rjbKYAmRpOgALsnZtwS8Vy c+aom9Cn0enHcd6OIlEpBdrK7xQMNBtMGK5fLGbZK0muADXLcylrq/wFElOU4oUPiZDl 53IG7VSYFXbXw3Lmase8/l4Jw7AoPFqD0mFh5659z0eCDDfnuELUKPlQxKEgEm0CMhfY LaXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779448551; x=1780053351; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TNFqR3PagcCZH+qIwcxLNM7C+7IFAWYrIDD2ovzZPwU=; b=QSwjAuOUg7eLl8jDwQHHx8m+A7RLP6DjEMcXcPzpmE8e93q/072vU3EOjrF4V8uqdO gi8+cKegm8rZkN05JzM50SU640LuI4hRobTgqmhbrm3tLCRWC5kRvW8hYF6xz/wSgrCL 50+dRlpu2kYnOeRX7U9VClaAADN9jCsrtfmC8wHIr3K97EWlTOv98Hc9UGioszQX8H9B K8A2wE/2b76jv2lxl2OkMqawwAOMasIpoT4TCwdbuZ8lzObJ52DxQ+b85WO6r3ksoO5y d6cazKZiys3M7GcXw2LIXvY4qWbjXuTSlKX7krL2j86AZbKQdUHWOVS2PLJ3UHvH+Qak IOgg== X-Forwarded-Encrypted: i=1; AFNElJ+yFHWobUKaeelpBtJmBaFgQVHeebaB3KjHv9HKWUorz4ByJI3l4Z4FFL/zanIZYjE24KmomYKOL0UqcaM=@vger.kernel.org X-Gm-Message-State: AOJu0YzhCemzloxpcMaYqj2r0dyvuulDWVILfXvcgAGzRvDd/RmucATL uekZoPgALIZ07yckfpkf+hXfxtnx58aK43PgomESNTvgxel1GsVnVEVW1V7QCRgn54M/GLBfFZl 1mBABJJ8bRb+CPbUvRxz1MHoKzi6Y4UvS41bqZtOIcx8/TGJZo4fAV6ScLm0N0xKqJvc4gF4JdB 4= X-Gm-Gg: Acq92OFkVHEjqPcrh/1JN5fSqf5YjezeAhEUnRmMLLRwkN7JdD8Qt8CykSmHhbcBfVs E7YfqB+adPmFKcss7nFX4zOv2b0YczcSpQUut7dH8wxkcUFXyqxQ4hfxGHie1HTNd5F/F499zrR a5btf5I0DA+0P7VQ8AFYPvF9ntH6MW1U6cgfzkFKP6PnNCIX6mx+uhy6k4VoVFMYYRZuoPymsWo BTBZlHOM90QICSabjM/vAoJzSuO9LeNjhr2SJwDVbJU/fzy5Mf14ZGyRX038FkWzyVBVVIFL0cH MNmmWJogXiQTBRNpCUc7hx9nYhimGWDPvFVDM0fMTWW8dm68v9+f52zWNaKYp/lBQT/an2WiX2l 6x9PDW4vbqFUWz4ibM01W/N4x9Nxq/83M1cp/dn3spngjsA== X-Received: by 2002:a05:6122:6846:10b0:575:2300:9f54 with SMTP id 71dfb90a1353d-5865e98ed7dmr513925e0c.1.1779448550913; Fri, 22 May 2026 04:15:50 -0700 (PDT) X-Received: by 2002:a05:6122:6846:10b0:575:2300:9f54 with SMTP id 71dfb90a1353d-5865e98ed7dmr513915e0c.1.1779448550495; Fri, 22 May 2026 04:15:50 -0700 (PDT) Received: from [192.168.119.254] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-688b9f503e1sm582668a12.7.2026.05.22.04.15.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 04:15:48 -0700 (PDT) Message-ID: <40413c01-117a-4333-a8de-f4cc9934dd50@oss.qualcomm.com> Date: Fri, 22 May 2026 13:15:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM To: Ajay Kumar Nandam , Bjorn Andersson , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260513140009.3841770-1-ajay.nandam@oss.qualcomm.com> <20260513140009.3841770-3-ajay.nandam@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260513140009.3841770-3-ajay.nandam@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: szE6WUo38ul1ua7Ni8bbNNyeuBPINMcN X-Authority-Analysis: v=2.4 cv=QblWeMbv c=1 sm=1 tr=0 ts=6a103ae7 cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=sKMSgL6xGKzgxZtRr_wA:9 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 X-Proofpoint-ORIG-GUID: szE6WUo38ul1ua7Ni8bbNNyeuBPINMcN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDExMiBTYWx0ZWRfX98vQxLcB3+lX qJSM5P1LMEmHtXOgxw0LISPom117/NL09+s1jICZNHTxiEfV+DXSaz55NK952Ui9IXqikiZz+LC tpEvxjU2kgJkHsx4jvaxhrTx2G1yoslnIqnhsaWtHhUBo4kfuAtsXpByDjn8/DJwfpUNAp7Y9LO HVZfJUpxHKXUbxcNQSMN7GD/LxDGuvvIPv76QXrYwz7D6+Szi8bX9nU6cogVtwZpQ0qiIeRTOls 7PbdmgrQZ+pFuXyt+Vv747Ucq2FTfkajd6XxkQGm9edEX2KVzzQqqYs+53Pq5lZPzFVeqDWnvYP Z+ZKyABzX2vfjElACcJPeNwzHoxvP63IXjAqHEQjC3umLF+w3we0pVch2q+WmFrysBEE1d/+LQ9 XCub+N1WiXeNrnbYWPKOwOMf0d9JDSD8TeGY/adSWNJ7nFMY7sdGlcMnfNUAIfBMcDjcZR9DQAd 4nV+mE042gOAq+/6oqQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220112 On 5/13/26 4:00 PM, Ajay Kumar Nandam wrote: > Convert the LPASS LPI pinctrl driver to use the PM clock framework for > runtime power management. > > This allows the LPASS LPI pinctrl driver to drop clock votes when idle, > improves power efficiency on platforms using LPASS LPI island mode, and > aligns the driver with common runtime PM patterns used across Qualcomm > LPASS subsystems. > > Guard GPIO register read/write helpers and slew-rate register programming > with synchronous runtime PM calls so the device is active during MMIO > operations whenever autosuspend is enabled. > > Signed-off-by: Ajay Kumar Nandam > --- Looks good now, couple of style nits since I asked for another revision: [...] > @@ -107,8 +118,8 @@ static int lpi_gpio_set_mux(struct pinctrl_dev *pctldev, unsigned int function, > { > struct lpi_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev); > const struct lpi_pingroup *g = &pctrl->data->groups[group]; > - u32 val; > - int i, pin = g->pin; > + u32 val, io_val; > + int i, pin = g->pin, ret; reverse-Christmas-tree ordering would be neat [...] > u32p_replace_bits(&val, i, LPI_GPIO_FUNCTION_MASK); > - lpi_gpio_write(pctrl, pin, LPI_GPIO_CFG_REG, val); > - mutex_unlock(&pctrl->lock); > - > - return 0; > + return lpi_gpio_write(pctrl, pin, LPI_GPIO_CFG_REG, val); A \n before return statements is customary > } > > static const struct pinmux_ops lpi_gpio_pinmux_ops = { > @@ -162,11 +178,15 @@ static int lpi_config_get(struct pinctrl_dev *pctldev, > unsigned int param = pinconf_to_config_param(*config); > struct lpi_pinctrl *state = dev_get_drvdata(pctldev->dev); > unsigned int arg = 0; > + int ret; > int is_out; > int pull; > u32 ctl_reg; ditto [...] > @@ -206,7 +226,7 @@ static int lpi_config_set_slew_rate(struct lpi_pinctrl *pctrl, > { > unsigned long sval; > void __iomem *reg; > - int slew_offset; > + int slew_offset, ret; ditto [...] > diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c > index 750f410311a8..a61df10d46cb 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c > +++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c As noted, please move to patch1 Konrad