From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D36F6285058 for ; Fri, 13 Feb 2026 11:08:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770980931; cv=none; b=QxkgqPeVHFu7ROlo++T/8sAwe2aQohAsKFO5djniI0uvfHulLBrxdq3R4zPA97EFcyLPx+J7s/aauECa328jZbXF3KxvZ6HHNueB0nJYL9oTPhvIt9d0n5Dn7tVtbVtkwOtpxz7yy/VroXBT1s4m+Yx+om7U8zv5eLCXmmGCh8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770980931; c=relaxed/simple; bh=eLUS4wmiJJz4X0K3RltZP6ZhdKNBA6Kc45LhVPfWrbQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M6Pj58FsI/zbZkiyrFDHFO54p2rSJXUQ0q2nw6PddAl1QsoL+DZb+R9Q7uNNffY41Gmo56oZqS9Ifg/7cqIULvVn61Tqgmp17rANKjaiT3LnBUMvM7eJtne7z1zQiQuB2ndGUi/V4lZzCwJqjqBEaOf0SLVx6rdLO2V1+dH49kU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=G53nQuBR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QIK0SceH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="G53nQuBR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QIK0SceH" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61D545Rs1827706 for ; Fri, 13 Feb 2026 11:08:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TjVCXvYuaym7jzzUznbrAb041QaziKAD/Kf70Jd3rm8=; b=G53nQuBRO+PzidlT HZWE8klgYzu9Nz5eCDKILQGFXKL8BrfT8B2bGk5syqr8S0oetDpgxR9b18Wrw/4E cmGsesO8QyS/DhVTd9nexsYyXZ1rmpSYNndlN/XyigY2Zk8mrGBzNY9HFG6aVrvU VDdyURh1/r6lGx0DlZwb4ziXO852De4u0frRwnBS+rgF6H6bDWKO/jsfojOmfbAd gGbqIrQ66poD9owuqbeJ7DAMVXTUjfhSzqDjQAUA1+evavPPg+Scyg1hrSzD4zqs yTPQbAdIAylUnlXvSWH/PwMN2TX2Y2sh5kzPvdzHjBj2jAv7DbaOMmLR0WA5gONF zfVZ8g== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c9wg018qb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Feb 2026 11:08:50 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c709a3a56dso32939285a.2 for ; Fri, 13 Feb 2026 03:08:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770980929; x=1771585729; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TjVCXvYuaym7jzzUznbrAb041QaziKAD/Kf70Jd3rm8=; b=QIK0SceHwuVehcNO8UY+6/m0fmTgAhXk0qIFndX9neVa0hh8V5nTDQ9Ls4JtNqLk3j DEi0ybily8F6a12zYUzX8UMgoWmt5+AQKcjiex6QxumD8iYJgBaVtjWbqj+cx7LuLLwd XC7v2b3iJva7zNeZroBIXyQC2HmyhOvJPhRPy0aAo4cnQMqeyqlnyIAhwBHtv43XEb7A a663RtnxJGeu6XO06EGXspR7O5cGz7myF3lXl3ABoHpe0hI/3V2Ing10HEcKGsdcDye1 /Ynxu2ckYRb4hcHWlPK685XBa4rNkVL3HPpq9HyQ5fncwa2YSNGxjYJVK/RtZQ7yeFUX XFhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770980929; x=1771585729; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TjVCXvYuaym7jzzUznbrAb041QaziKAD/Kf70Jd3rm8=; b=OHl2kv7yBZY1+PGYhAuFFkYbmNJZTiVxmn/7fotBt5VRzUj11TNBPiAPffCoAzYkDF SxtqeEZ89dPMHmaxdRYo9oTBa9F0gcXaPufVvXBg4vPjfEBa/qJfammEyuCCFf01sC6A WwLT683D/ZMwYo15bTRoalnxintPpt06zsK0vR4i5wZm2h4SIk2nAGTMfWDJ+iK7aohc JoSXf5io9eT+il5BK++24MC0Jc1+Awwjlbnb22mYmADdE64i7eIYFJSJM5S2YOgtaLwz y0r6uIkKAtNhR/gEBZPMIALolespLAkFAh/xnX6utgGv1IUILcJPNzBRmypoFM5aYJOT iu8g== X-Forwarded-Encrypted: i=1; AJvYcCX8W0CmokbXf1yZkutYEToVs4RhaboIYSU4e4Cx4Y7+X2MdbQkWNT6ddOQhBlDHYz0Y/rDbcdOV4Fxsv6c=@vger.kernel.org X-Gm-Message-State: AOJu0YyldRUfIAvgBZolzr2nQv+1iUFgjER3iacFbdXQnasfo8iW2VWf TynlWi4PRWsJy4/4JnZ4nORsQ0t6ngW/LSTiI1G2CX3NzK74jUhmoArVXj9uE/NS1QrzDnj9PM4 16l0SKFaScfRqRmYIe6uIUOHA0wT7+1C1adhpeGRqYpq5l1bn6562Cjt2db18juYSMeQZSW7uXA E= X-Gm-Gg: AZuq6aJToaacyS5U0++BcwIyA9KijaYBD+Gg+UgQdwsKz8wuWQYa1M4F/UrqbjO4b9F ez6WzGVbwQPxMC95DN2gZPWFgCxqOnxhv48StMrscFNv6/DgTiy3w66iqcAW1PufAs50zRFW4g3 u1WOS7tiNvahQZOPkfJAgIdvTDSn+JNJkt0RclrW0fAgJTF8Dvxj0ZPJuU10HHHmGqOJeETYIfe 6zMRZA3/di+Q+omh7eLMgpMKIFQFRrIAv+Nh0w7yk9UdQRTKExeoA7MNOZYBQeb17lZLYHV2j2G 1zxZbIXTUuUlokfQbbn9mkattAQ42Hsn/ozUMdQtgqMJl3O/nw71hFnHTY8Ysb73YEUEZa+lc7R xkQvB06JUKuFnYelT2KJTTZAVgHkizbCHTDtxm9A20RLyMijbsPpQc9qYWTPhkzJXYJi3SPymcM S/D3M= X-Received: by 2002:a05:620a:4486:b0:8c7:9e6:3a4e with SMTP id af79cd13be357-8cb4074ba86mr186090685a.0.1770980928883; Fri, 13 Feb 2026 03:08:48 -0800 (PST) X-Received: by 2002:a05:620a:4486:b0:8c7:9e6:3a4e with SMTP id af79cd13be357-8cb4074ba86mr186088685a.0.1770980928416; Fri, 13 Feb 2026 03:08:48 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65bace3fc4esm577073a12.0.2026.02.13.03.08.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Feb 2026 03:08:47 -0800 (PST) Message-ID: <404ab3ec-1f24-4558-8c3d-b43de5730a34@oss.qualcomm.com> Date: Fri, 13 Feb 2026 12:08:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] phy: qcom: edp: Correct and clean up eDP/DP combo PHY configuration values To: Yongxing Mou , Vinod Koul , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260205-edp_phy-v1-0-231882bbf3f1@oss.qualcomm.com> <20260205-edp_phy-v1-1-231882bbf3f1@oss.qualcomm.com> <1b78ea12-84ba-467e-b541-1ffd2348f38c@oss.qualcomm.com> <92556aa2-607f-4743-a480-19458836fffa@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <92556aa2-607f-4743-a480-19458836fffa@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEzMDA4NSBTYWx0ZWRfX6LRAH1K4q7Px QJyzPbajYgzqsLOcUKC3oIgKxXhm78ee5vIrivDHPFgnWv992jc/BM2EamybSSUdMc3WqxDM3VE MX/3rfvcEkQ8fLicgnsVvyfzqM17QLNjNUzm5IM0XgzPSKazs7ZSUXdhBc6XXtOdhh8tMdDPiya i4HHHPuaTAq6eMmlVkUQR/hgMGXolrM/fX+y9sbMWrNsHEnrSZKCZzxZwiWHYEBVZ1l/A2zFl95 J/jGqu2biU0cctcj383jufYaj74n9fq/3Vwie2GtpYESuZYV9dTnimndIX87ZwAJrCPbPWxrz8A MCtMNv0kFqCYb1GL4RQ94FHC6G4lBW4bj1ZnGQ4rTJf/grY2cT0VAsk9EQK7kCS4p4MC6bRqC8K D9vCHFqKUrM24aovxzQ+QZu2ntqv6TCK3W4jbS8qe6q8Z0OkPntwxYyNtkjefVV2aZOr6Uo+wUY Zx7NAMTnwOmZp+2fw9g== X-Proofpoint-ORIG-GUID: nmjJFBs7BVOFJhJEq9zFu1XbImwqTyR4 X-Proofpoint-GUID: nmjJFBs7BVOFJhJEq9zFu1XbImwqTyR4 X-Authority-Analysis: v=2.4 cv=bo5BxUai c=1 sm=1 tr=0 ts=698f0642 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EN9MfmX0twoZTdPln7MA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-13_01,2026-02-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 impostorscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602130085 On 2/9/26 10:00 AM, Yongxing Mou wrote: > > > On 2/6/2026 6:47 PM, Konrad Dybcio wrote: >> On 2/5/26 10:20 AM, Yongxing Mou wrote: >>> According to the current HPG settings, most eDP/DP combo PHYs can reuse the >>> same configuration values. >> >> Even across the various process nodes? >> > Emm,Currently, I have only checked the five platforms that already have eDP PHY driver support enabled. The results are the same as stated in the commit message: in DP mode and in eDP low‑vdiff mode, there are four platforms that can reuse the same settings. The HPG I used was the one I found on IPCAT. Regarding HRG, please move to next comment. >>> DP mode： >>>     -sa8775p/sc7280/sc8280xp/x1e80100 >>>     -glymur >>> eDP mode(low vdiff): >>>     -glymur/sa8775p/sc8280xp/x1e80100 >>>     -sc7280 >>> The current driver still keeps multiple versions of these tables and >>> doesn't fully support every combo PHY mode. This patch removes the >>> redundant configs and keeps only the sets we actually use, matching the >>> platforms listed above. >> >> I see that e.g. eDP Low-Vdiff swing setting for RBR is: >> > Hi, do you mean emphasis settings, i don't see 0x11    0x12 in arr[0][1]. >>         hamoa    kodiak >> arr[0][1]    0x11    0x12 >> >> It may be that this changed later during tuning but it's not reflected >> in the docs for kodiak > Emm, if that, where can i get the correct value for tables.. In this patch, I’m indeed quite curious why the values before the modification differ from those in the HPG. I’m not sure about the reason. The HPG I used was taken directly from the current go/ipcat. Could you tell me where I can obtain the final table that should be used? I.. wanted to ask you the same question.. I would assume that there's 3 possibilities: a) the values have changed as they do during platform maturity b) someone used the wrong values from the docs c) someone downstream kernel as reference and that had wrong / older values Konrad