From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C12473815FA for ; Wed, 8 Apr 2026 07:26:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775633197; cv=none; b=ghr3rebIXNrybdfS6OECNqqiDp9KGqIYzeXyMxQZgCMokdrAdVXBE5xC3QQWcA475Fk74LIUU6pHlsSEQM5REWCDAopWBg5ox3jsUZJOfkPOtPPaMYoVcHuFJP4bEzhDs9lJb6d2gTlSQvKFDKo2mlGzjLtEQLjqpQjtSy3d9ko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775633197; c=relaxed/simple; bh=Ybsw/1t2E37KzSsbUyVwYRciOKqxI4UFk66cbCzpYzI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uIX31Gf/oFKKvyfKWUPrE+LijcsqCVtrxEMbZhG7lfIKZlROku0za2KWv2lNItfD1wkovDujoRhRrBIORhKwtAe/BKweh2/pQmkhHpyo6Sdn9EqGnYu9iQSBtV4lu/GA0lUFJ5XLhZytREzpQx7utSqc42zqxhcSwieA6/qSoj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=D5g2CpXR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fV9ig1gJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="D5g2CpXR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fV9ig1gJ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6386k8at2451317 for ; Wed, 8 Apr 2026 07:26:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NHy+iMr3Xqnr1XEITbbqSi8Jils/yDblCvPpvjVgONo=; b=D5g2CpXREiB8xYvp gQYIZLSZAb4UPRwCpFw07wMuDmOY4Y47vWCtOtPVzhoYS0AcFT6MXfCbGec4BNvO lEOfSfzOOvtn0UnrJ/SGp18CRgthWEiZIt/5cv6BBybRtlCObEfh7I9eJA+lR6t/ aBtzO/8RQ9c403MUYNlT1JnfUGniPelMZcMbj5h5ZTLDyQzQxWpq5rkdnqIJDXO/ xdU1bM8N3ny2tcQ7swPECrcLEjv6qvCxBkxNu7D0P+eud+mT3YhrKGN25vjLK2KF P/OToiPeQOIhO4QdyRTm9iWzKyhmAetkoW7zfSb41t+069PJr66EW52b2oFrJAYf P+3gsw== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ddae69hcq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Apr 2026 07:26:34 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82cd9fa609aso3652668b3a.3 for ; Wed, 08 Apr 2026 00:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775633194; x=1776237994; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NHy+iMr3Xqnr1XEITbbqSi8Jils/yDblCvPpvjVgONo=; b=fV9ig1gJwSgcIDpTcT8HDWaF+I3iAevxKGxH1wUu9AKDhowB23mpskPIwnu8/sS8u8 k6GIAaLokD44JGLVqiONERRDHTvprOhybp0El8Tsj5C/MTNSJzis3fiEoJ7Zfvaicpcj kjnI3Q/dakXzBXQQgDprwwKIAmMeBdsSbyrIWIMqRrnqmOkM4b84S3ZiOHe0ry3ONKls 2beroHLayEYX2zlrs3x5mGDjJStrTiHVYFuI4ovvYF2SpXKtrUl5Z7QofyJtgM64RFz2 Du64V/m3S6xER+kJ59laqcBJ/RLOnT0MPPluXSWkCl0KGLu1iNDFqKGZa4x0s+vVJWQt RUEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775633194; x=1776237994; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NHy+iMr3Xqnr1XEITbbqSi8Jils/yDblCvPpvjVgONo=; b=CjNYN/rO4zKWD8T2pxNb11na2FbpbPX2lyOt9L6ujziz1X5oLMkfpI3v9wTzaiIS0e UAJgWwwbysxamiscyIfWXkvvmMNCbRRxFC7j0OLze4DCkpIhWnWAGZdNXpLPptkzElBn mT2v7sLLzk2BRS9uUmOY44OXLEo0t18ckvmLDEr1yLjdR2ExhJHwqwrWHhCUNg6Ympm/ obeLMhfk/CaOUuItWCWV/+8znt7IIjZF7FxAxhY5xhEmTc0Yhi82q74/fke7QXhjO1c3 5mFnndDOsSESJIlXlFLigFqu+bwCHG+mqtFcdwJj5RdSxoxtFsn8+4Spgh91fjF/xzW+ H31Q== X-Forwarded-Encrypted: i=1; AJvYcCUMx63JRhZq5Yh7EMDOyq6dGbMDbngZ/LyB/l8oHDnsZjzKhqVy+uS/6XI+mZboCYP33fqNwMX8lh3iquM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7uP+McHlUzFoYIRMnkfSEg90LT8zdVJ+AyPOe8mHdM5qZV0LH VNzs7CbXq07DEVldZOV9l6Ud9SqbqLI2TinIwXii4aJPEE4Gnav+toaxkt7Kw/jfC/HpGU5xPnS g2CPovCnsZIYry+5qU4pnj1LBdxCRC94lcGyrnwOw2z9TiMEonzWsjuYlVqn0dkSYLWk= X-Gm-Gg: AeBDieuE4HxesNSKlEDO9zoMdNgjToiUZOu3DRm34BCrpGIG5FA1Sfb4fbxA7YQ3K8B s/POo/dxZJx/ZZT7upukErYY8C2ZkfuDluTEclMxJGBLVUxc5M0rI1PMI03RKsfzyMOOmMW5haq LVZHbR8waw14QPw3IQJTW4KoUo8AqiATCEVlX//WX1mkKSPQSGuSoo6beBEKo+HB+C6Z8/fx8Jp Tw+f7CBHkfE2zk7TxePnrXveiy8ZGoqMe72iVsR8Z/S2NS9u60aQvl6Ndyo31y9XyEQ3OQ2Edce fmxlTpiez4PLSOOtTjJIfN8K3/NhDGTObPtnN12vDLrfZbRIv8kAlZCGp55ZsoK4nYtWVr+lwZ5 EywIz+RVR4wvrwZn1uBv8hHijOJbN9ga9WczX8fM44ZC02T/otQ== X-Received: by 2002:a05:6a00:ad08:b0:82c:77cd:50e1 with SMTP id d2e1a72fcca58-82d0da993b4mr19225544b3a.20.1775633193561; Wed, 08 Apr 2026 00:26:33 -0700 (PDT) X-Received: by 2002:a05:6a00:ad08:b0:82c:77cd:50e1 with SMTP id d2e1a72fcca58-82d0da993b4mr19225502b3a.20.1775633193088; Wed, 08 Apr 2026 00:26:33 -0700 (PDT) Received: from [10.217.217.198] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9c68273sm24431255b3a.41.2026.04.08.00.26.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 00:26:32 -0700 (PDT) Message-ID: <404ca234-1bab-4094-b7dc-c4d0b072d929@oss.qualcomm.com> Date: Wed, 8 Apr 2026 12:56:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] clk: qcom: gdsc: Add custom disable callback for GX GDSC To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Abel Vesa , Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20260407-gfx-clk-fixes-v1-0-4bb5583a5054@oss.qualcomm.com> <20260407-gfx-clk-fixes-v1-1-4bb5583a5054@oss.qualcomm.com> <6149513e-2c0f-4f01-a467-b4a213d65609@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: <6149513e-2c0f-4f01-a467-b4a213d65609@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA4MDA2NiBTYWx0ZWRfX/2sZuEGaYGLC /0JKx2Mw1HNXYB3eo04ChDl+b9+hxbLqJ8xVWONvdYSDOHNkr2ci9xHBXqJ3mWUdSWsravFXZTs monx/6Q8xHBscmk5qyRzOlfjNFfFNsy07HVq56kHKV+POZDRwe6nnmBEd230Uk5Ay2lt4GwUiUP FXrWN8u1XiP22By962qrVSIWCHt6kwnkhDe+79+1gKZtTWVO/WCo88+cirnkDrZF0VpxJefbUo6 zzt+Cz4e2IWN9AkK23nv/BlKXWii9DqGdBTQSITGg4no1aEFmPkTfnnKDNS1lWwVwgY92y/upBf FL1osLXci5vIgk0pASe9csfkhp4EQMEFF+b0PfoeUgEulNyX5V5GQGHjupHauG7C6mtx4sB0egM vxHLjLWcsua8TXPkiA+qrzI/8RTJDlUGUaCMS696rAxNiL9bFXaHeSmhDyw0EMkfr40W8TaxAGC RvPDB4GSbVfcymQz76w== X-Proofpoint-GUID: soQ90lMvz1RD37pCmKQ_2ONE8nVKiv3j X-Proofpoint-ORIG-GUID: soQ90lMvz1RD37pCmKQ_2ONE8nVKiv3j X-Authority-Analysis: v=2.4 cv=K4AS2SWI c=1 sm=1 tr=0 ts=69d6032a cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=RnFGxym7J1TeeuKG4B0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-08_03,2026-04-07_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080066 On 4/7/2026 4:26 PM, Konrad Dybcio wrote: >> @@ -675,3 +675,25 @@ int gdsc_gx_do_nothing_enable(struct generic_pm_domain *domain) >> return ret; >> } >> EXPORT_SYMBOL_GPL(gdsc_gx_do_nothing_enable); >> + >> +/* >> + * GX GDSC is a special power domain. Normally, its disable sequence >> + * is managed by the GMU firmware, and high level OS must not attempt > nit: "and high level OS must not attempt" -> "and the OS must not attempt" > Sure, will update in the next patch. > >> + * to disable it. The only exception is during GMU recovery, where the >> + * GMU driver can set GenPD’s synced_poweroff flag to allow explicitly >> + * disable GX GDSC in hardware. >> + */ >> +int gdsc_gx_disable(struct generic_pm_domain *domain) >> +{ >> + struct gdsc *sc = domain_to_gdsc(domain); >> + >> + if (domain->synced_poweroff) >> + return gdsc_disable(domain); > Can we use this version to replace gdsc_gx_do_nothing_enable() too? No, Konrad, the enable should be always a no-op in every scenario. synced_poweroff can't be used to handle enable of GDSC. -- Thanks, Taniya Das