From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] locking/mutex: Mark devm_mutex_init() as __must_check
Date: Thu, 16 Jan 2025 18:31:32 +0100 [thread overview]
Message-ID: <404d182e-ba2a-480c-bcbd-4497350fc561@t-8ch.de> (raw)
In-Reply-To: <Z4kpmgorWB2wSKgz@smile.fi.intel.com>
On 2025-01-16 17:45:30+0200, Andy Shevchenko wrote:
> On Mon, Dec 02, 2024 at 06:45:41PM +0100, Thomas Weißschuh wrote:
> > Even if it's not critical, the avoidance of checking the error code
> > from devm_mutex_init() call today diminishes the point of using devm
> > variant of it. Tomorrow it may even leak something. Enforce all callers
> > checking the return value through the compiler.
> >
> > As devm_mutex_init() itself is a macro which can not be annotated,
> > annotate __devm_mutex_init() instead.
> > Unfortunately __must_check/warn_unused_result don't propagate through
> > statement expression. To work around this move the statement expression
> > into the argument list of the call to __devm_mutex_init() so
> > devm_mutex_init() directly expands to __devm_mutex_init().
>
> Did it go anywhere?
Nope. I'll resend it after -rc1.
Maybe a Reviewed-by also helps.
prev parent reply other threads:[~2025-01-16 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 17:45 Thomas Weißschuh
2025-01-16 15:45 ` Andy Shevchenko
2025-01-16 17:31 ` Thomas Weißschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=404d182e-ba2a-480c-bcbd-4497350fc561@t-8ch.de \
--to=linux@weissschuh.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®