From: "Dmitriy Zavin" <dmitriyz@google.com>
To: "Andi Kleen" <ak@suse.de>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH 1/4] x86_64/i386 thermal mce: Refactor thermal throttle reporting.
Date: Wed, 20 Sep 2006 13:54:57 -0700 [thread overview]
Message-ID: <404ea8000609201354p7313f35as7bbe63cc09a5fc3f@mail.google.com> (raw)
In-Reply-To: <200609200938.51215.ak@suse.de>
Ok, will move the mce_log part into mce.c in x86_64 and go back to
returning 0/1 from therm_throt_process. Then only the x86_64 thermal
mce will mcelog, and no #ifdefs :)
On 9/20/06, Andi Kleen <ak@suse.de> wrote:
>
> > +
> > +#include <linux/percpu.h>
> > +#include <linux/cpu.h>
> > +#include <asm/cpu.h>
> > +#include <linux/notifier.h>
> > +#include <asm/therm_throt.h>
> > +
> > +#ifdef CONFIG_X86_64
>
>
> Sorry, no such ifdefs allowed. That is what I meant with making the merged code
> worse than split code.
>
> -Andi
>
next prev parent reply other threads:[~2006-09-20 20:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 2:42 therm_throt: Refactor and improve thermal throttle processing Dmitriy Zavin
2006-09-20 2:42 ` [PATCH 1/4] x86_64/i386 thermal mce: Refactor thermal throttle reporting Dmitriy Zavin
2006-09-20 2:42 ` [PATCH 2/4] jiffies: Add 64bit jiffies compares (needed when long < 64bit) Dmitriy Zavin
2006-09-20 2:42 ` [PATCH 3/4] therm_throt: Make the jiffies compares use the 64bit safe macros Dmitriy Zavin
2006-09-20 2:42 ` [PATCH 4/4] therm_throt: Add a cumulative event counter and export it to /sys Dmitriy Zavin
2006-09-20 7:42 ` Andi Kleen
2006-09-20 7:43 ` [PATCH 3/4] therm_throt: Make the jiffies compares use the 64bit safe macros Andi Kleen
2006-09-20 7:40 ` [PATCH 2/4] jiffies: Add 64bit jiffies compares (needed when long < 64bit) Andi Kleen
2006-09-20 23:08 ` Dmitriy Zavin
2006-09-20 7:38 ` [PATCH 1/4] x86_64/i386 thermal mce: Refactor thermal throttle reporting Andi Kleen
2006-09-20 20:54 ` Dmitriy Zavin [this message]
2006-09-20 7:43 ` therm_throt: Refactor and improve thermal throttle processing Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=404ea8000609201354p7313f35as7bbe63cc09a5fc3f@mail.google.com \
--to=dmitriyz@google.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®