From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38013C001DE for ; Thu, 3 Aug 2023 01:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232948AbjHCBij (ORCPT ); Wed, 2 Aug 2023 21:38:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232505AbjHCBiP (ORCPT ); Wed, 2 Aug 2023 21:38:15 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92F6F26AB; Wed, 2 Aug 2023 18:38:13 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RGWc530qVzNmPj; Thu, 3 Aug 2023 09:34:45 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 09:38:11 +0800 Subject: Re: [PATCH] cgroup: minor cleanup for cgroup_local_stat_show() To: Tejun Heo CC: , , , References: <20230723031932.3152951-1-linmiaohe@huawei.com> <719a19c4-3be5-2260-7349-b3f1bb774f4f@huawei.com> <3ec1f5d9-4887-4583-a973-92298a9bc924@huawei.com> From: Miaohe Lin Message-ID: <404ee96a-bde3-1fa4-7985-9edbf41b248a@huawei.com> Date: Thu, 3 Aug 2023 09:38:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/8/3 3:39, Tejun Heo wrote: > On Tue, Aug 01, 2023 at 03:48:09PM +0800, Miaohe Lin wrote: >> On 2023/8/1 7:47, Tejun Heo wrote: >>> On Thu, Jul 27, 2023 at 07:50:11PM +0800, Miaohe Lin wrote: >>>> On 2023/7/26 9:06, Miaohe Lin wrote: >>>>> On 2023/7/26 5:53, Tejun Heo wrote: >>>>>> On Sun, Jul 23, 2023 at 11:19:32AM +0800, Miaohe Lin wrote: >>>>>>> Make it under CONFIG_CGROUP_SCHED to rid of __maybe_unused annotation. >>>>>>> Also put cgroup_tryget_css() inside CONFIG_CGROUP_SCHED as it's only >>>>>>> called when CONFIG_CGROUP_SCHED. No functional change intended. >>>>>>> >>>>>>> Signed-off-by: Miaohe Lin >>>>>> >>>>>> Patch doesn't apply to cgroup/for-6.6. Can you please respin? >>>>> >>>>> Sure. Will resend the patch based on cgroup/for-6.6. >>>> >>>> The commit "sched: add throttled time stat for throttled children" is still in the linux-next tree. So I think I have >>>> to wait for it to be merged into cgroup tree first. >>> >>> You can just send the patch against cgroup/for-6.6 branch. We can sort out >>> the merge conflicts later. >> >> Do you mean send the patch against cgroup/for-6.6 branch assuming commit "sched: add throttled time stat for throttled children" >> has been merged into cgroup/for-6.6 branch? It seems the current code in that branch is fine itself. > > Ah, I see. That patch isn't going to go through cgroup/for-6.6. It will go > directly from -mm to mainline when the merge window opens. Can you please > resend the patch to Andrew Morton with me cc'd? > Will do. Thanks. :)