From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D86C67863 for ; Wed, 24 Oct 2018 08:51:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8894D2082E for ; Wed, 24 Oct 2018 08:51:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8894D2082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727617AbeJXRSx (ORCPT ); Wed, 24 Oct 2018 13:18:53 -0400 Received: from mail-sh2.amlogic.com ([58.32.228.45]:22426 "EHLO mail-sh2.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727333AbeJXRSx (ORCPT ); Wed, 24 Oct 2018 13:18:53 -0400 Received: from [10.18.29.185] (10.18.29.185) by mail-sh2.amlogic.com (10.18.11.6) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Wed, 24 Oct 2018 16:51:28 +0800 Subject: Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver To: Stephen Boyd , Jerome Brunet , Neil Armstrong CC: Yixun Lan , Kevin Hilman , Carlo Caione , Michael Turquette , Rob Herring , Miquel Raynal , Boris Brezillon , Martin Blumenstingl , Liang Yang , Jian Hu , Qiufang Dai , Hanjie Lin , Victor Wan , , , , References: <1539839245-13793-1-git-send-email-jianxin.pan@amlogic.com> <1539839245-13793-4-git-send-email-jianxin.pan@amlogic.com> <153988282130.5275.17528969137837015544@swboyd.mtv.corp.google.com> <154037087711.53599.12246779227164118041@swboyd.mtv.corp.google.com> From: Jianxin Pan Message-ID: <40509901-a793-971d-eb2e-40230b67f490@amlogic.com> Date: Wed, 24 Oct 2018 16:51:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <154037087711.53599.12246779227164118041@swboyd.mtv.corp.google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.18.29.185] X-ClientProxiedBy: mail-sh2.amlogic.com (10.18.11.6) To mail-sh2.amlogic.com (10.18.11.6) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/10/24 16:47, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-23 23:29:24) >> On 2018/10/19 1:13, Stephen Boyd wrote: >>> Quoting Jianxin Pan (2018-10-17 22:07:25) >> [...] >>>> diff --git a/drivers/clk/meson/mmc-clkc.c b/drivers/clk/meson/mmc-clkc.c >>>> new file mode 100644 >>>> index 0000000..5555e3f >>>> --- /dev/null >>>> +++ b/drivers/clk/meson/mmc-clkc.c >>>> @@ -0,0 +1,296 @@ >>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >>>> +/* >>>> + * Amlogic Meson MMC Sub Clock Controller Driver >>>> + * >>>> + * Copyright (c) 2017 Baylibre SAS. >>>> + * Author: Jerome Brunet >>>> + * >>>> + * Copyright (c) 2018 Amlogic, inc. >>>> + * Author: Yixun Lan >>>> + */ >>>> + >>>> +#include >>> >>> clk-provider.h instead of clk.h?> >> Maybe we need to keep clk.h >> devm_clk_get() is called in mmc_clkc_register_mux() to get parent in from DTS. >> I'm sorry to miss this in previous reply. > > OK. But also include clk-provider.h if provider APIs are being used > here. OK. I will add it. Thank you. > > . >