From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30B462F3C32 for ; Fri, 10 Oct 2025 14:10:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760105405; cv=none; b=UVBw2ueLAtO66O5ghWRpviA/5rx7zTiJCHH/F6Q7MUBXt9jI/K7MRcZyLRAljncFXITVInlpz8hg5yoA440Ckm9JampXmtYYVImajKFoPnJ6RWtW6n2lWTCN/7wOVlaYNWGnqf/60+mGX/pOOhx0xYKaO8RkzdAz+lBDHs5VPnI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760105405; c=relaxed/simple; bh=foIQle7lWfC9ERVULKynw7SghJRqe7SMGsHmoTHKmNs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Zf6/ibr1X/ZmO0WarBpSjMimBvNacMaD0fr5J326X/ZgZ/1ZpWD42qPTOVo8xFmWiocWN2U8W8ogo7NHNZChC/Tbw4gRBE5Cx9MmmqYmKJiVUVMdXAiaMSGArCgaMd5OH1GNFRTd4UiZOEp8ecMPEv+XWKANJlP1p14VMmMN9EA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SYsAKEsq; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SYsAKEsq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760105403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8C022sktUjail169ppgWBfdPS1kZoI3Bm8Yo7CANI3s=; b=SYsAKEsqOeVKxxucDbksq1C3HnpYkidxYDfuesXkNRnjhelHmf6Bd4zfWG3X0IoxrOBkP5 oSZpLQr88JgpzHT/QzyncGpNLHqYUWZd9ZZBcgfiBMVPSaBjl5Fv1R5zeIoavXiHPbq2l3 vOT1ZsToq9SPYeuPOCXewFP7ELMv0bw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-282-Jm2ieAS5ORWdjVIeGzGz_Q-1; Fri, 10 Oct 2025 10:10:01 -0400 X-MC-Unique: Jm2ieAS5ORWdjVIeGzGz_Q-1 X-Mimecast-MFC-AGG-ID: Jm2ieAS5ORWdjVIeGzGz_Q_1760105401 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3f4fbdf144dso1286207f8f.2 for ; Fri, 10 Oct 2025 07:10:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760105400; x=1760710200; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8C022sktUjail169ppgWBfdPS1kZoI3Bm8Yo7CANI3s=; b=R8Yh+MA0hleME4sa6BqRWxNKDADTxmzUwN+VDg0jqgSOP486jVXnh/FzvCSMVnr7XR f0PEoBG3RQtiDtCTF/kBztz0vzl4xlmpe8A7u1L8PNcLuA8TEdoI6zwZFWNlUOep/gHm V6HIfdZxINTgUFhrfmnfIQXzHZGuoC9smBw7AkykbrAMVKcy9VbRMGqMWUHyWhQNi3+1 MU/4zn12HV+HQgA5CNHUlEjDBBKkF33QMJaKgPFNbD+/o9HYH+58BuEw1seVyOm4eZwl Au6uHQj0LYzbWuvInFiCjWZvv65djgAoRuwPg1yetAfgFEY3XdDyI4vNqL6KFymerPkX fP9w== X-Forwarded-Encrypted: i=1; AJvYcCV3GEThp4wXcL6mHZQ0YzWda2MJe4hQ7U4Wl4hIGXaXppcJmvAP7h2bjmUGuBk6tTfGbOKz8Zkhy5pN6m8=@vger.kernel.org X-Gm-Message-State: AOJu0YxHEQlrrmd38bU5K4ef1fZOFe2AJAxDRDYBcLl6N4WjkGS4XOa2 siYhb2l/Vxo3sy1txrSWrAsSIY5K2NH2vq/POZZaV6Cqod5/mrowJ+TElB8LSpPAnNy9oiO9J70 KC27IWegfNs8zGqlgRw4VPfBD+y2+n2QcuZRRkkuXOjR6tfqRfdVA9P/vb2PRW+Jrcg== X-Gm-Gg: ASbGncsr+boCPU7tysz3M9Mnzj1YkugQ+8PVK5EtIjwfzAZ7KPS+1JqtCUmMEUY5RNf HIWEVa3Mz5DFrZPW4/XSwHzYP/BcvYq0bE1fbQztRbz9bdMb8ydvZIeOPNWUoN0WdrnTSe8+izb 7avB+lcFCTYburY5Gmvr/9jtag9oE0VeqLNpdBWErQhJ7dHPOibTJuSK4EwBcoVkzLHf6cH0ST0 ZquFsK7j3cLE+CfPKuJhUD6prQbZWQ7Wo9MSIt26gWJu6na3ydAg1bUiCPI6daVF7b8x8Viyaru n616K+7/VMzBY140bm1tyPGYr4TZ2U7Gr39DMOUY0XNUjYzLqcHwUE/rCNuJIKWppi1kWvi99dj ymDU= X-Received: by 2002:a05:6000:178f:b0:405:8ef9:ee6e with SMTP id ffacd0b85a97d-4266e7bf1d7mr8416040f8f.25.1760105400467; Fri, 10 Oct 2025 07:10:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYaLfXQuHZXqKHMYG4PXPjxgH/q4seV5B8Aq9aeHv+g4RGTpe5MoSUFEIVwzPHH4p7WTVBEw== X-Received: by 2002:a05:6000:178f:b0:405:8ef9:ee6e with SMTP id ffacd0b85a97d-4266e7bf1d7mr8416017f8f.25.1760105400062; Fri, 10 Oct 2025 07:10:00 -0700 (PDT) Received: from [192.168.3.141] (tmo-083-189.customers.d1-online.com. [80.187.83.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce5e8309sm4350116f8f.50.2025.10.10.07.09.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Oct 2025 07:09:59 -0700 (PDT) Message-ID: <4053d56d-2732-457f-9531-07382780e39b@redhat.com> Date: Fri, 10 Oct 2025 16:09:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/13] KVM: guest_memfd: Invalidate SHARED GPAs if gmem supports INIT_SHARED To: Sean Christopherson , Paolo Bonzini , Christian Borntraeger , Janosch Frank , Claudio Imbrenda Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Fuad Tabba , Ackerley Tng References: <20251003232606.4070510-1-seanjc@google.com> <20251003232606.4070510-4-seanjc@google.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20251003232606.4070510-4-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04.10.25 01:25, Sean Christopherson wrote: > When invalidating gmem ranges, e.g. in response to PUNCH_HOLE, process all > possible range types (PRIVATE vs. SHARED) for the gmem instance. Since > since guest_memfd doesn't yet support in-place conversions, simply pivot > on INIT_SHARED as a gmem instance can currently only have private or shared > memory, not both. > > Failure to mark shared GPAs for invalidation is benign in the current code > base, as only x86's TDX consumes KVM_FILTER_{PRIVATE,SHARED}, and TDX > doesn't yet support INIT_SHARED with guest_memfd. However, invalidating > only private GPAs is conceptually wrong and a lurking bug, e.g. could > result in missed invalidations if ARM starts filtering invalidations based > on attributes. > > Fixes: 3d3a04fad25a ("KVM: Allow and advertise support for host mmap() on guest_memfd files") > Signed-off-by: Sean Christopherson > --- Reviewed-by: David Hildenbrand -- Cheers David / dhildenb