From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A32C76188 for ; Fri, 19 Jul 2019 10:51:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA22B2173B for ; Fri, 19 Jul 2019 10:51:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727486AbfGSKvL convert rfc822-to-8bit (ORCPT ); Fri, 19 Jul 2019 06:51:11 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:42378 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbfGSKvK (ORCPT ); Fri, 19 Jul 2019 06:51:10 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id AB1B89C01AF; Fri, 19 Jul 2019 06:51:09 -0400 (EDT) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id UITvdYQh0lmp; Fri, 19 Jul 2019 06:51:08 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id CD8AD9C0279; Fri, 19 Jul 2019 06:51:08 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id DuBALd-RrgDk; Fri, 19 Jul 2019 06:51:08 -0400 (EDT) Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [192.168.48.237]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 9CA4D9C01AF; Fri, 19 Jul 2019 06:51:08 -0400 (EDT) Date: Fri, 19 Jul 2019 06:51:08 -0400 (EDT) From: Gilles Doffe To: Marco Felsch Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, mark rutland , festevam@gmail.com, s hauer , robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org Message-ID: <405527661.6507550.1563533468485.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: <20190712135541.55fgchvyp33cl3uv@pengutronix.de> References: <20190712124522.571-1-gilles.doffe@savoirfairelinux.com> <20190712135541.55fgchvyp33cl3uv@pengutronix.de> Subject: Re: [PATCH] arm: dts: imx6qdl: add gpio expander pca9535 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Mailer: Zimbra 8.8.11_GA_3737 (ZimbraWebClient - GC75 (Linux)/8.8.11_GA_3737) Thread-Topic: imx6qdl: add gpio expander pca9535 Thread-Index: vpg0c/hPAh+Ul1ZzEvqvEtVCDcLJKQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Marco, Thanks for your review. Corrected in v2. Regards, Gilles ----- Le 12 Juil 19, à 15:55, Marco Felsch m.felsch@pengutronix.de a écrit : Hi, On 19-07-12 14:45, Gilles DOFFE wrote: > The pca9535 gpio expander is present on the Rex baseboard, but missing > from the dtsi. > > Add the new gpio controller and the associated interrupt line > MX6QDL_PAD_NANDF_CS3__GPIO6_IO16. > > Signed-off-by: Gilles DOFFE > --- > arch/arm/boot/dts/imx6qdl-rex.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-rex.dtsi b/arch/arm/boot/dts/imx6qdl-rex.dtsi > index 97f1659144ea..d5324c6761c1 100644 > --- a/arch/arm/boot/dts/imx6qdl-rex.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-rex.dtsi > @@ -136,6 +136,19 @@ > compatible = "atmel,24c02"; > reg = <0x57>; > }; > + > + gpio8: pca9535@27 { Just a nitpick, I would change that to pca9535: gpio8@27 { Regards, Marco > + compatible = "nxp,pca9535"; > + reg = <0x27>; > + gpio-controller; > + #gpio-cells = <2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pca9535>; > + interrupt-parent = <&gpio6>; > + interrupts = <16 IRQ_TYPE_LEVEL_LOW>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > }; > > &i2c3 { > @@ -237,6 +250,12 @@ > >; > }; > > + pinctrl_pca9535: pca9535 { > + fsl,pins = < > + MX6QDL_PAD_NANDF_CS3__GPIO6_IO16 0x00017059 > + >; > + }; > + > pinctrl_uart1: uart1grp { > fsl,pins = < > MX6QDL_PAD_CSI0_DAT10__UART1_TX_DATA 0x1b0b1 > -- > 2.19.1 > > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |