mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com
Subject: Re: [PATCH] ASoC: soc-core.c: Do not error if a DAI link component is not found
Date: Fri, 25 Aug 2023 00:19:34 +0300	[thread overview]
Message-ID: <405e420d-ba17-4a20-9cec-11e821b73bbf@collabora.com> (raw)
In-Reply-To: <ZOe36EyxNQuz08qt@finisterre.sirena.org.uk>

On 8/24/23 23:04, Mark Brown wrote:
> On Thu, Aug 24, 2023 at 10:38:37PM +0300, Cristian Ciocaltea wrote:
>> A recent cleanup of soc_dai_link_sanity_check() is responsible for
>> generating lots of confusing errors before returning -EPROBE_DEFER:
>>
>>   acp5x_mach acp5x_mach.0: ASoC: Component acp5x_i2s_dma.0 not found for link acp5x-8821-play
>>   [...]
>>   acp5x_mach acp5x_mach.0: ASoC: Component spi-VLV1776:00 not found for link acp5x-CS35L41-Stereo
>>   [...]
>>   acp5x_mach acp5x_mach.0: ASoC: Component spi-VLV1776:01 not found for link acp5x-CS35L41-Stereo
>>
>> Switch back to the initial behaviour of logging those messages on
>> KERN_DEBUG level instead of KERN_ERR.
>>
>> While at it, use the correct form of the verb in 'component_not_find'
>> label.
> 
> Don't include random extra stuff in patches unless there is substantial
> overlap, send one change per patch.

I submitted v2 with the unrelated changes moved to a separate patch:

https://lore.kernel.org/all/20230824211241.388201-1-cristian.ciocaltea@collabora.com/

Thanks,
Cristian

  reply	other threads:[~2023-08-24 21:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24 19:38 Cristian Ciocaltea
2023-08-24 20:04 ` Mark Brown
2023-08-24 21:19   ` Cristian Ciocaltea [this message]
2023-08-24 22:43 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=405e420d-ba17-4a20-9cec-11e821b73bbf@collabora.com \
    --to=cristian.ciocaltea@collabora.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kernel@collabora.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®