From: "Martin J. Bligh" <mbligh@mbligh.org>
To: michael@ellerman.id.au, Linux Kernel list <linux-kernel@vger.kernel.org>
Cc: Nikhil Dharashivkar <nikhildharashivkar@gmail.com>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] remove warning about e1000_suspend
Date: Mon, 08 Aug 2005 07:57:13 -0700 [thread overview]
Message-ID: <406250000.1123513032@[10.10.2.4]> (raw)
In-Reply-To: <200508081849.34831.michael@ellerman.id.au>
--Michael Ellerman <michael@ellerman.id.au> wrote (on Monday, August 08, 2005 18:49:34 +1000):
> On Mon, 8 Aug 2005 16:09, Nikhil Dharashivkar wrote:
>> Hi Martin,
>> But e1000_notify_reboot () function calls this e1000_suspend()
>> function irrespective of CONFIG_FM is defined or not. So according to
>> your soution, what if CONFIG_FM is not defined.
>
> Does it? I can't find it.
>
> Martin's patch works for me.
Aha. e1000_notify_reboot dissappeared between 2.6.13-rc3 and 2.6.13-rc4,
which caused the warning to start. So patch is good - Andrew, could you
still apply it? Will resend if you need.
M.
next prev parent reply other threads:[~2005-08-08 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <256850000.1123442258@10.10.2.4>
2005-08-08 6:09 ` Nikhil Dharashivkar
2005-08-08 6:16 ` Martin J. Bligh
2005-08-08 8:49 ` Michael Ellerman
2005-08-08 14:57 ` Martin J. Bligh [this message]
2005-08-07 19:17 Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='406250000.1123513032@[10.10.2.4]' \
--to=mbligh@mbligh.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ellerman.id.au \
--cc=nikhildharashivkar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®