From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756497AbcE0RkS (ORCPT ); Fri, 27 May 2016 13:40:18 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:55528 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756241AbcE0RkQ (ORCPT ); Fri, 27 May 2016 13:40:16 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Fri, 27 May 2016 10:36:21 -0700 From: Stefan Agner To: Mark Brown , Alexander Stein Cc: linux-kernel@vger.kernel.org, Meng Yi , dri-devel@lists.freedesktop.org, David Airlie , airlied@redhat.com Subject: Re: fsl-dcu not works on latest "drm-next" In-Reply-To: <20160527122010.GH16172@sirena.org.uk> References: <20160525104103.GV8206@sirena.org.uk> <2397536.bIp6BuhYPD@ws-stein> <20160527122010.GH16172@sirena.org.uk> Message-ID: <40626c17a4e8960d20bfa07c59892bfa@agner.ch> User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-05-27 05:20, Mark Brown wrote: > On Thu, May 26, 2016 at 10:54:16PM -0700, Stefan Agner wrote: >> On 2016-05-26 02:11, Alexander Stein wrote: > >> > This needs to be a flat cache. See >> > https://lists.freedesktop.org/archives/dri-devel/2016-January/099121.html >> > or https://lkml.org/lkml/2016/3/24/281 >> > max_register also needs an appropriate value. > >> FWIW, the latest patch which addresses this issue is Patch 5/6 of this >> patchset: >> https://lkml.org/lkml/2016/4/19/617 > >> Unfortunately, that patchset missed the 4.7 merge window. I still miss >> an Ack for the first patch of this patchset. But should go into the next >> release... > > That's another way of addressing it of course, but unless the register > map actually is sparse it's probably still sensible to send the > conversion to flat cache as a fix. The regcache is used for suspend, but the suspend implementation in its current form is not in not working. Hence I felt it is not worth fixing part of something which is broken as a whole anyway. So far I was under the impression the "only" issue using REGCACHE_RBTREE is that it triggers a warning when enabling lockdep. @Alexander, is using REGCACHE_RBTREE an actual problem for the issue Meng Yi has here? -- Stefan