From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24E914F0559 for ; Thu, 15 Oct 2026 09:22:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792056168; cv=none; b=Ig1OlP7FkyztPSdBif4swY4MzSe8MIPz1HoIMul3VOUYtBXXNIHy+u6ZTIJvlSZxyp/bjVI0Ww1/fap5I1ASoYSnZ3IDMc2TIuhE8xGtPuCUTtYK1H1SG6JpQ/i5PRtLodeKBnAi4W+E6qblotrGHHMLKl7+hJ1dakHquswghjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792056168; c=relaxed/simple; bh=hMfKOvmAzlo5fI5dBlL9WCAS+avt+pks4MJuSRxNFeU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qjAwZu5IyW9M7fj88/hBctbgq4p4GlYrgda9DbqRk9/VLVhw3thWWoq1oMOaPtkciSY952AMF+NpFsIkuDk6s4KOMFBAc9It+EiK/IkMg1sluASHoPyoyhYq98pI2c2s3Bi5aSmvEDJ0BFGJc4VJ6Ug7PEU0e9RecnodyLA4I/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Hw69Rp+O; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HXGumam5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Hw69Rp+O"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HXGumam5" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69F7qtuY1707237 for ; Thu, 15 Oct 2026 09:22:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YIcabBqKQNdc2sscABVfZLyCZqhIe0PxX/KTiOQKlRE=; b=Hw69Rp+OZti0pWo4 dAnFhXof4mifnLJz5qFIrgrN0bySW9NiMCthFE/NI/OTvSxmatjP0I8VXddUFaPZ 9ug/vTHXge8hL++FL66FylhdNj+Y+keelsgmaXESGGxgQrSDUyXUOBSQTW3IPxgv bdnStMhLr1AMzbL2NxjiEbdnl1V3/Z8+csG57MZd2kh2ahrj6eUrmll8D6eW3Olb kfU1LhCp/Pis5vVQN68G3yKjPIkwUvrZ6WYPrHH2CPxBl9xodYxqAakhUlkm2rwT 8iRxzJ088aHS4xYVAHDDlChixzmeHvcbQX4kV48HqWvMj6CNIiReVZ8oIfT1/OyP QAS9yg== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4han54ss4j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 15 Oct 2026 09:22:44 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-91b89618384so6325556d6.3 for ; Thu, 15 Oct 2026 02:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792056164; x=1792660964; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YIcabBqKQNdc2sscABVfZLyCZqhIe0PxX/KTiOQKlRE=; b=HXGumam5cI1CeEIGI1V9fV3Yz6eVGwXG1zu0A0s7eSrfMANOTloS1wUXDvbVrBmaYh K16Zbbw9n/jRQQrnH45DNvhsa4PAHS9mraOLfAjA0S7OYKDzDdOwGYsfLFW4b3T3zHrE qJNpiC9RkwAlD/eaic/Bo5K9P7m1/KG1am99jVVNIHvOJKvvV/pklFzyX4bUuXKvcxUe XWfxDt1ZzjZ1iMqS+JLtkC5yuI0wkxkKYWk/2V+fZhKAgBjfVBF5s/iwvVlv7t1A7iVl Et7he/k5Hek/D9H07kpZ/HlfsTaLkse20imIXlgQlUOVF1svDBAgLEqBUIaTWTYhrtIM P4fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792056164; x=1792660964; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YIcabBqKQNdc2sscABVfZLyCZqhIe0PxX/KTiOQKlRE=; b=AzVlKP1HqGQvBEyJPizq8b+aGPPhW5amXAvyqpbJCM0RjWY+YMCaN7O/3wdoTP4OM9 jJGaXXW6Sj06jYPpfykFp0P3zkof8SdeHCnpRgCvQDLGKGVWsBRBLnRBUN4fiL9HvPGB zDJKDTQsMXnZPueB9sgDBpP/sjMIZGyHl2o+4iiDwHQFyrlxH3qBpsauvEn2iyThF5Qa 0ql8G4mGfKH+mAl1qNwVqeFWRTokEQewCUy3vtoBRC3vWkQGBihkf2KWieX6NpUjBEwI yiNT84EeiWwHPkHGB+IAutLs2A7zjYu6ogtfGqxQMFZS8C6tEjXvdyb5m+isEtoqOx5p bPAQ== X-Forwarded-Encrypted: i=1; AKwUvBy6nFURG5WK0R6UkS5HSwbAjeW+fchUrMtG08vwpeiktPyFZESXNa6imF95wU/Vlmd10WYx5fZ9BMrwv8I=@vger.kernel.org X-Gm-Message-State: AFq9FYJgLTE+576AHID6GhohKiLLgc+832DHYOkJNkaXHOy3BRgOheL/ OmFUWcuxMnUCBm4J97FMiRDRmH+IYzGYZ5NHa6MDd19DJ+LO1yAyhhMC/6R2QFo0A1/ImYAMOpF GAdGoiWvDAwNsILWc8AakJj7CUuTFnojvYCU9dXoCkwyGHRUyXJAJrim9SOLcIdLtc/c= X-Gm-Gg: AYBFou04xMjreDxNknWljuBRqpZJDNT+aqS3+gll7EFTfv4kUPcXIG82iT7a6hX72Nn +NOhYel/DT6tK5v41Vsk3pyk6C3wgAJjnubEobFcAGek8nz3fuo3z+/AFixJAALpYx8SNHP+lNx hyUHQOGNlmNfqnYfPVWCsDyrm15cM6Ld7oCebEjeyw+PjYGNnY2DsIGuZxWmxj2tvBFmL9SjroC uB4F2VAl4dkxyWm+vrGxs4w/Pan3/K5EIIGqqQ0MN2nnBJCjgy0XIzPv2I0VWXF7213TFgtjnng u+LAIg1NfXnG/SZxKR2iSlfKz7lW8UdZgdMIWioH3zrqbH/6NGIb6pN1RQ0sC6QtlCUZkkBTZ0g jIY7vuFlOqZVDVksWZhy0Tw== X-Received: by 2002:a05:620a:439e:b0:93e:54fc:2c79 with SMTP id af79cd13be357-93ebd264008mr3098127385a.5.1792056164131; Thu, 15 Oct 2026 02:22:44 -0700 (PDT) X-Received: by 2002:a05:620a:439e:b0:93e:54fc:2c79 with SMTP id af79cd13be357-93ebd264008mr3098112685a.5.1792056162106; Thu, 15 Oct 2026 02:22:42 -0700 (PDT) Received: from [192.168.226.26] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6b203863511sm2303895a12.20.2026.10.15.02.22.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2026 02:22:41 -0700 (PDT) Message-ID: <40657da7-b823-403b-a5d1-ae384db7f3a8@oss.qualcomm.com> Date: Thu, 15 Oct 2026 11:22:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] arm64: dts: qcom: shikra: Add BAM-DMUX support To: Vishnu Santhosh , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stephan@gerhold.net, Deepak Kumar Singh References: <20260920-qcom-shikra-dts-bam-dmux-v3-1-91474d507d61@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260920-qcom-shikra-dts-bam-dmux-v3-1-91474d507d61@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=RYQFmFtv c=1 sm=1 tr=0 ts=6ad09b64 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=n0qhTGZLqvVnVCnvLeoA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE1MDAzNyBTYWx0ZWRfX1Imvy1wqHGGo /lRyaC9sNRimFShipXtjOlVRtWqmmA47aX3+mVQbnUN1ElwRL17Ko4j86Snf1BfKQAi7eTXzYqT /CYIhNxdah7WEkVgAMkS54dOhkOVED1R8At5ATIZ4lGIxWwm0eFrmLcVQj652qba8Ocw6eM/hOe Pj11S46DVwWw78rWAhMK0GnBGEa36WZ9DL74cUuk6Bd+wcVsFWi6pawckaa4ng7fS3muefrjgwd BYjvl2kQd6tAgOUu1JwdjBKtcSrOyuGC6RqULB2yM18muEW61pp8o1WpHZ63q9gdHmQJdhiXp3G MZDP5Ow508eLjVK745Hk31y8s1PmrvRwKB9lYWGLv5KAJVJjy3nCxoGzL+P07GMgWu+Tvj3txv3 IVM8BOC12nwNZ2nt26hxohn5eP/XXqRQlbZjz1//6oUwwWxPKQeikfhE32H0dOwbQZEe6wzyZQV /W0PH3reo91SZ2GmEMw== X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE1MDAzNyBTYWx0ZWRfXwgFpV7b1PF2e DTNNi0GGBbvWMzRH71bLF0owKguS/3nO24Zi12rCa/b5uSdOxYoHTW9LUq5PJgJ2UOsY+v7xHL0 LXxp6H9jtxklWzU4fpD9xpXXSaj7P0Y= X-Proofpoint-GUID: wACF7yiASOhft9BdA4B8A-iTuwjp3ChX X-Proofpoint-ORIG-GUID: wACF7yiASOhft9BdA4B8A-iTuwjp3ChX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-13_01,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610150037 On 9/20/26 5:28 AM, Vishnu Santhosh wrote: > Add the SMSM state entries, BAM-DMUX node, and BAM DMA controller needed > to provide modem data channels on Shikra. > > Reserve a 256 KiB restricted DMA pool and reference it from both the > BAM-DMUX and BAM DMA nodes. Set qcom,vmid to NAV so the BAM-DMUX driver > can grant the modem access to the complete pool before requesting the DMA > channels. [...] > + smsm { > + compatible = "qcom,smsm"; > + #address-cells = <1>; > + #size-cells = <0>; > + mboxes = <0>, <&apcs_glb 13>; Why is there a "null" reference? > + apps_smsm: apps@0 { > + reg = <0>; > + #qcom,smem-state-cells = <1>; > + }; > + modem_smsm: modem@1 { > + reg = <1>; > + interrupts = ; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; Please retain a newline between each subnode and between the last property and the first subnode > + }; > + > soc: soc@0 { > compatible = "simple-bus"; > > @@ -1866,6 +1891,20 @@ glink-edge { > qcom,remote-pid = <1>; > label = "mpss"; > }; > + > + bam_dmux: bam-dmux { Nodes should be sorted within their scope > + compatible = "qcom,bam-dmux"; > + interrupt-parent = <&modem_smsm>; > + interrupts = <1 IRQ_TYPE_EDGE_BOTH>, > + <11 IRQ_TYPE_EDGE_BOTH>; interrupts-extended = <&foo bar baz> > + interrupt-names = "pc", "pc-ack"; > + qcom,smem-states = <&apps_smsm 1>, <&apps_smsm 11>; > + qcom,smem-state-names = "pc", "pc-ack"; 1 entry a line, please [...] > base-commit: 518e5b794c06c0f0eb40df3e202274a66202c137 > change-id: 20260603-qcom-shikra-dts-bam-dmux-7fdcbb6fb662 > prerequisite-message-id: 20260908-shikra-pas-bam-dmux-binding-v4-1-6044889e7e3d@oss.qualcomm.com > prerequisite-patch-id: c3d19e8dbf9451f9f8155c86c21a4e6b5dc796d0 > prerequisite-message-id: 20260920-qcom-bam-dma-vmid-ext-v2-1-4dbbff0e57c8@oss.qualcomm.com > prerequisite-patch-id: 30840b157a197cc896556c0152b26a00abba0010 > prerequisite-message-id: 20260920-qcom-bam-dmux-vmid-ext-v2-0-ef5ca2178378@oss.qualcomm.com > prerequisite-patch-id: a9c2ce26fabf293f94f384409991f8a9b3afaafa > prerequisite-patch-id: c4d2876bea87e825468eb3bd116bfdf5a203f7c1 This list screams ""can't merge this patch"". Please either send changes in a series or hold off until the dependencies are met. Konrad