From: Guenter Roeck <linux@roeck-us.net>
To: Naresh Solanki <naresh.solanki@9elements.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (max597x) Add Maxim Max597x
Date: Thu, 27 Apr 2023 03:32:56 -0700 [thread overview]
Message-ID: <406dbcfb-7a08-8067-d717-3472e42e19e6@roeck-us.net> (raw)
In-Reply-To: <5104bcd2-4203-e4f3-ac58-310fa4d45c7b@9elements.com>
On 4/27/23 02:50, Naresh Solanki wrote:
> Hi Guenter,
>
[ ... ]
>> Again, I think it would make much more sense to add hwmon support
>> to the regulator driver than having a separate driver since there
>> is lots of overlap. For example, the regulator driver already
>> sets and monitors limits.
> I agree. But the chip also has led functionality. I got review feedback to make it MFD. So when rewriting as MFD driver made separate driver based on subsystem. I'm not sure if it is ok to use hwmon subsytem in regulator driver. Will once check with maintainer on this.
LED has completely different functionality. Overlap between regulator and
hwmon is substantial because the regulator code handles limits and alarms.
Sure, you kind of bypassed (ignored) that by not implementing limit and alarm
support in the hwmon driver, but that is really just avoiding the problem,
not solving it.
Guenter
next prev parent reply other threads:[~2023-04-27 10:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 9:03 Naresh Solanki
2023-04-26 11:01 ` Christophe JAILLET
2023-04-26 12:35 ` kernel test robot
2023-04-26 14:35 ` Guenter Roeck
2023-04-27 9:50 ` Naresh Solanki
2023-04-27 10:04 ` Guenter Roeck
2023-04-27 10:32 ` Guenter Roeck [this message]
2023-05-03 8:29 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=406dbcfb-7a08-8067-d717-3472e42e19e6@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®