From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3094EC4361B for ; Mon, 7 Dec 2020 09:39:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF0722310B for ; Mon, 7 Dec 2020 09:39:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726222AbgLGJjR (ORCPT ); Mon, 7 Dec 2020 04:39:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725804AbgLGJjP (ORCPT ); Mon, 7 Dec 2020 04:39:15 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE566C0613D4 for ; Mon, 7 Dec 2020 01:38:34 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id a6so10881762wmc.2 for ; Mon, 07 Dec 2020 01:38:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XpZ628O5xaXa4RdOKN7MsGWRWJi7+t1IcOBgJgwxavs=; b=sfF17KBm2xoH141r0pfHE47pI1OemoN9EybfIO3Ncd9nZlNuvMJj8l+4ARZJMO4FvT iW8eTCDgYZFqyxaCPdVDBID3vQFjxEVX9a7ufst4amolQGqi2keHfkRhzvyt1jhf7hEw 1de/iabQBbAjgqGX3NeGFXk7UWMh2Ke2mHj9BUN2iGQ0JGYaoskfyp7KCVbAVE43xIwi Kjqw6xZ+LhKxAellDgvDuGw552lhrdpU4+X/cGHQaHPwGepodWmsBQ2qOz2hJ0dzWQKT zg3k/G3Yp8y7XG9LovsnFJ5IKhKXWaDpjenONKVgn/URho/cNUIrjzNlEX/werJ0Bq30 Tjuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XpZ628O5xaXa4RdOKN7MsGWRWJi7+t1IcOBgJgwxavs=; b=Fy+lpqW3keEd7Qx7q4u+ZwmQkEouBlz37QLj2/ah0gKe38RGdIN1pQsWIL7P6mZrSI Ep2ex6oAV/DHDYrQv7x2bvBbz8aTMZCX69O4QRd6xbPZMONRsDCdmgu6wku6jx/oCQhK wjb1bLExQT0V2hCl4jt+Sg/QTIo0PpVAiTRboWg+Lxx9nknblaamykxrYtI6GdaoAXnA FU8pJB45GzuhMi17rkDjkQ2UdzH9vc8vfn/bBMzb7rRwTOypcAalSfKtJfbKrXQ/LUn4 8ZrBNU18MieNScZvSDawlxn+8KcJEa8hA8w008dzw4n+RqiRAI/415QWj+mQyJrLQPeP yryQ== X-Gm-Message-State: AOAM530/jhLSbaQXB72MQpIZ+fJNeYSXrBPNPpwaXZuaIHICxlnbwhQ0 ntb8sp8f70ZCfORQqSvVArpK6LRomo6fqkhq X-Google-Smtp-Source: ABdhPJxGvianTv9DEmfI3MU5uIAXw/ZzSnzw9NA0pWoTLejhJd+h21+1YtLVTZFvErdVAlqf4iLZpg== X-Received: by 2002:a1c:9ecf:: with SMTP id h198mr17284160wme.104.1607333913196; Mon, 07 Dec 2020 01:38:33 -0800 (PST) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id h15sm14315088wrw.15.2020.12.07.01.38.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Dec 2020 01:38:32 -0800 (PST) Subject: Re: [RESEND PATCH v6 2/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver To: Linus Walleij Cc: Bjorn Andersson , Rob Herring , Andy Gross , MSM , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" References: <20201202163443.26499-1-srinivas.kandagatla@linaro.org> <20201202163443.26499-3-srinivas.kandagatla@linaro.org> From: Srinivas Kandagatla Message-ID: <4073d9ec-e959-7216-79fa-ee210fbfff17@linaro.org> Date: Mon, 7 Dec 2020 09:38:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12/2020 22:36, Linus Walleij wrote: > On Wed, Dec 2, 2020 at 5:35 PM Srinivas Kandagatla > wrote: > >> Add initial pinctrl driver to support pin configuration for >> LPASS (Low Power Audio SubSystem) LPI (Low Power Island) pinctrl >> on SM8250. > > Patch applied! > >> +config PINCTRL_LPASS_LPI >> + tristate "Qualcomm Technologies Inc LPASS LPI pin controller driver" >> + depends on GPIOLIB > > I added: > > select PINMUX > select PINCONF > select GENERIC_PINCONF > > When applying. You need these I think, your code is working because > other drivers are selecting these for you, right? The build robot would > hack this to pieces though. Many thanks for doing this! --srini > > Yours, > Linus Walleij >