From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EB413BA24C for ; Wed, 18 Mar 2026 09:41:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773826912; cv=none; b=dw9OR49BFXv41z9+z7qMT0Nxs09+Mo6kzWox6J+P7PAkBzj3CZyRE8HU+5cSU4RsUbnAOe0YfbQQCtdkEmEDYj99nAN/ytOaWs5msXDPJnzFZQ9hUPCZBp48TEOCGO3VvqWShgVrqzUv6fPWxysSjFecsx3ob6Wz8U1loBStbOE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773826912; c=relaxed/simple; bh=oGm7z5WFhS1F2vkp2tz9OgMWI+7feDYAJiM0g7xfIDk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=SyTJdEdJ0AvQm+8voHEe+KA6q42jyzIUkk1JetCLXHqj2GGJ8+3O7Is30aIIPO82beJuMCRtXyNV3pdbeOi5k1SvLV54bAGiDLs+tGBhrJaUuJJnN2dx6WrGeXoJUzZv/poGnn9tBbxF8P487QNWtl/JU36uqwOg2lh4zfzqfqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FXrmcu+x; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FXrmcu+x" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773826905; x=1805362905; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=oGm7z5WFhS1F2vkp2tz9OgMWI+7feDYAJiM0g7xfIDk=; b=FXrmcu+xMEfhb9y6UX809/9HqEhVRJSWIxSenNclaCvXHEDW1TxMf9HY ShHvFltPxmMm3zvwjEyWsu8Oq8YpP1y+0+bIdD1nxuCJIWV8ur48dEChG 8qdW4J+hWEopJ/Vvdh5xFhYy6UB3xKvh6aQ9Fx2mC8Cn7HT+0v/jKa4ar Gw156PQ54SYEZJ88TkxCSoaUwYpyeU3rl08c8QrWz/Em1fARUoOib+0vP EGxzqKXFroeDSsroz2pTa64DbcAOcXghlcRDPVCCGAHW95eqhbIGiq51T gdNt37kF1ge3S0NyYun42bqVchFCPk2veF4B+2Kt1ddN43xPVoo9mb2u4 Q==; X-CSE-ConnectionGUID: eiDFTk8uShCo2eVJPZlEyg== X-CSE-MsgGUID: Scd1KNtYRlCcuZjtqhyLug== X-IronPort-AV: E=McAfee;i="6800,10657,11732"; a="74576677" X-IronPort-AV: E=Sophos;i="6.23,127,1770624000"; d="scan'208";a="74576677" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2026 02:41:44 -0700 X-CSE-ConnectionGUID: RgoHS1T5QqqQniH98VHH5g== X-CSE-MsgGUID: RV5SmwFiRTuRC+R39CUfiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,127,1770624000"; d="scan'208";a="260473107" Received: from slindbla-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.79]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2026 02:41:43 -0700 From: Jani Nikula To: Rahul Bukte , Tvrtko Ursulin Cc: Suraj Kandpal , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915/gt: Check set_default_submission() before deferencing In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260203044839.1555147-1-suraj.kandpal@intel.com> <864065cfcd3baaff212135beb781b0a5990728d8@intel.com> Date: Wed, 18 Mar 2026 11:41:38 +0200 Message-ID: <407885d79847863026260d4f911e905da8d51724@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, 18 Mar 2026, Rahul Bukte wrote: > Hi, > > On Fri, Mar 13, 2026 at 06:34:22PM +0200, Jani Nikula wrote: >> On Tue, 03 Feb 2026, Suraj Kandpal wrote: >> > From: Rahul Bukte >> > >> > When the i915 driver firmware binaries are not present, the >> > set_default_submission pointer is not set. This pointer is >> > dereferenced during suspend anyways. >> >> Which kernel vesions did this happen with? Should this have had Fixes: >> or Cc: stable? > > Fixes: ff44ad51ebf8 ("drm/i915: Move engine->submit_request selection to a vfunc") > Cc: stable@vger.kernel.org > > Suraj, you mentioned that you have commited this to din [1]. Can we add > this fixes and cc tags to that please? > > [1]: https://lore.kernel.org/all/DM3PPF208195D8D000253F905FADCA379F9E36DA@DM3PPF208195D8D.namprd11.prod.outlook.com/ Tvrtko, please pick this up for drm-intel-fixes. BR, Jani. -- Jani Nikula, Intel