From: Woody Douglass <wdouglass@carnegierobotics.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH v3 2/2] regulator: pf530x: dt-bindings: nxp,pf530x-regulator
Date: Wed, 3 Sep 2025 20:46:32 +0000 [thread overview]
Message-ID: <40798d54-fb25-45b1-80c8-b378adb545d9@carnegierobotics.com> (raw)
In-Reply-To: <175693109173.2632698.2374155993251530154.robh@kernel.org>
Rob,
Thank you for pointing this out! I will rebase on the latest rc1 and run `make dt_binding_check` before submitting v5!
Thanks again,
Woodrow Douglass
On 9/3/25 16:33, Rob Herring (Arm) wrote:
>
> On Wed, 03 Sep 2025 11:31:38 -0400, Woodrow Douglass wrote:
>> Bindings for the pf530x series of voltage regulators
>>
>> Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>
>> ---
>> .../devicetree/bindings/regulator/nxp,pf5300.yaml | 52 ++++++++++++++++++++++
>> 1 file changed, 52 insertions(+)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/nxp,pf5300.yaml: properties: 'additionalProperties' should not be valid under {'$ref': '#/definitions/json-schema-prop-names'}
> hint: A json-schema keyword was found instead of a DT property name.
> from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/nxp,pf5300.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
> $id: http://devicetree.org/schemas/regulator/nxp,pf530x-regulator.yaml
> file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/nxp,pf5300.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/nxp,pf5300.example.dtb: regulator@28 (nxp,pf5302): 'regulator-always-on', 'regulator-boot-on', 'regulator-max-microvolt', 'regulator-min-microvolt' do not match any of the regexes: '^pinctrl-[0-9]+$'
> from schema $id: http://devicetree.org/schemas/regulator/nxp,pf530x-regulator.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/nxp,pf5300.example.dtb: regulator@28 (nxp,pf5302): 'regulators' is a required property
> from schema $id: http://devicetree.org/schemas/regulator/nxp,pf530x-regulator.yaml#
>
> doc reference errors (make refcheckdocs):
> Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/regulator/nxp,pf530x-regulator.yaml
> MAINTAINERS: Documentation/devicetree/bindings/regulator/nxp,pf530x-regulator.yaml
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250902-pf530x-v3-2-4242e7687761@carnegierobotics.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
>
next prev parent reply other threads:[~2025-09-03 20:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 14:21 [PATCH 0/2] regulator: pf530x: NXP PF530x regulator driver Woodrow Douglass
2025-09-02 14:21 ` [PATCH 1/2] regulator: pf530x: Add a driver for the NXP PF5300 Regulator Woodrow Douglass
2025-09-02 15:08 ` Mark Brown
2025-09-02 14:21 ` [PATCH 2/2] regulator: pf530x: dt-bindings: nxp,pf530x-regulator Woodrow Douglass
2025-09-02 19:19 ` Krzysztof Kozlowski
2025-09-02 21:17 ` [PATCH v2 0/2] regulator: pf530x: NXP PF530x regulator driver Woodrow Douglass
2025-09-02 21:17 ` [PATCH v2 1/2] regulator: pf530x: Add a driver for the NXP PF5300 Regulator Woodrow Douglass
2025-09-02 21:17 ` [PATCH v2 2/2] regulator: pf530x: dt-bindings: nxp,pf530x-regulator Woodrow Douglass
2025-09-03 6:16 ` Krzysztof Kozlowski
2025-09-03 9:34 ` Mark Brown
2025-09-03 15:31 ` [PATCH v3 0/2] regulator: pf530x: NXP PF530x regulator driver Woodrow Douglass
2025-09-03 15:31 ` [PATCH v3 1/2] regulator: pf530x: Add a driver for the NXP PF5300 Regulator Woodrow Douglass
2025-09-03 15:31 ` [PATCH v3 2/2] regulator: pf530x: dt-bindings: nxp,pf530x-regulator Woodrow Douglass
2025-09-03 20:33 ` Rob Herring (Arm)
2025-09-03 20:46 ` Woody Douglass [this message]
2025-09-03 16:08 ` [PATCH v3 0/2] regulator: pf530x: NXP PF530x regulator driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40798d54-fb25-45b1-80c8-b378adb545d9@carnegierobotics.com \
--to=wdouglass@carnegierobotics.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®