From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61869229B18 for ; Wed, 13 May 2026 13:50:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778680210; cv=none; b=G2cK7IbMMdyNILcyJ56r+zZNX4cpfQn9Ae4+cBcbtfCvL9rtb7VWmepTtD+y93m2hpSYp1qVp76ckR1f7bjLZDn3dvW44nDL2lbmlrdRG/QuMwf40KmB6A+ovrDhZbp4jZVTYH2rXauvXpUcrENGvoPjlSlXCp9mF9/PloQj00w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778680210; c=relaxed/simple; bh=21ChlqnG6+1/0k98un0SM3BswxDZ2/eLtnXGSiSpg9I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p5Kc3HqJElPDJaf1vzVob6Vx2DUmC7qp8F+w21xeUnFy+pbfPZnzqzOmOt+YIFwL2A4/6gtVkwoetKdeAuEdgTCGurxIdPobmxn4VWTVC6BFIvWo5Ghf5sjEOG92kIAdvIwVG439zNfIIMNQ5IdYmEf5BYjAanBSyt8AKyUZxxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dt7aNmJo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=COgGPQac; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dt7aNmJo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="COgGPQac" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64DAVGTK3430122 for ; Wed, 13 May 2026 13:50:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kUmVYuQhPuKy5nGxoKDn5VTEZwu2/Gq0ve+F1MIYe/I=; b=dt7aNmJowZ9f8t84 IjAgZmLQ62UDHq4Csa1iRHBgGhuaIK+owMODgGoXyTf6GdDgFwqlxaH3/QcB/dmu ZhtYJ+MFwrK5Ep7lpzI5LF0ueVDv9PdnNJ6heWXYgUYxs+B60Ln3MkO+vB9FfNck TLoVlCgAdWdXynKtU9FmRgRPzmLnBajU4SMuyz4qgQpy1Gq3UmjnibM/jGXzpyf7 2KRduqmMfgww+Er9LrZ9S22vYkXz5bHNgjyvkGRi7tXKDG42BH1Kap5RGBIQpuYo ePmGcPvHAruci+mG+vkJA5l1ZoN0++TbQqtPOFHPVXgz2T4U51VBebIyIG6erOcF Wwy8pA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e4qmcgpsy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 13 May 2026 13:50:06 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b9fe2d6793so122918145ad.0 for ; Wed, 13 May 2026 06:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778680205; x=1779285005; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kUmVYuQhPuKy5nGxoKDn5VTEZwu2/Gq0ve+F1MIYe/I=; b=COgGPQacpedAAcmHTZI6w+3yzKL/A8MdvkJZ+5Ho0engneM4pSPqcjXmPjzJ4kE+ci PV9cLdWDio1Ji2x59qakl5KUQyuL6UrpLI3zO0XdR1zIFTSdtyPoKsvopRITAIP9xycX KGMW/DxnU5Sk1Rlr+eYQ7PJdgjyMti2qzYrVYBnwRoiugPVhX75HFMKRXlcy8XzjZ/cX FEVDZBhUZ5G2co0Z50nIQfYWs6njratbvLZghd54MPaXiJoBuozGmDkexOIKYNjkGyrD WK9XhEoQF9kSOFcPzwnSyr0Dm6nzeJZionSI+HmHEv9t5WOkjE29EwrtFe13z/oUvxv2 FHGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778680205; x=1779285005; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kUmVYuQhPuKy5nGxoKDn5VTEZwu2/Gq0ve+F1MIYe/I=; b=tKnbHZfYPeBl474z7U1njIAwB0W+64jPZDOt3qBD6jpYEPJNaOqj4qIKtWBjWaC+kN bIIXpPQ+VmNbMHmb5oxISUR4GDpYA7DDMU8R0HQJBGvEBuIrZ5EzNlghHeDMhh4BiZR0 mWB5AfTg6DwfpeW0RcBQjERj84jBep8KAcQo487PUSkAkyBXSPYx3Vpz8A6694zqsrne zO6JwgmAfAJYXkn+65LlAu38iCmA2Vvhz3IWa8P1qKcs0t7tKJvWESvgFLVx4FnEnqot CqmXJ++qG1D4gGBqlBFi/ZU42bSvA1cuoRuFtQlzs+IAH8o+9lBcHtQLh0uu9OtLfR04 OOFg== X-Forwarded-Encrypted: i=1; AFNElJ/DBdQanS3ez9me6YJpJC0jD1Z1/k1dD56HjtQ0x7Ayf/nLnc7HBRKkTA4f42mzcYEFISFgxgNHgutnC7g=@vger.kernel.org X-Gm-Message-State: AOJu0YyW7iepyCO3Hrv+s6zgprpbRfeu/eQWjAU8e7/7RMcTH379ngiv cwwsy1r56prj5ykYRSGiTEsUBJeBGGfvWtcOkQxS/z9vx9e2gnTgIESnCjrHqL8w6dHQsQ8MkHU adESB2gKDJbrwA/eRBwiD8BkZwC9NXiVTMcwq60nabm2gkAhgHSOJxsTq4VaIG1xNefg= X-Gm-Gg: Acq92OFZMqLKt8I/Gao9tO+fKr+8nN2H0D5xLULc4VsaDzdLNtDi295sjTQ9LPO5s/l cbYaoXwPzGKWTYu/TFOAEHFgkv9gKCNQNbVA9RQbOTVL/jw96T/mMmVIGJ7DMEQYD8+aXIJV1WI UsDDfFdsnlsIYniiU/mWzo0/7+ueQdTZL0avEkxUedugQYVd/CrTlRotykyHBSGEtLRrwWLOviE W5U90o4azPn5u3JU5g17R9BArWbgr58ifM/RmJG5yzCOTtOdmXixu+sj6abpGb1oXlIxiZ55X6X uArHh05D7/nHsdsRBE4721x2lnflxBQBFfxGFgv5LARjFCJj1eGC3urLzHzN9HD4uHExHwi051L gBKRSED/QzH5C3b0pzEoAfDD1YbX96vYvyuFu2sIZ8n1gyUDgog== X-Received: by 2002:a17:903:17c6:b0:2bc:8f62:990b with SMTP id d9443c01a7336-2bd2773e38fmr37055445ad.41.1778680205301; Wed, 13 May 2026 06:50:05 -0700 (PDT) X-Received: by 2002:a17:903:17c6:b0:2bc:8f62:990b with SMTP id d9443c01a7336-2bd2773e38fmr37055095ad.41.1778680204806; Wed, 13 May 2026 06:50:04 -0700 (PDT) Received: from [10.219.49.212] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1e75fffsm160721795ad.59.2026.05.13.06.50.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 06:50:03 -0700 (PDT) Message-ID: <407abe2a-3a82-40a2-8072-24ba927bfd99@oss.qualcomm.com> Date: Wed, 13 May 2026 19:19:59 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM To: Konrad Dybcio , Bjorn Andersson , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260508113636.3561383-1-ajay.nandam@oss.qualcomm.com> <20260508113636.3561383-3-ajay.nandam@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 6ajzVmLL3oA8yR5AsR1VcNBPOYkeTer4 X-Authority-Analysis: v=2.4 cv=Hu5G3UTS c=1 sm=1 tr=0 ts=6a04818e cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=wtJw0QWr3tSJ1Ft8UIIA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEzMDE0MiBTYWx0ZWRfX3DNXdO72Y78J LWNeLieSTrqeJ18zXOY+2qHhP8XeOy2sL3/O9R9ao35LtayYRpawZv+Age7SIqz5DFCWbS+uzd2 29h1o+V+ERpUbGoNUS90dK1YAGjT9xR1PzHMUs3fKFCWGiGvZ10AjzrJzMdkcIGg6bcYtwgp5Qz ZawXj0JKP4PgM8/LDPjgM+IY5fjDWE/MvTj7f3sI129JxSjeQHo39qXFVOHgjqzk1SW6OKJVrI6 fymaeukeHaKOY91bgh75yZffcVEiNBfBJnHvud7ntXVvrC9nzYAPFiVAbLTwyNs8kj4D6Ea4/1b Tq6CaomvvYYWknJEkf56SHkvbXL4pe7YrqExUFf16aK/LMscthx+ZMed1Xx/4wdq7m1m1afrOwD iygHxZbPZxVEukPAaDAQQYvl80HXLREJspIU+w6vHkMdCT0PDEPI/n379151QIzKrvlw0TlRAOu CrYflKpIkNPOeOyYOAA== X-Proofpoint-ORIG-GUID: 6ajzVmLL3oA8yR5AsR1VcNBPOYkeTer4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-13_01,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 spamscore=0 clxscore=1015 bulkscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605130142 On 5/8/2026 7:10 PM, Konrad Dybcio wrote: > On 5/8/26 1:36 PM, Ajay Kumar Nandam wrote: >> Convert the LPASS LPI pinctrl driver to use the PM clock framework for >> runtime power management. >> >> This allows the LPASS LPI pinctrl driver to drop clock votes when idle, >> improves power efficiency on platforms using LPASS LPI island mode, and >> aligns the driver with common runtime PM patterns used across Qualcomm >> LPASS subsystems. >> >> Guard GPIO register read/write helpers and slew-rate register programming >> with synchronous runtime PM calls so the device is active during MMIO >> operations whenever autosuspend is enabled. >> >> Signed-off-by: Ajay Kumar Nandam >> --- > > [...] > >> for (i = 0; i < g->nfuncs; i++) { >> if (g->funcs[i] == function) >> @@ -119,7 +133,9 @@ static int lpi_gpio_set_mux(struct pinctrl_dev *pctldev, unsigned int function, >> return -EINVAL; >> >> mutex_lock(&pctrl->lock); >> - val = lpi_gpio_read(pctrl, pin, LPI_GPIO_CFG_REG); >> + ret = lpi_gpio_read(pctrl, pin, LPI_GPIO_CFG_REG, &val); >> + if (ret) >> + goto unlock; > > Please remove the mutex_unlock/goto calls and replace the > mutex_lock with guard(mutex)(&pctrl->lock) instead. This will use > the scoped cleanup mechanism and let you simply return directly, > shrinking the diff ACK, will update in next version. > > [...] > >> + pm_runtime_set_autosuspend_delay(dev, 100); >> + pm_runtime_use_autosuspend(dev); >> + devm_pm_runtime_enable(dev); > > devm_pm_runtime_enable() can fail, please check its return code > > nota bene pm_runtime_put_autosuspend() also can, but it's much less of > a problem ACK, will update in next version Thanks Ajay Kumar Nandam > > I gave this patchset a spin on 8280 CRD and seems to work fine, nice! > > Konrad