mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Li Huafei <lihuafei1@huawei.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: <jolsa@redhat.com>, <mingo@redhat.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: Reset the function filter after completing trampoline/graph selftest
Date: Wed, 27 Apr 2022 09:39:27 +0800	[thread overview]
Message-ID: <407b6387-c4a1-830d-00d1-21cbac133843@huawei.com> (raw)
In-Reply-To: <20220426113114.2005b94f@gandalf.local.home>


On 2022/4/26 23:31, Steven Rostedt wrote:
> On Tue, 26 Apr 2022 16:00:35 +0800
> Li Huafei <lihuafei1@huawei.com> wrote:
>
>>> No need for all the 'goto reset_filter', if this function fails, then the
>>> tracer is disabled, and there's no reason to clear the filter. In fact, it
>> Thank you for the review. I see that we will disable function_graph tracer:
>>
>>        /* Stop it if we failed */
>>        if (ret)
>>              ftrace_graph_stop();
>>
>> But there is no function tracer disabled. Am I missing something that
>> would disable the function tracer?
> No, but if we are triggering these, then something really bad has happened,
> and function tracer is possibly corrupted too, or should not be trusted.
>
>>
>>> may cause a crash (because something bad happened).
>> Yes, so should we kill ftrace when the function_graph test fails?
> No, but the system should be fixed. These should never trigger on any
> production system, because it means something really bad is happening and
> we do not know what.
>
> Not resetting the filters may even be useful in debugging it. So that's
> another reason to not do so.


That makes sense.  I will remove all "goto reset_filter" from the error 
path and only reset the filter when the test passes.


Thanks,

Huafei


>
> -- Steve
> .

      reply	other threads:[~2022-04-27  1:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-18  7:39 Li Huafei
2022-04-25 22:58 ` Steven Rostedt
2022-04-26  8:00   ` Li Huafei
2022-04-26 15:31     ` Steven Rostedt
2022-04-27  1:39       ` Li Huafei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=407b6387-c4a1-830d-00d1-21cbac133843@huawei.com \
    --to=lihuafei1@huawei.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®