From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753807AbdBNLfR (ORCPT ); Tue, 14 Feb 2017 06:35:17 -0500 Received: from mga04.intel.com ([192.55.52.120]:16673 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752672AbdBNLdv (ORCPT ); Tue, 14 Feb 2017 06:33:51 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,160,1484035200"; d="scan'208";a="933690434" Subject: Re: [PATCH] mmc: sdhci-cadence: fix bit shift of read data from PHY port To: Masahiro Yamada , linux-mmc@vger.kernel.org References: <1487070340-8988-1-git-send-email-yamada.masahiro@socionext.com> Cc: linux-kernel@vger.kernel.org, Ulf Hansson From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <407ed213-eac5-7ee5-f6f3-f5e19da2c70b@intel.com> Date: Tue, 14 Feb 2017 13:28:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1487070340-8988-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/02/17 13:05, Masahiro Yamada wrote: > This macro is currently unused, but it may be useful for debug use. > Fix it just in case. > > Fixes: ff6af28faff5 ("mmc: sdhci-cadence: add Cadence SD4HC support") > Signed-off-by: Masahiro Yamada Acked-by: Adrian Hunter > --- > > drivers/mmc/host/sdhci-cadence.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c > index 4b0ecb9..5ffa2e5 100644 > --- a/drivers/mmc/host/sdhci-cadence.c > +++ b/drivers/mmc/host/sdhci-cadence.c > @@ -25,7 +25,7 @@ > #define SDHCI_CDNS_HRS04_ACK BIT(26) > #define SDHCI_CDNS_HRS04_RD BIT(25) > #define SDHCI_CDNS_HRS04_WR BIT(24) > -#define SDHCI_CDNS_HRS04_RDATA_SHIFT 12 > +#define SDHCI_CDNS_HRS04_RDATA_SHIFT 16 > #define SDHCI_CDNS_HRS04_WDATA_SHIFT 8 > #define SDHCI_CDNS_HRS04_ADDR_SHIFT 0 > >