From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758696AbcGKLh6 (ORCPT ); Mon, 11 Jul 2016 07:37:58 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:54343 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752276AbcGKLh5 (ORCPT ); Mon, 11 Jul 2016 07:37:57 -0400 From: Arnd Bergmann To: Rob Herring Cc: linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Kefeng Wang , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kukjin Kim Subject: Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Date: Mon, 11 Jul 2016 13:40:45 +0200 Message-ID: <4080443.gtvsF1A0TV@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1807726.lxvlsY5ymW@wuerfel> References: <20160627110303.3391769-1-arnd@arndb.de> <57710F1F.8090304@samsung.com> <1807726.lxvlsY5ymW@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:kY2/+jcTAEiqTnsmJjFligNd1ocnZMxu7EV0Nyc2+54pYsXm2zJ DrkaMswitUetEpdhqZff5JVPkAkL1aPrmoGVxuwoi2KwWL0lZzN4prplq5L1uwelMcEi8B3 qeMPTICAVAfm2HEeZNYzEgCPa8H/v50SZTvISBQcWbGclJ+MLx3I2Hx+PwEIJHojVSE2JvO NCmUoz8479ywfLdY9gm/Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:PBwl/ABS2f0=:2oCfopFDHELKRZywL39RbF y8ropFfypilXvYS56UWbb7uiMuxBfPQqe99ICSQpSLn3VMhL+/9Z9gNY1oXDVcgXATm49bbE3 am1lqURccly9USZONRT0GKgAWT6wUokC4SwkvDQAWV4fHPtTiLq+h4JOJx+uhtwkXcB5MJU1m zYkc7fmXKRzlDWcBaY3rCLHLBf0Xh4bKE0kbMRX7Fgv6TLexQsDmEzndwpZmoppcva7WYk0Xe ihHeISlFVgX5fcQdUnLEUgO+6JHal16ZjoC4YbAndun3UJtidgZj69d+EcBsITaJO+27t3kI1 bwS6YwevJSCrTMmrBCM89dsht1VVG7m6OCger5CO4nOk+xwSlfbA5Lzpzbs8S4QNlQPVhjH/r MS4kPrYvKjFKVEY78RPP2os1Ij2p5rRlQxpqBKqR+vqaHT/653u1wZ0FQov2UfhuB0kaj0+JI YeSOHRpPe3+RSpJG0p64InMFMnMt/+OWyJNBtiHdjCjDfFINt7kQIsODv1YQRPk4xAIf8Njs7 MwyscGSySpEbM8ZHk4f45thZLrKSTFcuUK+XSgXtB4ztiNkVF232hUxopppfgIucdTpKe1GqS QTu5d1aw7o8LK5GY4uB0qpr6BhwPkoSnKrrhBT6M28JhvPgSDH8WYKTDT1GtiqiT2h6DblS1W Y/OKZT22b0n8ofUth3YagTDqvQLyu71OdzQkHguvWgxf8TpnWGyWnMlhQ82Wul/wut232wgXx LzZYMlid5wKtvayP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, July 11, 2016 1:15:11 PM CEST Arnd Bergmann wrote: > On Monday, June 27, 2016 1:33:51 PM CEST Krzysztof Kozlowski wrote: > > On 06/27/2016 01:02 PM, Arnd Bergmann wrote: > > > The change to simplify of_platform_populate() had an unintended > > > side-effect of introducing a build warning on s3c64xx: > > > > > > In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0: > > > arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > > > > > > This adds a forward-declaration for the structure name in the > > > header to avoid the warning. > > > > > > Signed-off-by: Arnd Bergmann > > > Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table") > > > --- > > > Rob, can you apply this on top of the devicetree git so we don't > > > have to coordinate the merges? > > > > Acked-by: Krzysztof Kozlowski > > Hi Rob, > > I still get the warning in every linux-next build, do you plan to pick > up the fix for the commit you merged, or should I try to work around it > in arm-soc and leave this as a bisection problem? > Now with Rob back on Cc. Arnd