From: Andrew Lunn <andrew@lunn.ch>
To: Tiernan Hubble <thubble@thubble.ca>
Cc: Igor Russkikh <irusskikh@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Lorenz Brun <lorenz@brun.one>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: atlantic: fix reading SFP module info on some AQC100 cards
Date: Mon, 16 Feb 2026 03:12:35 +0100 [thread overview]
Message-ID: <40885b5e-5cd2-4243-be0a-9dc8d9e7b781@lunn.ch> (raw)
In-Reply-To: <20260215212609.193815-1-thubble@thubble.ca>
> + /* Wait FW to report back */
> + err = readx_poll_timeout_atomic(aq_fw2x_state_get, self, low_status,
> + orig_low_status != (low_status &
> + BIT(CAPS_LO_SMBUS_READ)),
> + 10U, 100000U);
> + if (err)
> + return -EIO;
Please don't replace the error code readx_poll_timeout_atomic()
returns with something else.
Andrew
next prev parent reply other threads:[~2026-02-16 2:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 21:26 Tiernan Hubble
2026-02-16 2:12 ` Andrew Lunn [this message]
2026-02-16 13:47 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40885b5e-5cd2-4243-be0a-9dc8d9e7b781@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenz@brun.one \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thubble@thubble.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®