mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Heidelberg <david@ixit.cz>
To: Rob Herring <robh@kernel.org>
Cc: Anton Vorontsov <anton@enomsg.org>,
	linux-kernel@vger.kernel.org, Colin Cross <ccross@android.com>,
	devicetree@vger.kernel.org, ~okias/devicetree@lists.sr.ht,
	Rob Herring <robh+dt@kernel.org>, Tony Luck <tony.luck@intel.com>,
	Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] dt-bindings: reserved-memory: ramoops: Convert txt bindings to yaml
Date: Mon, 11 Oct 2021 00:04:52 +0200	[thread overview]
Message-ID: <408S0R.DDH2XGNA3OQR3@ixit.cz> (raw)
In-Reply-To: <1633894316.420061.3158665.nullmailer@robh.at.kernel.org>




On Sun, Oct 10 2021 at 14:31:56 -0500, Rob Herring <robh@kernel.org> 
wrote:
> On Sat, 09 Oct 2021 13:19:27 +0200, David Heidelberg wrote:
>>  Convert ramoops driver to the YAML syntax.
>> 
>>  Signed-off-by: David Heidelberg <david@ixit.cz>
>>  ---
>>   .../bindings/reserved-memory/ramoops.txt      |  66 ---------
>>   .../bindings/reserved-memory/ramoops.yaml     | 126 
>> ++++++++++++++++++
>>   2 files changed, 126 insertions(+), 66 deletions(-)
>>   delete mode 100644 
>> Documentation/devicetree/bindings/reserved-memory/ramoops.txt
>>   create mode 100644 
>> Documentation/devicetree/bindings/reserved-memory/ramoops.yaml
>> 
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for 
> dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/1538758
> 
> 
> ramoops@ac300000: 'devinfo-size' does not match any of the regexes: 
> 'pinctrl-[0-9]+'
> 	arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml
> 	arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml
> 
doesn't exist besides oneplus bindings

> ramoops@ffc00000: 'msg-size' does not match any of the regexes: 
> 'pinctrl-[0-9]+'
> 	arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dt.yaml

doesn't exist
> 
> ramoops@ffc00000: 'msg-size', 'no-map' do not match any of the 
> regexes: 'pinctrl-[0-9]+'
> 	arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-bahamut.dt.yaml
> 	arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-griffin.dt.yaml
> 	arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml
> 	arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml

doesn't exist and I'm not sure if no-map make sense for pstore ramoops, 
since it HAS to be mapped (if I understood right).

Binding should be right, I can send patches for fired warnings.

David





      reply	other threads:[~2021-10-10 22:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09 11:19 David Heidelberg
2021-10-10 19:31 ` Rob Herring
2021-10-10 22:04   ` David Heidelberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=408S0R.DDH2XGNA3OQR3@ixit.cz \
    --to=david@ixit.cz \
    --cc=anton@enomsg.org \
    --cc=ccross@android.com \
    --cc=devicetree@vger.kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=~okias/devicetree@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®