From: "Alexey Khoroshilov" <khoroshilov@ispras.ru>
To: "Evgeniy Polyakov" <zbr@ioremap.net>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
"Tejun Heo" <tj@kernel.org>,
"Ruslan Pisarev" <ruslan@rpisarev.org.ua>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] pohmelfs/dir.c: Remove unneeded mutex_unlock() from pohmelfs_rename()
Date: Thu, 20 Jan 2011 00:13:44 +0300 (MSK) [thread overview]
Message-ID: <40908.91.79.118.36.1295471624.squirrel@mail.ispras.ru> (raw)
I do not see any reason for the mutex_unlock(&inode->i_mutex); in
pohmelfs_rename().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
diff --git a/drivers/staging/pohmelfs/dir.c b/drivers/staging/pohmelfs/dir.c
index 059e9d2..9732a96 100644
--- a/drivers/staging/pohmelfs/dir.c
+++ b/drivers/staging/pohmelfs/dir.c
@@ -1082,7 +1082,6 @@ err_out_exit:
clear_bit(NETFS_INODE_REMOTE_SYNCED, &pi->state);
- mutex_unlock(&inode->i_mutex);
return err;
}
next reply other threads:[~2011-01-19 21:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 21:13 Alexey Khoroshilov [this message]
2011-01-20 10:51 ` Evgeniy Polyakov
2011-01-20 15:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40908.91.79.118.36.1295471624.squirrel@mail.ispras.ru \
--to=khoroshilov@ispras.ru \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ruslan@rpisarev.org.ua \
--cc=tj@kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®