From: Stephan Mueller <smueller@chronox.de>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: davem@davemloft.net, herbert@gondor.apana.org.au,
nhorman@tuxdriver.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 1/3] crypto: Prevent to register duplicate cra_driver_name
Date: Thu, 21 Dec 2017 07:27:31 +0100 [thread overview]
Message-ID: <40918176.d7CsG1ORth@tauon.chronox.de> (raw)
In-Reply-To: <1513800567-12764-2-git-send-email-clabbe@baylibre.com>
Am Mittwoch, 20. Dezember 2017, 21:09:25 CET schrieb Corentin Labbe:
Hi Corentin,
> Each crypto algorithm "cra_name" can have multiple implementation called
> "cra_driver_name".
> If two different implementation have the same cra_driver_name, nothing
> can easily differentiate them.
> Furthermore the mechanism for getting a crypto algorithm with its
> implementation name (crypto_alg_match() in crypto/crypto_user.c) will
> get only the first one found.
>
> So this patch prevent the registration of two implementation with the
> same cra_driver_name.
Have you seen that happen? The driver_name should be an unambiguous name that
is unique throughout all crypto implementations.
If you have seen a duplication, then this duplication should be fixed.
Ciao
Stephan
next prev parent reply other threads:[~2017-12-21 6:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 20:09 [PATCH RFC 0/3] crypto: Implement a generic crypto statistics Corentin Labbe
2017-12-20 20:09 ` [PATCH RFC 1/3] crypto: Prevent to register duplicate cra_driver_name Corentin Labbe
2017-12-21 6:27 ` Stephan Mueller [this message]
2017-12-21 6:35 ` Herbert Xu
2017-12-21 12:35 ` LABBE Corentin
2017-12-21 20:05 ` LABBE Corentin
2017-12-20 20:09 ` [PATCH RFC 2/3] crypto: Implement a generic crypto statistics Corentin Labbe
2017-12-20 23:37 ` Randy Dunlap
2017-12-21 6:38 ` Stephan Mueller
2017-12-21 20:03 ` LABBE Corentin
2017-12-22 6:38 ` Herbert Xu
2017-12-20 20:09 ` [PATCH RFC 3/3] crypto: tools: Add cryptostat userspace Corentin Labbe
2017-12-20 23:37 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40918176.d7CsG1ORth@tauon.chronox.de \
--to=smueller@chronox.de \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome