From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FB922EFDA9 for ; Wed, 13 Aug 2025 11:21:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755084088; cv=none; b=RHu6TDOq1AArAPqb4vrEziES9O6ntKf7T8RNX3lV9xi0lW8RyJf74u0tGG4B5Byv+AKNzGtC83Zt2IptSpgUvU3xjz9uZY9vf7SoPA4UrQ8sVZuWlSe6z7I2QvcPc+bytwpFnd6RBkGeVnauBgBpjYafDLL2/fKECh2slYutaPI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755084088; c=relaxed/simple; bh=ATnrKpADnp0VYyHm2V3OrqD8KcPfJd1QRUQCZ5jM5No=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CbMenWe4JMEg/aNgvoutUbWL3Zo3diDATmJ6pX2/JwEAsk0pD8r5YvGPYdooxuT4RNEKpH5XdqQLsn8MDKtgS6TYdYMqkBKt8/FGSgA5ewWD483fYXLXH9+7eYcf+ytdao54oWNkxnknsFpkIiU3c0u4hecw2PJ3ksz02fTHTh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AekzvgT/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AekzvgT/" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57D6mW9u015813 for ; Wed, 13 Aug 2025 11:21:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Pagz2rCmdnqFa4fN0V2LLZHvLwAniMzGzcfSL+Hc7Pw=; b=AekzvgT/XQXmTGqg o4NY7IhwNX7HTlOWSWEVfJVSlU1Bn7oCYHH9a7Uq0+ySoRosZXWFdRmCV/aM6zRr oHqO1TWMOXPD3Afasd1M1iBUWhRYekT1zML7lwu0fxoSVmhcm+h21MRyCbR8MptI qkpDgn72ZDzf8wPU5eZlDcNvNXDi2HS3ePwCzMv2pY6JYj27s6r2tU615KQjQLOn wB9F3iR4MbMIGMEI6ohznRzylDciYEa4fv8DRtJ4g4WRS1QYsMFrE/z42tVdYz70 +PbkGD0RrHrpYrLyF173Se1mqUR5MMBV+5KDlAeGP7gqQ1IXk34g51W5CHcg2Vw0 WX/SSw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48fjxberg8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 13 Aug 2025 11:21:26 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4b07de45deaso3932671cf.3 for ; Wed, 13 Aug 2025 04:21:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755084085; x=1755688885; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pagz2rCmdnqFa4fN0V2LLZHvLwAniMzGzcfSL+Hc7Pw=; b=IKeYybhAgpKgLBLRVyDltKc6dLZi5+faG6DR5WvyQYImwJhD4MYRkU0oKv2qXQK+7k eVtvnoOy6ARX3ek4TXdha55UDhuK49acgTDmu5DR1zkiYCzdTKGLFmwgolHsjfBWSYcO 2C5XqZO4VOMehw8ZyKVBMhLy18oKorbupD7ri0rqa2RvincasxjQP2/VI4IQ+qAuUaPE +VAWBB0S+3jQqloD68O4mLKBSWAnor034Vm7RuwW8+LeeNPkKWjAMJgL5lKVKaEPByI1 A4yX3nLePv3F4etM4wI+KuqDvbQ1e+SWiQznOpZn7GBqZKp4V5SWGyI76ioGxnGU9/o2 pjCw== X-Forwarded-Encrypted: i=1; AJvYcCXh76+t432bQmttwgijzyDgJHY0mYoGC27pFscd6lZuIOXhr/pp82ETI++eQ+8pfDOLk6pegkL8cetG4m0=@vger.kernel.org X-Gm-Message-State: AOJu0YzMsJ7kPksowizJYSEFC7Xi2biG1eYGJ7kNUPWqvQF6lBgvJW/s Yhzyu4lu9hkwAb5BX/isMVGkSOAFStrOMru8UGXhLX/nAHHxp42Tvjovmoibe9+mmZ73TDhXFfA 3DqkyS7iHm7whpIXiDjfy0EA9mlIc5BVtQnuNeq+qP38NmDE8ZwWyCjONus1WuS3cqI4= X-Gm-Gg: ASbGncvPgttLdgWdxVnsE3Utg5V4S43QFVcnG9KmPlg8A9j2igylS1VsZytss9rRrcb O36I0XvmtuNQTlHZ0koHlFFuNibarnDcF37a1lUQqfMAobYEYUCqOnkUVjHCRYVeLkx3UEmqu38 gyJ0trV1ZI4C2mvLS2eYhRdXOVwOK0eZF5OwTHHAcAVMh5OWJs9zgXastlQnePeaK1CnXSufS8p Wg5K4uhICYDITlP6JfTPJuQ0QnvLtb0X7NL7tfqnWfDLvaT5lI00N/2oQOFLRsNcejpv3c/oC/2 zWEGHX8cPEe8m6J+pcdBkdjWxW/rZkbBgSycdo10Y0k/RZ4g+HMrFxyznrCYteMwAIxtoogLlDA lshcy8DCHEnIFXoG3mA== X-Received: by 2002:ac8:5dce:0:b0:4ab:609f:d7d1 with SMTP id d75a77b69052e-4b0fc6cbd31mr15047661cf.4.1755084084116; Wed, 13 Aug 2025 04:21:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELoeKz7TW8iFmXICbiE+qGXINJWaTAvZ9IPrgzvR6IcayWxJQVgY4rMoZo+a0ES+DA0q4znw== X-Received: by 2002:ac8:5dce:0:b0:4ab:609f:d7d1 with SMTP id d75a77b69052e-4b0fc6cbd31mr15047361cf.4.1755084083428; Wed, 13 Aug 2025 04:21:23 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-615a8ffa17csm21277071a12.49.2025.08.13.04.21.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Aug 2025 04:21:22 -0700 (PDT) Message-ID: <4091c488-996c-4318-82ad-c054a9ef5a22@oss.qualcomm.com> Date: Wed, 13 Aug 2025 13:21:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V4 4/4] arm64: dts: qcom: sm8550: Remove SDR104/SDR50 broken capabilities To: Sarthak Garg , Krzysztof Kozlowski , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Adrian Hunter Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, quic_cang@quicinc.com, quic_nguyenb@quicinc.com, quic_rampraka@quicinc.com, quic_pragalla@quicinc.com, quic_sayalil@quicinc.com, quic_nitirawa@quicinc.com, quic_bhaskarv@quicinc.com, kernel@oss.qualcomm.com References: <20250801084518.2259767-1-quic_sartgarg@quicinc.com> <20250801084518.2259767-5-quic_sartgarg@quicinc.com> <69f2807c-9a28-4b31-97cc-2756f0ab9fd4@kernel.org> <8b023e56-435b-43df-8b15-c562a494e06f@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=G6EcE8k5 c=1 sm=1 tr=0 ts=689c7536 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=COk6AnOGAAAA:8 a=h_9OUBjc1HwR_7CGdB0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODExMDA5NyBTYWx0ZWRfXx59KGuMVrDKp qxrroVIbKFGi/GJk80NN3/qWLWEL46gbBGDeAfJgAeG3wSTkeJyyvJLwKsgvZXpOWc6wvWM1Zfd vkUbvzH5osoDxVVtxkEdCVXcTOrxES2Tnb+iFyRCCXtUH1+bWNp9/FaWff4HFM6E/y/ZyLW77Bk BX82ZHc5J7xt5aQ4F4EmwefoAUMPQSTj50mQ0oA0dk2yytpmrRh+N04HkpEEfDwm9TaZlqYJwu/ GRY1nTcLhqt5CPQ6qyaz/CRRHADkwzac1nE7qmTazVZPI4KVKjclEsVl1ZgRfKEWnBWIw8F6Erh ZLrnN0tGFBP2WR/Tg6j+m3rdQdLiCjIvnrsRpNPt/DnYpNy7wonPpx7l1GPoYFwkhfXXsXovG9o pKVqgX0S X-Proofpoint-ORIG-GUID: 2AA-zie88tkjDXwZZVaUY0eNEqQo6Fga X-Proofpoint-GUID: 2AA-zie88tkjDXwZZVaUY0eNEqQo6Fga X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-13_01,2025-08-11_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 bulkscore=0 spamscore=0 phishscore=0 malwarescore=0 adultscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508110097 On 8/13/25 1:08 PM, Sarthak Garg wrote: > > > On 8/5/2025 2:55 PM, Krzysztof Kozlowski wrote: >> On 05/08/2025 11:19, Sarthak Garg wrote: >>> >>> >>> On 8/1/2025 2:32 PM, Krzysztof Kozlowski wrote: >>>> On 01/08/2025 10:45, Sarthak Garg wrote: >>>>> The kernel now handles level shifter limitations affecting SD card >>>>> modes, making it unnecessary to explicitly disable SDR104 and SDR50 >>>>> capabilities in the device tree. >>>>> >>>>> However, due to board-specific hardware constraints particularly related >>>>> to level shifter in this case the maximum frequency for SD High-Speed >>>>> (HS) mode must be limited to 37.5 MHz to ensure reliable operation of SD >>>>> card in HS mode. This is achieved using the max-sd-hs-frequency property >>>>> in the board DTS. >>>>> >>>>> Signed-off-by: Sarthak Garg >>>>> --- >>>>>    arch/arm64/boot/dts/qcom/sm8550-hdk.dts                     | 1 + >>>>>    arch/arm64/boot/dts/qcom/sm8550-mtp.dts                     | 1 + >>>>>    arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts | 1 + >>>>>    arch/arm64/boot/dts/qcom/sm8550.dtsi                        | 3 --- >>>>>    4 files changed, 3 insertions(+), 3 deletions(-) >>>>> >>>> >>>> This will break MMC for all of the users and nothing in commit msg or >>>> cover letter explains that or mentions merging strategy. >>>> >>>> Exactly this case is covered by your internal guideline, no? Please read it. >>>> >>>> Best regards, >>>> Krzysztof >>> >>> Just to make sure I’m addressing the right concern — are you primarily >>> worried about the introduction of the max-sd-hs-frequency property in >>> the board DTS files, or about the removal of the sdhci-caps-mask >>> from the common sm8550.dtsi? >> >> >> Apply this patch and test MMC. Does it work? No. Was it working? Yes. >> >> >> Best regards, >> Krzysztof > > > You're absolutely right to raise the concern about potential breakage. > After conducting additional testing across multiple boards, I’ve confirmed that the removal of SDR104/SDR50 broken capabilities does indeed affect V1 SM8550 devices. v1 is a prototype revision, please forget it exists, we most definitely do not support it upstream Konrad > However, on V2 devices, all modes—including SDR104, SDR50, and HS—are fully functional and have been verified to work reliably. > > Based on your feedback, I will revise the patch to retain the broken SDR104/SDR50 capabilities in the common sm8550.dtsi, ensuring no impact on current sm8550 devices already in use. > > We will revisit the removal of broken capabilities dt property for upcoming targets after thorough validation and testing to ensure no regressions from the beginning. > > Please let me know if this approach aligns with your expectations. I’ll prepare and send out a revised patch accordingly. > > Best regards, > Sarthak