From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Tian Tao <tiantao6@hisilicon.com>, linux-kernel@vger.kernel.org
Cc: linuxarm@huawei.com
Subject: Re: [PATCH] nvmem: core: Use kobj_to_dev() instead of container_of()
Date: Fri, 4 Sep 2020 13:36:47 +0100 [thread overview]
Message-ID: <40984cd3-978b-49fc-07f0-676743d6d5f3@linaro.org> (raw)
In-Reply-To: <1597915683-44794-1-git-send-email-tiantao6@hisilicon.com>
On 20/08/2020 10:28, Tian Tao wrote:
> Use kobj_to_dev() instead of container_of()
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Applied thanks,
--srini
> ---
> drivers/nvmem/core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 6cd3edb..7641e56 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -128,7 +128,7 @@ static ssize_t bin_attr_nvmem_read(struct file *filp, struct kobject *kobj,
> if (attr->private)
> dev = attr->private;
> else
> - dev = container_of(kobj, struct device, kobj);
> + dev = kobj_to_dev(kobj);
> nvmem = to_nvmem_device(dev);
>
> /* Stop the user from reading */
> @@ -168,7 +168,7 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj,
> if (attr->private)
> dev = attr->private;
> else
> - dev = container_of(kobj, struct device, kobj);
> + dev = kobj_to_dev(kobj);
> nvmem = to_nvmem_device(dev);
>
> /* Stop the user from writing */
> @@ -219,7 +219,7 @@ static umode_t nvmem_bin_attr_get_umode(struct nvmem_device *nvmem)
> static umode_t nvmem_bin_attr_is_visible(struct kobject *kobj,
> struct bin_attribute *attr, int i)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct nvmem_device *nvmem = to_nvmem_device(dev);
>
> return nvmem_bin_attr_get_umode(nvmem);
>
prev parent reply other threads:[~2020-09-04 12:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 9:28 Tian Tao
2020-09-04 12:36 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40984cd3-978b-49fc-07f0-676743d6d5f3@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®