mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavan Bobba <opensource206@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Pavan Bobba <opensource206@gmail.com>
Subject: [PATCH 03/10] staging: vt6655: Type encoding info dropped from variable name "pbyTxRate"
Date: Fri, 27 Oct 2023 14:21:52 +0530	[thread overview]
Message-ID: <409a80898ccbb398c31f222dc29cea4725a0cfb3.1698396278.git.opensource206@gmail.com> (raw)
In-Reply-To: <cover.1698396278.git.opensource206@gmail.com>

variable name "pbyTxRate" updated like below:

a.type encoding info dropped from name
b.camelcase name replaced by snakecase

Issue found by checkpatch

Signed-off-by: Pavan Bobba <opensource206@gmail.com>
---
 drivers/staging/vt6655/card.c | 36 +++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 2968be1f8d4e..4ee9b48de2c2 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -75,83 +75,83 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
  *      wRate           - Tx Rate
  *      byPktType       - Tx Packet type
  *  Out:
- *      pbyTxRate       - pointer to RSPINF TxRate field
+ *      tx_rate         - pointer to RSPINF TxRate field
  *      pbyRsvTime      - pointer to RSPINF RsvTime field
  *
  * Return Value: none
  */
 static void calculate_ofdmr_parameter(unsigned char rate,
 				       u8 bb_type,
-				       unsigned char *pbyTxRate,
+				       unsigned char *tx_rate,
 				       unsigned char *pbyRsvTime)
 {
 	switch (rate) {
 	case RATE_6M:
 		if (bb_type == BB_TYPE_11A) { /* 5GHZ */
-			*pbyTxRate = 0x9B;
+			*tx_rate = 0x9B;
 			*pbyRsvTime = 44;
 		} else {
-			*pbyTxRate = 0x8B;
+			*tx_rate = 0x8B;
 			*pbyRsvTime = 50;
 		}
 		break;
 
 	case RATE_9M:
 		if (bb_type == BB_TYPE_11A) { /* 5GHZ */
-			*pbyTxRate = 0x9F;
+			*tx_rate = 0x9F;
 			*pbyRsvTime = 36;
 		} else {
-			*pbyTxRate = 0x8F;
+			*tx_rate = 0x8F;
 			*pbyRsvTime = 42;
 		}
 		break;
 
 	case RATE_12M:
 		if (bb_type == BB_TYPE_11A) { /* 5GHZ */
-			*pbyTxRate = 0x9A;
+			*tx_rate = 0x9A;
 			*pbyRsvTime = 32;
 		} else {
-			*pbyTxRate = 0x8A;
+			*tx_rate = 0x8A;
 			*pbyRsvTime = 38;
 		}
 		break;
 
 	case RATE_18M:
 		if (bb_type == BB_TYPE_11A) { /* 5GHZ */
-			*pbyTxRate = 0x9E;
+			*tx_rate = 0x9E;
 			*pbyRsvTime = 28;
 		} else {
-			*pbyTxRate = 0x8E;
+			*tx_rate = 0x8E;
 			*pbyRsvTime = 34;
 		}
 		break;
 
 	case RATE_36M:
 		if (bb_type == BB_TYPE_11A) { /* 5GHZ */
-			*pbyTxRate = 0x9D;
+			*tx_rate = 0x9D;
 			*pbyRsvTime = 24;
 		} else {
-			*pbyTxRate = 0x8D;
+			*tx_rate = 0x8D;
 			*pbyRsvTime = 30;
 		}
 		break;
 
 	case RATE_48M:
 		if (bb_type == BB_TYPE_11A) { /* 5GHZ */
-			*pbyTxRate = 0x98;
+			*tx_rate = 0x98;
 			*pbyRsvTime = 24;
 		} else {
-			*pbyTxRate = 0x88;
+			*tx_rate = 0x88;
 			*pbyRsvTime = 30;
 		}
 		break;
 
 	case RATE_54M:
 		if (bb_type == BB_TYPE_11A) { /* 5GHZ */
-			*pbyTxRate = 0x9C;
+			*tx_rate = 0x9C;
 			*pbyRsvTime = 24;
 		} else {
-			*pbyTxRate = 0x8C;
+			*tx_rate = 0x8C;
 			*pbyRsvTime = 30;
 		}
 		break;
@@ -159,10 +159,10 @@ static void calculate_ofdmr_parameter(unsigned char rate,
 	case RATE_24M:
 	default:
 		if (bb_type == BB_TYPE_11A) { /* 5GHZ */
-			*pbyTxRate = 0x99;
+			*tx_rate = 0x99;
 			*pbyRsvTime = 28;
 		} else {
-			*pbyTxRate = 0x89;
+			*tx_rate = 0x89;
 			*pbyRsvTime = 34;
 		}
 		break;
-- 
2.34.1


  parent reply	other threads:[~2023-10-27  8:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27  8:51 [PATCH 00/10] Type encoding info dropped from array and function names in NIC driver Pavan Bobba
2023-10-27  8:51 ` [PATCH 01/10] staging: vt6655: Type encoding info dropped from array name "cwRXBCNTSFOff" Pavan Bobba
2023-10-27  8:51 ` [PATCH 02/10] staging: vt6655: Type encoding info dropped from function name "s_vCalculateOFDMRParameter" Pavan Bobba
2023-10-27  8:51 ` Pavan Bobba [this message]
2023-10-27  8:51 ` [PATCH 04/10] staging: vt6655: Type encoding info dropped from variable name "pbyRsvTime" Pavan Bobba
2023-10-27  8:51 ` [PATCH 05/10] staging: vt6655: Type encoding info dropped from function name "CARDbSetPhyParameter" Pavan Bobba
2023-10-27  8:51 ` [PATCH 06/10] staging: vt6655: Type encoding info dropped from variable name "byPacketType" Pavan Bobba
2023-10-27  8:51 ` [PATCH 07/10] staging: vt6655: Type encoding info dropped from function name "CARDbyGetPktType" Pavan Bobba
2023-10-27  8:51 ` [PATCH 08/10] staging: vt6655: Type encoding info dropped from function name "CARDvSetRSPINF" Pavan Bobba
2023-10-27  8:51 ` [PATCH 09/10] staging: vt6655: Type encoding info dropped from function name "CARDbUpdateTSF" Pavan Bobba
2023-10-27  8:51 ` [PATCH 10/10] staging: vt6655: Type encoding info dropped from variable name "byRxRate" Pavan Bobba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=409a80898ccbb398c31f222dc29cea4725a0cfb3.1698396278.git.opensource206@gmail.com \
    --to=opensource206@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®