From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5E561ACECE for ; Mon, 30 Dec 2024 18:25:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735583158; cv=none; b=MJHd6bJCH3/agx+fXisKixjCe7eIiRVfav/a8O0iYnTvxAAoTLYmzaoe/YDu492YL6ylLtU5+eEBG3n1KOplE9jX96ZPSU1z1GzpcZL0K4nq7bbrUCJGEg4D+LbPpoA7fAP7RTB3IaRtGHgduu3ttTZOlRoLzUlMlSM4xBPC9cU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735583158; c=relaxed/simple; bh=mkeqLVFiffXgkQLYONH/kpQ6nWTDpuPh1WlyBmICpQA=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=WQXur5LJl/iJq6pDfITz1wHZyIF2HuESWQcmL5BgX9iT3T5Q4vwxbkuQmP7yrG88ZQnbeQSSR0kVetAHTYAGJdVDbRrpbocki3VXwuBiRjbOhdGXXhijdhIYZQWPc1t6oX4eKC3F9t7rQK+CYThQ/MS1Jc9zJMb7Dm4iQH+/RNc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B+LQNfDs; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B+LQNfDs" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-aaf60d85238so125932966b.0 for ; Mon, 30 Dec 2024 10:25:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735583155; x=1736187955; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=c4Cv2FWyi1dOOOU9BTe3r48rsCqijhG21beZ7nCyVIc=; b=B+LQNfDsaEBETI35IQ1iuP7itpX7FcvtYs3+rFaBcyhAu2r5VgefjUT0OCO/Lh8eA3 /mTQiJXQoCHgCS0Mp1LuWdHj6ngV5FlMUDqqLZHxkJLBjuKmePNRWJiJ512gqHpF8BKx VxLACsHT1qFUPUKrnPKPGv3eWZuI6OeCithm88zkyTvbmCgrv3TkJ/OYNUSpjDhpyeiT MdYImyQiqVg27GKWXnrSg6xiBBZNsT59GV5M7q0JMbTU86tFxBnNdwE0QXuK97jDGDwj y8k0QuhHOejW5EhXbfwj/YOR2mIhm8n00+eqq/iD9AQY5xNNeHdnsASZrgMgo2TTnCcB kq0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735583155; x=1736187955; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c4Cv2FWyi1dOOOU9BTe3r48rsCqijhG21beZ7nCyVIc=; b=FzggPHcVQrrdIHF3tk6DFpO42m09IsnvOSrgTlvJ8cMqz0NAKDU4LqklJSjDcDrMiQ wKJ7CC7GXsaETnO/+7MZmDkRB0GqKdc5UqP2nZ7UaJUbF9iyUXVnNe2JxS+imYO65zkq aBpWhJRr3Eja5teWAXWPwOLys5fgNTY+9AxYEdKDGqcXjDEFgsXmPMVdyDOGvAHx2aRT RTM2mFi5y69yQslbIzj+XTDlb1IkIMa45EvKMHr1vsbFYpnluWxGq5elv6mChqSwrMaF XiO4SLtqk8MKA19EDUvGkjYScc56SwaGjzuCXOSOZ9QL4Lnfa4yViE71h0WcRuWvF7DU fofA== X-Forwarded-Encrypted: i=1; AJvYcCUokx+TfB1TQomu5n5ahiIx1HalLr/60kHzb2mOC/fi2aEUlsUPtnjGP65hhJcn1Fo1u9MV8ljwxy6Qltw=@vger.kernel.org X-Gm-Message-State: AOJu0YxLD1t25Z44bFa1NRmo2arPKmIhOtdhprvME1stGU5/llBfA7sr Uki9Q8cfiqFjDbpTgxIeK0oqusfamENHOwU794FvHkdqNb4499DR X-Gm-Gg: ASbGncvl1gy7pQe3/1c8Rmg4afGiY8TN4JuybtIGTPHeJs1K6r9tF4dm8+lHVYoBxDf PWzHqHmIXjzOMZVYH9Ufn9a5EKXVdycJ0BOCxstjYEBymCjN2OUNkf+ngRgN+8F/jF0j/yZDLKh 6lPxGdF0jKe32hs4Xp15nzeYpUTfFG/hc34PEXVcPQCrzaUUq9NfQF3mWt3+va0XI5V3kbRXwN2 xH04gAz7fmeChzUCp/6hvPrUBF3usITSWXEDi4RGwzSjlJvigsc9dFkDBW8NJLGbHFf90me8Q== X-Google-Smtp-Source: AGHT+IHw2JU5Wyqfk8AFSsi+FCQ5WkOGTKKAN23Vi5IhLMHTvYSQN9n+ShG0NvWFbqzc7jGJDSPvYA== X-Received: by 2002:a17:907:7f16:b0:aaf:f1a:d2ad with SMTP id a640c23a62f3a-aaf0f1ade0amr1683092766b.50.1735583154561; Mon, 30 Dec 2024 10:25:54 -0800 (PST) Received: from smtpclient.apple ([132.69.243.32]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aaf6afc3e11sm81994566b.73.2024.12.30.10.25.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Dec 2024 10:25:53 -0800 (PST) Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Subject: Re: [PATCH 11/12] x86/mm: enable AMD translation cache extensions From: Nadav Amit In-Reply-To: <20241230175550.4046587-12-riel@surriel.com> Date: Mon, 30 Dec 2024 20:25:40 +0200 Cc: the arch/x86 maintainers , Linux Kernel Mailing List , kernel-team@meta.com, Dave Hansen , luto@kernel.org, peterz@infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andrew Morton , zhengqi.arch@bytedance.com, "open list:MEMORY MANAGEMENT" Content-Transfer-Encoding: quoted-printable Message-Id: <40C8627F-0B0B-4F19-8FF8-5D852A5F9F0F@gmail.com> References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-12-riel@surriel.com> To: Rik van Riel X-Mailer: Apple Mail (2.3826.300.87.4.3) > On 30 Dec 2024, at 19:53, Rik van Riel wrote: >=20 > --- a/arch/x86/kernel/cpu/amd.c > +++ b/arch/x86/kernel/cpu/amd.c > @@ -1143,6 +1143,14 @@ static void cpu_detect_tlb_amd(struct = cpuinfo_x86 *c) >=20 > /* Max number of pages INVLPGB can invalidate in one shot */ > invlpgb_count_max =3D (edx & 0xffff) + 1; > + > + /* If supported, enable translation cache extensions (TCE) */ > + cpuid(0x80000001, &eax, &ebx, &ecx, &edx); > + if (ecx & BIT(17)) { > + u64 msr =3D native_read_msr(MSR_EFER);; > + msr |=3D BIT(15); > + wrmsrl(MSR_EFER, msr); > + } > } Sorry for the gradual/delayed feedback. Is it possible to avoid the BIT(x) and just add the bits to=20 arch/x86/include/asm/msr-index.h like EFER_FFXSR ?