From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753014AbeCaODy (ORCPT ); Sat, 31 Mar 2018 10:03:54 -0400 Received: from ozlabs.org ([103.22.144.67]:55067 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752949AbeCaODw (ORCPT ); Sat, 31 Mar 2018 10:03:52 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 9cbaaec1cf0c9f4861c4c1dd65f3ede218c1ab2f In-Reply-To: <20180209120732.17863-2-j.neuschaefer@gmx.net> To: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , linux-kernel@vger.kernel.org From: Michael Ellerman Cc: devicetree@vger.kernel.org, =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , linux-gpio@vger.kernel.org, Paul Mackerras , Joel Stanley , linuxppc-dev@lists.ozlabs.org Subject: Re: [v3, 1/4] powerpc: wii: Explicitly configure GPIO owner for poweroff pin Message-Id: <40D0Zr5ldZz9s2b@ozlabs.org> Date: Sun, 1 Apr 2018 01:03:45 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2018-02-09 at 12:07:28 UTC, =?utf-8?q?Jonathan_Neusch=C3=A4fer?= wrote: > The Hollywood chipset's GPIO controller has two sets of registers: One > for access by the PowerPC CPU, and one for access by the ARM coprocessor > (but both are accessible from the PPC because the memory firewall > (AHBPROT) is usually disabled when booting Linux, today). > > The wii_power_off function currently assumes that the poweroff GPIO pin > is configured for use via the ARM side, but the upcoming GPIO driver > configures all pins for use via the PPC side, breaking poweroff. > > Configure the owner register explicitly in wii_power_off to make > wii_power_off work with and without the new GPIO driver. > > I think the Wii can be switched to the generic gpio-poweroff driver, > after the GPIO driver is merged. > > Signed-off-by: Jonathan Neuschäfer Patches 1, 3 and 4 applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/9cbaaec1cf0c9f4861c4c1dd65f3ed cheers