From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 478CE225416 for ; Sat, 14 Feb 2026 17:09:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771088975; cv=none; b=tGF/LlVejY4UuNvUYVNSe8MkY3VewSZewq0quQJFMeKQGu+DDCxJ0J53QdH2P//LfxumJg/yaUgdBBG0q63D18Twlsho/gGl4T7k0O2MuBgoopml4BvrB+X8Hqg5DWDkS+xe3mD71te60x6cxkqZAMneFiPTfCQOKhzz2635C7o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771088975; c=relaxed/simple; bh=dbIKZyx1wqWvoVfET5QSbDQ7g8Bez4WCJlHr4gZEjwM=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=kTOKuMQGW5e8DhPVgROVijZfPlxqGLN4ZUfUgtqvF4+NbamZdN/nMeJ5fyOX8yWpic9mudr0sDDcCSUq/GvBGbjVkKmAbEJeD9T/3Peb2Rf5Ec+Dcud9FY8wuuZTykZbU3nxEqDHnCZxI3FZRCqxAR/W53iHnaBtYzZ2iEKwr8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=0N5rAGIr; arc=none smtp.client-ip=209.85.161.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="0N5rAGIr" Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-66ee7b9af94so651712eaf.0 for ; Sat, 14 Feb 2026 09:09:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1771088972; x=1771693772; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=6IUlnbhB2kMGCrw14cml/lzwiGDaGw9e5IGUkFOP+xk=; b=0N5rAGIrGOcKVwjXTha4ASNMw6z2IFmQf+O0TH+62PaPP4V4iUB+dMZIPgOrwul2iZ QdAcXAU4CZa1EEteyfTVEqqu5djv7PSoxmRbSsuJLyaGLr8wa1ldcS63aBRVI9vw9BPh seJh5nK25DyyyowVi7Ve42CNIFahxXEl5xHaIpqJIk5gchnb5pdv/T+s+/oPidb62c8z 5ZOgIUKA15FpOZjSu77a9VEta+Uwr4hV/ONE7SKzFf/FJAW9fNk2yK8nvbUXXdmRJx1z cCqriKI17yrKhkv0kKzoJ16L0uy3vnlg+CZzEvRCuYsAwk4IE1GE63/bHIpcPVLyltLD tLpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771088972; x=1771693772; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6IUlnbhB2kMGCrw14cml/lzwiGDaGw9e5IGUkFOP+xk=; b=jXyeIf5Qk5e0zNsPHjmHm1/PWt8d8dYQROU3RSa2Oz6zXOzX1828Ng5LH1kpGLl72J hdM0yiRwdgXNJRHo3x+gTPrXVPcGd3zrBQfTtx0xIEOaGC6FvzRdV19SGUQenk2say5y /rv03S6qxT8bMyIpPAvEbIPVAKgY2vyx29CivB6kcojbMO+0/9rTx/9kki+1RQmJPdQk ERa7KR3jL96o+bAAOI13FakplsVGQldVId+dytlWnUVsDc5iDd3H8rJkVTY4na6Ju4MI I6wRhpRLG1Rab/ag/QULIbxpGw3wZDuV7QXCLVFvnE7nvsaJ0IsNV5/sA7qAFgDswV58 zmaw== X-Forwarded-Encrypted: i=1; AJvYcCV1+NfRBsG94PXJLe3ncrtG0RKy+6y5bTDIlJcdZhSfIYznLkqchy8Cqiat1+wuU11rrCdWqMCZCSWa1Lk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3yIygp/v3H9juKqq17jmx9JXfTWLVA7xPAmtx6zHIe0YKX455 qcd27uV6xx09ge3en57l9Ljapovbizmp/rux58z0DjReqdN1vsOrKQtrH8cNptifYME= X-Gm-Gg: AZuq6aLkKMigAygcjB1eqL3SlJ2d/6AtBOmv4JxRf3O685BuVbq+WQt7j6buJQ17gGp yR+SCIAbUgSMFhRwsVgugm71b16nZ4HCyec7Q+DOQxJsg3b+TG+YyDceWWxZxH3cWFbNYH5HqsB LV78x4HCtZweKFkDZ7k8ymB3Js9u1Jky33PaBSHxvT72IyyezxfoYuw00nA9yLZz+wRs0bBeGJj XpYq8fgZGJjs20tfrnqODozWecbwLiuzuaJyacnr/VkzqyIZLJi9WsHch+ewOLQGrFsm5som5p+ hnfRM8NS7CFtTyxKcOcIfFHFlZeJG3b1fS6WDilCTvl+xCrYK+oPlmQ2OAnZFRNBqkDezzftT0I 0pTsvjmaHXpBNADZeU8yBOx25uRRfW8uQcXsc2b/PXu4heOfw5MBmSuNKSGlUs7kwk4km+HbMVx s2Bx/bbl4RlH7wS74Isa4ruYq57ktrpt54nBRTmE+bKeVekfKziuw2grATIAry52CdYmK/7g== X-Received: by 2002:a05:6820:80f:b0:676:96fa:299f with SMTP id 006d021491bc7-6776748602bmr2433820eaf.34.1771088972181; Sat, 14 Feb 2026 09:09:32 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:109:393c:254e:962e? ([2600:8803:e7e4:500:109:393c:254e:962e]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6772583294bsm3334429eaf.14.2026.02.14.09.09.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Feb 2026 09:09:30 -0800 (PST) Message-ID: <40a0d410-731a-43e0-9078-bc8190ccba87@baylibre.com> Date: Sat, 14 Feb 2026 11:09:28 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] iio: accel: adxl345: Implement event scaling for ABI compliance From: David Lechner To: Taha Ed-Dafili <0rayn.dev@gmail.com>, jic23@kernel.org Cc: rdunlap@infradead.org, skhan@linuxfoundation.org, linux-kernel-mentees-archive@lists.linuxfoundation.org, nuno.sa@analog.com, andy@kernel.org, corbet@lwn.net, lars@metafoo.de, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260208150515.14798-1-0rayn.dev@gmail.com> <20260208150515.14798-4-0rayn.dev@gmail.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/14/26 11:02 AM, David Lechner wrote: > On 2/8/26 9:05 AM, Taha Ed-Dafili wrote: >> The ADXL345 uses a fixed threshold resolution of 62.5 mg/LSB for >> event-related registers. Previously, the driver reported raw >> values without a scale factor. >> >> Implement IIO_EV_INFO_SCALE for all event types to provide the >> conversion factor (0.612915 m/s^2) as required by the IIO ABI. >> >> Suggested-by: Jonathan Cameron >> Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> >> --- >> drivers/iio/accel/adxl345_core.c | 28 ++++++++++++++++++++++------ >> 1 file changed, 22 insertions(+), 6 deletions(-) >> ... >> @@ -228,15 +230,19 @@ static const struct iio_event_spec adxl345_events[] = { >> .type = IIO_EV_TYPE_GESTURE, >> .dir = IIO_EV_DIR_SINGLETAP, >> .mask_separate = BIT(IIO_EV_INFO_ENABLE), >> - .mask_shared_by_type = BIT(IIO_EV_INFO_VALUE) | >> + .mask_shared_by_type = >> + BIT(IIO_EV_INFO_VALUE) | >> + BIT(IIO_EV_INFO_SCALE) | > > What is the units for gesture that we are scaling to? After looking at the docs, I understand this now, so no need to reply. > >> BIT(IIO_EV_INFO_TIMEOUT), >> },