From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C270BC433E1 for ; Mon, 17 Aug 2020 10:57:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B6DE2067C for ; Mon, 17 Aug 2020 10:57:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727893AbgHQK51 (ORCPT ); Mon, 17 Aug 2020 06:57:27 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:33778 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727021AbgHQK4f (ORCPT ); Mon, 17 Aug 2020 06:56:35 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id EA7F5FA70E4499864175; Mon, 17 Aug 2020 18:56:31 +0800 (CST) Received: from [10.174.187.22] (10.174.187.22) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Mon, 17 Aug 2020 18:56:26 +0800 Subject: Re: [PATCH 2/3] KVM: uapi: Remove KVM_DEV_TYPE_ARM_PV_TIME in kvm_device_type To: Steven Price , Marc Zyngier References: <20200817033729.10848-1-zhukeqian1@huawei.com> <20200817033729.10848-3-zhukeqian1@huawei.com> <4cd543a2-4d5b-882c-38d6-f5055512f0dc@huawei.com> <72e34f84-5bea-8f69-6699-29e2970c80b4@arm.com> CC: , , , , Catalin Marinas , Will Deacon , James Morse , Suzuki K Poulose , From: zhukeqian Message-ID: <40a10c89-d876-5aea-dd45-b7e75ef31c71@huawei.com> Date: Mon, 17 Aug 2020 18:56:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <72e34f84-5bea-8f69-6699-29e2970c80b4@arm.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.187.22] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steven, On 2020/8/17 17:49, Steven Price wrote: > On 17/08/2020 09:43, zhukeqian wrote: >> Hi Marc, >> [...] >>> >>> It is pretty unfortunate that PV time has turned into such a train wreck, >>> but that's what we have now, and it has to stay. >> Well, I see. It is a sad thing indeed. > > Sorry about that, this got refactored so many times I guess I lost track of what was actually needed and this hunk remained when it should have been removed. > It's fine :-) , not a serious problem. > I would hope that I'm the only one who has any userspace code which uses this, but I guess we should still be cautious since this has been in several releases now. > OK. For insurance purposes, we ought to ignore this patch to avoid breaking any user-space program. > Steve > . Thanks, Keqian >